[release/13.0] Remove .py and .js files from being signed (#13005) #13032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove .py files from being signed Our python starter template has an Authenitcode signature block in its .py files. These aren't wanted because users are meant to change these templates. Fix dotnet#13004 * PR feedback
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13032Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13032" |
Copilot finished reviewing on behalf of
eerhardt
November 18, 2025 16:49
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents Python (.py) files in the Python starter template from being Authenticode-signed during the build process. These template files are intended to be modified by users, so signing them is inappropriate and causes issues when users make changes.
Key changes:
- Added exclusion for .py files from the signing configuration
We have .js files in our templates that are currently getting signed in our official builds. We don't want this, nor signing .py files. Exclude them both the same way - Update + CertificateName=None.
eerhardt
changed the title
DamianEdwards
approved these changes
Nov 18, 2025
JamesNK
approved these changes
Nov 18, 2025
davidfowl
approved these changes
Nov 19, 2025
Member
Author
|
I was able to confirm that the packages produced from build https://dev.azure.com/dnceng/internal/_build/results?buildId=2844589 no longer have the signing blocks in the .py or .js files in our template package, but other files were signed. |
This was referenced Nov 26, 2025
Merged
Merged
Merged
This was referenced Dec 1, 2025
Merged
.Net: Bump Aspire.Hosting.Azure.CognitiveServices from 9.5.1 to 13.0.1
NatYou345/semantic-kernel#109
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #13005 to release/13.0
Customer Impact
Our python starter template has an Authenitcode signature block in its .py and .js files. These aren't wanted because users are meant to change these templates.
We were also signing .js files in our aspire-starter template as well. Removing that as dotnet/aspnetcore doesn't sign its .js files either. This is only needed in the Windows Script Host.
Fix #13004
Testing
None yet. I need an official branch to test it, I guess.
Risk
Low. We don't have other .py files in our product. And the .js files are only loaded in a browser which doesn't verify the signature.
Regression?
No