[release/9.5] Fix ParameterProcessor to use ExecutionContextOptions and skip excluded resources #11782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed resources - Use DistributedApplicationExecutionContextOptions constructor in CollectDependentParameterResourcesAsync - Copy ServiceProvider from existing execution context when available - Skip resources excluded from publish using IsExcludedFromPublish() - Add tests to verify ServiceProvider access and excluded resource filtering Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Use the executionContext from constructor instead of creating a new publishExecutionContext Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11782Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11782" |
captainsafia
approved these changes
Oct 1, 2025
joperezr
approved these changes
Oct 1, 2025
This was referenced Oct 13, 2025
This was referenced Oct 27, 2025
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11734 to release/9.5
/cc @davidfowl @copilot
Customer Impact
While processing parameters for deploy, we don't exclude resources that should be excluded from publish. This runs logic that should not run which sometimes breaks because it shouldn't run and includes more parameters than necessary.
Testing
Automated and manual.
Risk
Low
Regression?
No