Skip to content

[release/9.5] Fix globalPackagesFolder path to be platform-agnostic in NuGetConfigMerger #11626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

[release/9.5] Fix globalPackagesFolder path to be platform-agnostic in NuGetConfigMerger #11626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18645a5
Initial plan
Copilot Sep 24, 2025
d2b9cb7
Fix globalPackagesFolder path to be platform-agnostic
Copilot Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Aspire.Cli/Packaging/NuGetConfigMerger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,7 @@ private static void AddGlobalPackagesFolderConfiguration(XElement configuration)
// Add globalPackagesFolder configuration
var globalPackagesFolderAdd = new XElement("add");
globalPackagesFolderAdd.SetAttributeValue("key", "globalPackagesFolder");
globalPackagesFolderAdd.SetAttributeValue("value", ".nuget\\packages");
globalPackagesFolderAdd.SetAttributeValue("value", ".nugetpackages");
config.Add(globalPackagesFolderAdd);
}
}
Expand Down
4 changes: 2 additions & 2 deletions tests/Aspire.Cli.Tests/Packaging/PackagingServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ public async Task NuGetConfigMerger_WhenChannelRequiresGlobalPackagesFolder_Adds

var configContent = await File.ReadAllTextAsync(nugetConfigPath);
Assert.Contains("globalPackagesFolder", configContent);
Assert.Contains(".nuget\\packages", configContent);
Assert.Contains(".nugetpackages", configContent);

// Verify the XML structure
var doc = XDocument.Load(nugetConfigPath);
Expand All @@ -231,6 +231,6 @@ public async Task NuGetConfigMerger_WhenChannelRequiresGlobalPackagesFolder_Adds
var globalPackagesFolderAdd = configSection.Elements("add")
.FirstOrDefault(add => string.Equals((string?)add.Attribute("key"), "globalPackagesFolder", StringComparison.OrdinalIgnoreCase));
Assert.NotNull(globalPackagesFolderAdd);
Assert.Equal(".nuget\\packages", (string?)globalPackagesFolderAdd.Attribute("value"));
Assert.Equal(".nugetpackages", (string?)globalPackagesFolderAdd.Attribute("value"));
}
}