[release/9.5] Fix globalPackagesFolder path to be platform-agnostic in NuGetConfigMerger #11626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11626Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11626" |
mitchdenny
approved these changes
Sep 24, 2025
davidfowl
approved these changes
Sep 24, 2025
|
This is good to go.I just ran into this! |
|
Completing a feature added in 9.5.0, low risk. approved. |
This was referenced Oct 13, 2025
This was referenced Oct 27, 2025
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11624 to release/9.5
/cc @mitchdenny @copilot
Customer Impact
Fixes a bug which makes the staging feed mechanism in the CLI break on Linux and probably macOS machines as well. Basically, NuGet doesn't do the OS translation on the globalPackagesFolder config path separator, so it ends up being something that needs to be escaped which breaks restore.
This changes what we write to this setting from
.nuget\packagesto.nugetpackagesto sidestep this issue.Testing
Manual, and unit test updated (found whilst dogfooding on Linux).
Risk
Low.
Regression?