Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to configure the ACA resource properties through C# code #5179

Open
1 task done
Kumima opened this issue Aug 5, 2024 · 2 comments · May be fixed by #5470
Open
1 task done

Provide ability to configure the ACA resource properties through C# code #5179

Kumima opened this issue Aug 5, 2024 · 2 comments · May be fixed by #5470
Assignees
Labels
area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure feature A single user-facing feature. Can be grouped under an epic.
Milestone

Comments

@Kumima
Copy link

Kumima commented Aug 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

Currently, we can configure the Azure resources properties through Aspire.Hosting.Azure.{*ResourceType}. They are generated as *.module.bicep.

What about the built-in resources for azd deployment, including ContainerAppEnvironment, ContainerRegistry, LogAnalyticsWorkspace and so on? They are basically defined in resources.bicep.

In addition, what about the configuration for each container app service, such as the scale rule and custom domain? They are defined in *.tmpl.yaml.

Describe the solution you'd like

Provide ability to configure auto-generated resources and container app properties through C# code.

Additional context

No response

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Aug 5, 2024
@MateuszPeczek
Copy link

I was able to configure that manually after editing files generated by infra synth, but as you've mentioned on discord channel, it's far from optimal since it's getting overwritten on every infra synth generation.

It would be nice to have an option to configure those services for dev/prod scenarios where control over provisioned resources is necessary.

@davidfowl
Copy link
Member

You can read the details here Azure/azure-dev#3292

@davidfowl davidfowl added area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure and removed area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication labels Sep 7, 2024
@davidfowl davidfowl self-assigned this Sep 7, 2024
@davidfowl davidfowl added this to the 9.0 milestone Sep 7, 2024
@davidfowl davidfowl added the feature A single user-facing feature. Can be grouped under an epic. label Sep 7, 2024
@davidfowl davidfowl modified the milestones: 9.0, Backlog Sep 24, 2024
@davidfowl davidfowl linked a pull request Sep 25, 2024 that will close this issue
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure feature A single user-facing feature. Can be grouped under an epic.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants