Skip to content

Commit 66e77d8

Browse files
authored
chore: Bump Testcontainers to version 3.10.0 (#5539)
updates Testcontainers to the latest version `3.10.0`. This version includes a fix for the regression/changes made in the latest MSSQL Docker image (microsoft/mssql-docker#892). The recently added workaround (#5057, #5058) is no longer necessary. Fixes #5057
1 parent ab0a8d5 commit 66e77d8

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

Directory.Packages.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<PropertyGroup>
77
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
88
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
9-
<TestcontainersPackageVersion>3.9.0</TestcontainersPackageVersion>
9+
<TestcontainersPackageVersion>3.10.0</TestcontainersPackageVersion>
1010
</PropertyGroup>
1111
<ItemGroup>
1212
<!-- AWS SDK for .NET dependencies -->

tests/Aspire.Microsoft.Data.SqlClient.Tests/SqlServerContainerFixture.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
using Aspire.Components.Common.Tests;
55
using Aspire.Hosting;
6-
using DotNet.Testcontainers.Builders;
76
using Testcontainers.MsSql;
87
using Xunit;
98

@@ -22,7 +21,6 @@ public async Task InitializeAsync()
2221
{
2322
Container = new MsSqlBuilder()
2423
.WithImage($"{SqlServerContainerImageTags.Registry}/{SqlServerContainerImageTags.Image}:{SqlServerContainerImageTags.Tag}")
25-
.WithWaitStrategy(Wait.ForUnixContainer().UntilCommandIsCompleted("/opt/mssql-tools18/bin/sqlcmd", "-C", "-Q", "SELECT 1;")) // https://github.com/dotnet/aspire/issues/5057
2624
.Build();
2725
await Container.StartAsync();
2826
}

0 commit comments

Comments
 (0)