Skip to content

Commit 4d55aff

Browse files
Copilotcaptainsafia
andcommitted
Use extension method syntax for GetValueWithNormalizedKey across all files
Co-authored-by: captainsafia <1857993+captainsafia@users.noreply.github.com>
1 parent 3d144f1 commit 4d55aff

File tree

3 files changed

+4
-12
lines changed

3 files changed

+4
-12
lines changed

src/Aspire.Hosting.GitHub.Models/GitHubModelsExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public static IResourceBuilder<GitHubModelResource> AddGitHubModel(this IDistrib
3131
var defaultApiKeyParameter = builder.AddParameter($"{name}-gh-apikey", () =>
3232
{
3333
var configKey = $"Parameters:{name}-gh-apikey";
34-
var value = global::Aspire.IConfigurationExtensions.GetValueWithNormalizedKey(builder.Configuration, configKey);
34+
var value = builder.Configuration.GetValueWithNormalizedKey(configKey);
3535

3636
return value ??
3737
Environment.GetEnvironmentVariable("GITHUB_TOKEN") ??

src/Aspire.Hosting.OpenAI/OpenAIExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public static IResourceBuilder<OpenAIResource> AddOpenAI(this IDistributedApplic
2727
var defaultApiKeyParameter = builder.AddParameter($"{name}-openai-apikey", () =>
2828
{
2929
var configKey = $"Parameters:{name}-openai-apikey";
30-
var value = global::Aspire.IConfigurationExtensions.GetValueWithNormalizedKey(builder.Configuration, configKey);
30+
var value = builder.Configuration.GetValueWithNormalizedKey(configKey);
3131

3232
return value ??
3333
Environment.GetEnvironmentVariable("OPENAI_API_KEY") ??

src/Aspire.Hosting/ParameterResourceBuilderExtensions.cs

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -207,16 +207,8 @@ internal static string GetParameterValue(IConfiguration configuration, string na
207207
{
208208
configurationKey ??= $"Parameters:{name}";
209209

210-
// First try to get the value with the exact configuration key
211-
var value = configuration[configurationKey];
212-
213-
// If not found and the name contains dashes, try with underscores as a fallback
214-
// This supports command-line arguments and environment variables where dashes are replaced with underscores
215-
if (string.IsNullOrEmpty(value))
216-
{
217-
var normalizedKey = configurationKey.Replace("-", "_", StringComparison.Ordinal);
218-
value = configuration[normalizedKey];
219-
}
210+
// Use the shared helper to get the value with normalization support
211+
var value = configuration.GetValueWithNormalizedKey(configurationKey);
220212

221213
return value
222214
?? parameterDefault?.GetDefaultValue()

0 commit comments

Comments
 (0)