Skip to content

Commit 0b585a8

Browse files
Copilotdavidfowl
andcommitted
Fix GenerateParameterDefault tests to provide ServiceProvider with IConfiguration
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
1 parent 9bee1ff commit 0b585a8

File tree

1 file changed

+23
-5
lines changed

1 file changed

+23
-5
lines changed

tests/Aspire.Hosting.Tests/Orchestrator/ParameterProcessorTests.cs

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -803,13 +803,22 @@ private static ParameterResource CreateParameterWithGenericError(string name)
803803
public async Task InitializeParametersAsync_WithGenerateParameterDefaultInPublishMode_ThrowsWhenValueIsEmpty()
804804
{
805805
// Arrange
806-
var executionContext = new DistributedApplicationExecutionContext(DistributedApplicationOperation.Publish);
806+
var configuration = new ConfigurationBuilder().Build();
807+
var services = new ServiceCollection();
808+
services.AddSingleton<IConfiguration>(configuration);
809+
var serviceProvider = services.BuildServiceProvider();
810+
811+
var executionContext = new DistributedApplicationExecutionContext(
812+
new DistributedApplicationExecutionContextOptions(DistributedApplicationOperation.Publish, "manifest")
813+
{
814+
ServiceProvider = serviceProvider
815+
});
816+
807817
var interactionService = CreateInteractionService();
808818
var parameterProcessor = CreateParameterProcessor(
809819
interactionService: interactionService,
810820
executionContext: executionContext);
811821

812-
var configuration = new ConfigurationBuilder().Build();
813822
var parameterWithGenerateDefault = new ParameterResource(
814823
"generatedParam",
815824
parameterDefault => parameterDefault?.GetDefaultValue() ?? throw new MissingParameterValueException("Parameter 'generatedParam' is missing"),
@@ -830,12 +839,21 @@ public async Task InitializeParametersAsync_WithGenerateParameterDefaultInPublis
830839
public async Task InitializeParametersAsync_WithGenerateParameterDefaultInPublishMode_DoesNotThrowWhenValueExists()
831840
{
832841
// Arrange
833-
var executionContext = new DistributedApplicationExecutionContext(DistributedApplicationOperation.Publish);
834-
var parameterProcessor = CreateParameterProcessor(executionContext: executionContext);
835-
836842
var configuration = new ConfigurationBuilder()
837843
.AddInMemoryCollection(new Dictionary<string, string?> { ["Parameters:generatedParam"] = "existingValue" })
838844
.Build();
845+
846+
var services = new ServiceCollection();
847+
services.AddSingleton<IConfiguration>(configuration);
848+
var serviceProvider = services.BuildServiceProvider();
849+
850+
var executionContext = new DistributedApplicationExecutionContext(
851+
new DistributedApplicationExecutionContextOptions(DistributedApplicationOperation.Publish, "manifest")
852+
{
853+
ServiceProvider = serviceProvider
854+
});
855+
856+
var parameterProcessor = CreateParameterProcessor(executionContext: executionContext);
839857

840858
var parameterWithGenerateDefault = new ParameterResource(
841859
"generatedParam",

0 commit comments

Comments
 (0)