Skip to content

Switch GenAPI to an msbuild task for perf #8507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Switch GenAPI to an msbuild task for perf #8507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e3a732
Switch GenAPI to an msbuild task for perf
ViktorHofer Feb 23, 2022
9601ea2
Add comments to targets and rename property
ViktorHofer Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Common/Internal/BuildTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public abstract partial class BuildTask : ITask

internal Log Log
{
get { return _log ?? (_log = new Log(new TaskLoggingHelper(this))); }
get { return _log ??= new Log(new TaskLoggingHelper(this)); }
}

public BuildTask()
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Cci.Extensions/Writers/DocumentIdWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public void WriteAssemblies(IEnumerable<IAssembly> assemblies)
if (_kinds != 0)
{
assemblies = assemblies.OrderBy(a => a.Name.Value, StringComparer.OrdinalIgnoreCase);
foreach (var assembly in assemblies)
foreach (IAssembly assembly in assemblies)
Visit(assembly);
}
}
Expand Down
Loading