Support using unversioned lld as linker too #8189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Fedora and RHEL the `lld` executable is the plain unversioned `lld`. That's also usable as a linker if it's recent enough. See dotnet/runtime#58959 (comment) for more details and discussion.
Member
|
Looks good to me as it is. :) |
Member
|
I think that checking for lld via clang is a better way. We never execute lld directly, so we really care about the one that clang selects by itself. Especially when you have multiple clang / lld versions installed (like I do). Clang seems to always pick lld of the same version. |
am11
reviewed
Nov 16, 2021
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
omajid
changed the title
Member
Author
|
If this looks good to everyone, can someone please merge this? I dont have merge powers. |
Member
Author
|
Thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Fedora and RHEL the
lldexecutable is the plain unversionedlld. That's also usable as a linker if it's recent enough.See dotnet/runtime#58959 (comment)
for more details and discussion.
We have been carrying the 6.0 version of this patch for RHEL 8 on arm64 here: https://git.centos.org/rpms/dotnet6.0/blob/c8s/f/SOURCES/runtime-arm64-lld-fix.patch
There was an open question about parsing the lld version using clang like so:
Is that worth implementing?
cc @am11 @crummel @janvorli