Enable Linux #39

chcosta · 2018-02-28T22:57:43Z

Validating CI changes, not ready for review, but FYI @natemcmaster

build.sh

+
+SOURCE="${BASH_SOURCE[0]}"
+while [ -h "$SOURCE" ]; do # resolve $SOURCE until the file is no longer a symlink
+  ScriptRoot="$( cd -P "$( dirname "$SOURCE" )" && pwd )"


build/build.ps1

@@ -95,7 +95,7 @@ function InstallToolset {
    CreateDirectory $TempDir
    $proj = Join-Path $TempDir "_restore.proj"
    '<Project Sdk="RoslynTools.RepoToolset"><Target Name="NoOp"/></Project>' | Set-Content $proj
-    & $DotNetExe msbuild $proj /t:NoOp /m /nologo /clp:None /warnaserror /flp:v=diag /v:$verbosity /p:NuGetPackageRoot=$NuGetPackageRoot /p:__ExcludeSdkImports=true
+    & $DotNetExe msbuild $proj /t:NoOp /m /nologo /clp:None /warnaserror /v:$verbosity /p:NuGetPackageRoot=$NuGetPackageRoot /p:__ExcludeSdkImports=true


build/build.sh

@@ -0,0 +1,340 @@
+#!/bin/bash
+
+build=false


natemcmaster

Are the scripts a standard bootstrapper script from RepoToolset? Or do we have to maintain this separately?

build/build.sh

+  fi
+
+  # Install 1.0 shared framework
+  NetCoreApp10Version="1.0.5"


build/build.sh

+  esac
+done
+
+function CreateDirectory {


build/build.sh

+verbosity="minimal"
+properties=""
+
+while [[ $# > 0 ]]; do


build/build.sh

+}
+
+function readJson {  
+  UNAMESTR=`uname`


build/build.sh

+    bash "$DotNetInstallScript" --channel "Preview" --version $NetCoreApp10Version --shared-runtime $DotNetInstallVerbosity
+    LASTEXITCODE=$?
+
+    if [ $LASTEXITCODE != 0 ]


build/build.sh

+    dotnet nuget locals all --clear
+    LASTEXITCODE=$?
+
+    if [ $LASTEXITCODE != 0 ]


build/build.sh

+  RepoToolsetDestination="$NuGetPackageRoot/roslyntools.repotoolset/$ToolsetVersion/"
+  if [ ! -d "$RepoToolsetDestination" ]
+  then
+    cp -r $RepoToolsetSource $RepoToolsetDestination


build/cibuild.sh

+done
+ScriptRoot="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
+
+. "$ScriptRoot/build.sh" --restore --build --test --ci $@


build/build.sh

@@ -0,0 +1,340 @@
+#!/bin/bash


chcosta · 2018-03-01T00:11:05Z

Thanks for the reviews! I wasn't quite ready for that, I was more focused on validating the ci changes, but the feedback is appreciated. I'll clean up this code and ask for review tomorrow.

Linux builds are working - https://ci.dot.net/job/Private/job/dotnet_arcade/job/master/job/GenPRTest/job/Ubuntu16.04_release/9/console

They're not producing packages because we need to decide how to handle the nuspec expecting framework assemblies but they're not present on Linux...

  <files>
    <file src="$ArtifactsBinDir$Microsoft.DotNet.Build.Tasks.Feed\netstandard1.5\*.dll" target="build\netstandard1.5" />
    <file src="$ArtifactsBinDir$Microsoft.DotNet.Build.Tasks.Feed\net45\*.dll" target="build\net46" />

Most of the sh files were just grabbed from another RepoToolset repo and hacked a bit to work in Arcade. As I said, I haven't looked at them too much yet but I'll definitely take your feedback and try to make these better.

Are the scripts a standard bootstrapper script from RepoToolset? Or do we have to maintain this separately?

I don't believe that any standardization around bootstrapper scripts has moved forward yet so these are currently maintained separately. The standardization / bootstrapping is a separate discussion and I agree that it would have great benefit.

chcosta · 2018-03-01T19:48:31Z

I'm not aware of a style guide for writing bash that we have like we do for writing C#. I took away from the feedback that the goal was to be consistent so I found a style guide that looked reasonable and tried to conform to that (most of it echos @natemcmaster 's feedback) - https://github.com/bahamas10/bash-style-guide

I've validated that Linux builds. Please take another look at these changes, they now vary quite a bit from the original source due to the formatting changes. @jaredpar @natemcmaster @tmat

chcosta · 2018-03-01T20:03:47Z

/cc @weshaggard

Directory.Build.props

+      that exists to skip the GenerateReferenceAssemblyPaths task (not target) and to prevent it from outputting a warning (MSB3644).
+      Need to set these after the common targets import.
+      -->
+    <_TargetFrameworkDirectories>$(MSBuildThisFileDirectory)</_TargetFrameworkDirectories>


build/build.ps1

@@ -93,9 +93,17 @@ function MakeGlobalSdkAvailableLocal {
 function InstallToolset {
  if (!(Test-Path $ToolsetBuildProj)) {
    CreateDirectory $TempDir
+


natemcmaster

FYI my favorite bash linter is https://www.shellcheck.net/

build/build.sh

+globaljsonfile="$reporoot/global.json"
+tempdir="$artifactsconfigurationdir/tmp"
+
+while [[ $# > 0 ]]; do


build/build.sh

+# Result: Sets 'readjsonvalue' to the value of the provided json key
+# Note: this method may return unexpected results if there are duplicate
+# keys in the json
+function ReadJson {  


build/build.sh

+  fi
+
+  # Install 1.0 shared framework
+  local netcoreappversion='1.0.5'


chcosta · 2018-03-02T17:19:50Z

@tmat, @natemcmaster , any other concerns with this change?

natemcmaster · 2018-03-02T17:23:58Z

I'm going to wait on #35 until you merge this.

Enable .xlf translations for unstructured documents and VS templates.

chcosta added 4 commits February 26, 2018 10:37

Enable ci

f2a85a2

Merge branch 'master' of https://github.com/dotnet/arcade

c5b7fb3

Build on Linux (including enable CI)

12c15b9

minor cleanup

bbe80c1

chcosta self-assigned this Feb 28, 2018

jaredpar reviewed Feb 28, 2018

View reviewed changes

Add execute permissions

e1e6bc1

natemcmaster suggested changes Feb 28, 2018

View reviewed changes

chcosta added 3 commits February 28, 2018 15:58

line endings and other minor change

76b739e

Add pack command to linux ci build

943a0dd

Don't pack on Linux yet...

0335fa7

chcosta added 5 commits March 1, 2018 10:52

Consistentify the style

ac48a12

remove debugging echo statement

9c51785

Add missing bracket

939387d

Add pack restore project creation line that somehow got removed

cc326d4

Fix casing in netci.groovy

9c05546

Add binlog to toolset restore

6ecbd0e

weshaggard reviewed Mar 1, 2018

View reviewed changes

tmat reviewed Mar 1, 2018

View reviewed changes

Remove unneeded code

ecc1e45

chcosta changed the title ~~/* Do NOT merge*/ Enable Linux~~ Enable Linux Mar 1, 2018

natemcmaster reviewed Mar 2, 2018

View reviewed changes

chcosta added 2 commits March 1, 2018 16:59

Update comparison operator

3fdb5be

Remove uneeded logging

c98ebd8

natemcmaster approved these changes Mar 2, 2018

View reviewed changes

Merge branch 'master' of https://github.com/dotnet/arcade into linux

689489f

chcosta merged commit c7fe627 into dotnet:master Mar 2, 2018

chcosta deleted the linux branch March 2, 2018 17:33

chcosta mentioned this pull request Mar 2, 2018

Enable Linux build of Arcade repo #13

Closed

natemcmaster mentioned this pull request Mar 2, 2018

Add initial implementation of Microsoft.DotNet.Build.Tasks.IO #35

Merged

ViktorHofer pushed a commit to ViktorHofer/arcade that referenced this pull request Oct 25, 2023

Merge pull request dotnet#39 from brettfo/unstructured

ba548ca

Enable .xlf translations for unstructured documents and VS templates.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Linux #39

Enable Linux #39

chcosta commented Feb 28, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

natemcmaster left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

chcosta commented Mar 1, 2018

chcosta commented Mar 1, 2018 •

edited

Loading

chcosta commented Mar 1, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

natemcmaster left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

chcosta commented Mar 2, 2018

natemcmaster commented Mar 2, 2018

		@@ -0,0 +1,340 @@
		#!/bin/bash

		build=false

Enable Linux #39

Enable Linux #39

Conversation

chcosta commented Feb 28, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

natemcmaster left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

chcosta commented Mar 1, 2018

chcosta commented Mar 1, 2018 • edited Loading

chcosta commented Mar 1, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

natemcmaster left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

chcosta commented Mar 2, 2018

natemcmaster commented Mar 2, 2018

chcosta commented Mar 1, 2018 •

edited

Loading