Skip to content

Do not sign .js files by default #15760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025

Conversation

ellahathaway
Copy link
Member

Example output:

/repos/arcade-validation# ./build.sh -sign
  /root/.nuget/packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.29501.1/tools/Tools.proj                Restore (0.5s)
Restore complete (0.5s)
  Validation net10.0 succeeded (0.1s) → artifacts/bin/Validation/Debug/net10.0/Validation.dll
  Validation.Tests succeeded (0.5s) → artifacts/bin/Validation.Tests/Debug/net10.0/Validation.Tests.dll
  Sign succeeded (0.3s)
    /root/.nuget/packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.29501.1/tools/Sign.proj(76,5): error : Skipping file '/root/repos/arcade-validation/artifacts/packages/Debug/NonShipping/blazor.webview.js' because .js files are no longer signed by default. To disable this warning, please explicitly define the FileExtensionSignInfo for the .js extension or set the MSBuild property 'NoSignJS' to 'true'.

Build failed with 1 error(s) in 2.4s
Build failed with exit code 1. Check errors above.

{
_log.LogWarning($"Skipping file '{file.FullPath}' because .js files are no longer signed by default. " +
"To disable this warning, please explicitly define the FileExtensionSignInfo for the .js extension " +
"or set the MSBuild property 'NoSignJS' to 'true'.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open an issue to remove this breaking change and make NoSignJS the default, and link it in a comment here?

Ideally we won't leave this option around long.

Copy link
Member Author

@ellahathaway ellahathaway Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - linked the issue in 2da35cb

@ellahathaway
Copy link
Member Author

Looks like the tests had failures. I'll address those now

@ellahathaway ellahathaway requested a review from mmitche April 21, 2025 21:19
@ellahathaway ellahathaway merged commit 93536ed into dotnet:main Apr 22, 2025
11 checks passed
@ellahathaway ellahathaway deleted the remove-default-js-signing branch April 22, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants