Opt-in TargetRid publish mode #15549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enable us to fully dedup our vertical asset manifests in the VMR, we need some mechanism to specify that RID-agnostic packages shouldn't be published in particular verticals. One options would be to have the VMR automatically use "Vertical" visibility as the default for all non-"Win-x64 BuildPass1" legs and require repos that have RID-specific assets to mark them with the correct visibility. In this model, every repo that has RID specific assets would have to have almost the same logic in Publishing.props. Another option (this PR) is to add support into Arcade for a switch to automatically only add RID-specific packages as non-Vertical packages by default. This model ensures that we don't need to change every repo that produces RID-specific artifacts. It also provides a mechanism to opt-in for repositories that need to publish in this manner normally (useful for dotnet/runtime for the short period between the MicroBuild fixes and the official build being shut off).
akoeplinger
previously approved these changes
Feb 20, 2025
ViktorHofer
reviewed
Feb 20, 2025
ViktorHofer
approved these changes
Feb 20, 2025
ViktorHofer
added a commit
that referenced
this pull request
Feb 25, 2025
Regressed with #15549 MSBuild doesn't allow Condition attributes on Choose elements.
1 task
YuliiaKovalova
pushed a commit
that referenced
this pull request
Mar 20, 2025
|
This opt-in is now used in the VMR but most repos don't have access to the But other repositories might hit this as well in the future when RID specific packages get added that we don't account for today. I think we should pass that property in globally to all repositories. dotnet/source-build#4313 tracks that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable us to fully dedup our vertical asset manifests in the VMR, we need some mechanism to specify that RID-agnostic packages shouldn't be published in particular verticals.
One options would be to have the VMR automatically use "Vertical" visibility as the default for all non-"Win-x64 BuildPass1" legs and require repos that have RID-specific assets to mark them with the correct visibility. In this model, every repo that has RID specific assets would have to have almost the same logic in Publishing.props.
Another option (this PR) is to add support into Arcade for a switch to automatically only add RID-specific packages as non-Vertical packages by default. This model ensures that we don't need to change every repo that produces RID-specific artifacts. It also provides a mechanism to opt-in for repositories that need to publish in this manner normally (useful for dotnet/runtime for the short period between the MicroBuild fixes and the official build being shut off).
To double check:
Contributes to dotnet/source-build#4905