Skip to content

Update CodeAnalysis to 4.8.0 #14383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Update CodeAnalysis to 4.8.0 #14383

merged 3 commits into from
Jan 17, 2024

Conversation

ViktorHofer
Copy link
Member

We already require a VS 17.8 installation so the version bump shouldn't cause any min version requirement issues. This should unblock dotnet/runtime#97087

We already require a VS 17.8 installation so the version bump shouldn't cause any min version requirement issues. This should unblock dotnet/runtime#97087
@ViktorHofer ViktorHofer requested a review from mthalman January 17, 2024 18:15
@ViktorHofer ViktorHofer self-assigned this Jan 17, 2024
@mthalman
Copy link
Member

I'm not sure this is going to work. Since .NET 9 is being bootstrapped on itself, N-1 is really just a previous build of .NET 9. In that case, it would need to be a reference to 4.10.0.

@ViktorHofer
Copy link
Member Author

There aren't any SBRP for Microsoft.CodeAnalysis* with a 4.8.0 version which made me assume that because of that, the correct N-1 artifacts will be chosen. Let's try it out... The version upgrade makes sense anyway.

@mthalman
Copy link
Member

Oh, that's true. It may cause a prebuilt. We can live with that to get Preview 1 out the door.

@ViktorHofer ViktorHofer enabled auto-merge (squash) January 17, 2024 19:13
@ViktorHofer ViktorHofer merged commit 5c20578 into main Jan 17, 2024
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch January 17, 2024 19:13
@ellahathaway
Copy link
Member

Oh, that's true. It may cause a prebuilt. We can live with that to get Preview 1 out the door.

Updating to 4.6.0 caused prebuilts that were fixed in dotnet/source-build-reference-packages#858. I'm assuming that we'll have to repeat dotnet/source-build-reference-packages#858 for 4.8.0.

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Jan 17, 2024

No, if we add SBRPs for 4.8.0 we will hit the exact same problem that I'm working around via this PR when consuming GenFacades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants