Arcade MSBuild task packages shouldn't carry assemblies with it that are available inbox in VS / .NET SDK's msbuild

[ViktorHofer]

see #15018 (comment)

That's a bug in the msbuild tasks package authoring here in Arcade:

arcade/eng/BuildTask.targets

Lines 33 to 84 in a3756ed

	<!-- Don't include assemblies that MSBuild ships with. -->
	<ItemGroup>
	<PackageReference Update="Microsoft.Build" Publish="false" />
	<PackageReference Update="Microsoft.Build.Framework" Publish="false" />
	<PackageReference Update="Microsoft.Build.Tasks.Core" Publish="false" />
	<PackageReference Update="Microsoft.Build.Utilities.Core" Publish="false" />
	<PackageReference Update="Microsoft.NET.StringTools" Publish="false" />
	<PackageReference Update="System.Resources.Extensions" Publish="false" />
	</ItemGroup>
	<!-- Don't include assemblies that are provided by the SDK, next to MSBuild. -->
	<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp' and '$(SkipSDKInboxPublishExcludes)' != 'true'">
	<PackageReference Update="Newtonsoft.Json" Publish="false" />
	<PackageReference Update="NuGet.Commands" Publish="false" />
	<PackageReference Update="NuGet.Common" Publish="false" />
	<PackageReference Update="NuGet.Configuration" Publish="false" />
	<PackageReference Update="NuGet.Frameworks" Publish="false" />
	<PackageReference Update="NuGet.Packaging" Publish="false" />
	<PackageReference Update="NuGet.ProjectModel" Publish="false" />
	<PackageReference Update="NuGet.Versioning" Publish="false" />
	<PackageReference Update="System.CodeDom" Publish="false" />
	<PackageReference Update="System.Security.Cryptography.ProtectedData" Publish="false" />
	<PackageReference Update="System.Text.Encoding.CodePages" Publish="false" />
	</ItemGroup>
	<!-- Don't include assemblies that are inbox in Desktop MSBuild -->
	<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
	<PackageReference Update="Microsoft.Bcl.AsyncInterfaces" Publish="false" />
	<PackageReference Update="System.Buffers" Publish="false" />
	<PackageReference Update="System.Collections.Immutable" Publish="false" />
	<PackageReference Update="System.Memory" Publish="false" />
	<PackageReference Update="System.Numerics.Vectors" Publish="false" />
	<PackageReference Update="System.Reflection.Metadata" Publish="false" />
	<PackageReference Update="System.Reflection.MetadataLoadContext" Publish="false" />
	<PackageReference Update="System.Runtime.CompilerServices.Unsafe" Publish="false" />
	<PackageReference Update="System.Text.Encodings.Web" Publish="false" />
	<PackageReference Update="System.Text.Json" Publish="false" />
	<PackageReference Update="System.Threading.Channels" Publish="false" />
	<PackageReference Update="System.Threading.Tasks.Dataflow" Publish="false" />
	<PackageReference Update="System.Threading.Tasks.Extensions" Publish="false" />
	<PackageReference Update="System.ValueTuple" Publish="false" />
	</ItemGroup>
	<ItemGroup>
	<!--
	Update all PackageReference items to default Publish to true.
	This forces the publish output to contain the dlls.
	-->
	<PackageReference Update="@(PackageReference)">
	<Publish Condition="'%(PackageReference.Publish)' == ''">true</Publish>
	<ExcludeAssets Condition="'%(PackageReference.Publish)' == 'false'">runtime</ExcludeAssets>
	</PackageReference>

It only excludes direct package dependencies, not transitive ones. Unsure how to fix this, though.

[rainersigwald]

I think the problem is that src\Common\Microsoft.Arcade.Common\Microsoft.Arcade.Common.csproj doesn't drag in this logic, so it's that reference to MSBuild('s dependencies) that is treated as "normal".