Skip to content

Commit 9159815

Browse files
authored
Revert 7383 (#7595)
* Update badge branch names * Revert "Use helix reporting (#7383)" This reverts commit 7f52af2.
1 parent 03b92b3 commit 9159815

File tree

16 files changed

+612
-108
lines changed

16 files changed

+612
-108
lines changed

.gitignore

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,3 @@ node_modules/
131131
# Python Compile Outputs
132132

133133
*.pyc
134-
135-
# IntelliJ
136-
.idea/
137-
138-
# vscode python env files
139-
.env

eng/test-configuration.json

Lines changed: 0 additions & 5 deletions
This file was deleted.

src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/HelpersTests.cs

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
1-
using System;
2-
using System.IO;
31
using Xunit;
42
using System.Net;
5-
using Newtonsoft.Json;
63

74
namespace Microsoft.DotNet.Helix.Sdk.Tests
85
{
@@ -38,18 +35,5 @@ public void VerifyNonEncodedFowardSlashIsConverted()
3835

3936
Assert.Equal(workItemNameExpected, actual);
4037
}
41-
42-
[Fact]
43-
public void FailOnceThenPass()
44-
{
45-
var target = Path.Combine(Path.GetTempPath(), "my-test-file-123456.snt");
46-
bool exists = File.Exists(target);
47-
if (!exists)
48-
{
49-
File.WriteAllText(target, "Test failed once");
50-
}
51-
52-
Assert.True(exists, $"File should exist: {target}");
53-
}
5438
}
5539
}

src/Microsoft.DotNet.Helix/Sdk/SendHelixJob.cs

Lines changed: 4 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
using System.Collections.Generic;
33
using System.Globalization;
44
using System.IO;
5-
using System.IO.Compression;
65
using System.Linq;
76
using System.Text;
87
using System.Threading;
@@ -34,7 +33,6 @@ public static class MetadataNames
3433
public const string Uri = "Uri";
3534
public const string Destination = "Destination";
3635
public const string IncludeDirectoryName = "IncludeDirectoryName";
37-
public const string AsArchive = "AsArchive";
3836
}
3937

4038
/// <summary>
@@ -523,41 +521,16 @@ private IJobDefinition AddCorrelationPayload(IJobDefinition def, ITaskItem corre
523521
if (Directory.Exists(path))
524522
{
525523
string includeDirectoryNameStr = correlationPayload.GetMetadata(MetadataNames.IncludeDirectoryName);
526-
if (!bool.TryParse(includeDirectoryNameStr, out bool includeDirectoryName))
527-
{
528-
includeDirectoryName = false;
529-
}
524+
bool.TryParse(includeDirectoryNameStr, out bool includeDirectoryName);
530525

531-
Log.LogMessage(
532-
MessageImportance.Low,
533-
$"Adding Correlation Payload Directory '{path}', destination '{destination}'"
534-
);
526+
Log.LogMessage(MessageImportance.Low, $"Adding Correlation Payload Directory '{path}', destination '{destination}'");
535527
return def.WithCorrelationPayloadDirectory(path, includeDirectoryName, destination);
536-
537528
}
538529

539530
if (File.Exists(path))
540531
{
541-
string asArchiveStr = correlationPayload.GetMetadata(MetadataNames.AsArchive);
542-
if (!bool.TryParse(asArchiveStr, out bool asArchive))
543-
{
544-
asArchive = false;
545-
}
546-
547-
if (asArchive)
548-
{
549-
Log.LogMessage(
550-
MessageImportance.Low,
551-
$"Adding Correlation Payload Archive '{path}', destination '{destination}'"
552-
);
553-
return def.WithCorrelationPayloadArchive(path, destination);
554-
}
555-
556-
Log.LogMessage(
557-
MessageImportance.Low,
558-
$"Adding Correlation Payload File '{path}', destination '{destination}'"
559-
);
560-
return def.WithCorrelationPayloadFiles(path);
532+
Log.LogMessage(MessageImportance.Low, $"Adding Correlation Payload Archive '{path}', destination '{destination}'");
533+
return def.WithCorrelationPayloadArchive(path, destination);
561534
}
562535

563536
Log.LogError(FailureCategory.Build, $"Correlation Payload '{path}' not found.");

src/Microsoft.DotNet.Helix/Sdk/tools/Microsoft.DotNet.Helix.Sdk.MonoQueue.targets

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,7 @@
33
<PropertyGroup>
44
<EnableXUnitReporter Condition=" '$(EnableXUnitReporter)' != 'true' ">false</EnableXUnitReporter>
55
</PropertyGroup>
6-
7-
<PropertyGroup Condition=" '$(HelixTestConfigurationFilePath)' == '' ">
8-
<HelixTestConfigurationFilePath Condition=" '$(RepositoryEngineeringDir)' != '' ">$(RepositoryEngineeringDir)/test-configuration.json</HelixTestConfigurationFilePath>
9-
</PropertyGroup>
10-
6+
117
<Choose>
128
<When Condition="$(HelixTargetQueue.ToLowerInvariant().Contains('windows'))">
139
<PropertyGroup>
@@ -40,10 +36,6 @@
4036
<HelixProperties Condition="'$(HelixArchitecture)' != ''" Include="architecture" Value="$(HelixArchitecture)" />
4137
<HelixProperties Include="operatingSystem" Value="$(HelixTargetQueue)" />
4238
</ItemGroup>
43-
44-
<ItemGroup Condition="Exists('$(HelixTestConfigurationFilePath)')">
45-
<HelixCorrelationPayload Include="$(HelixTestConfigurationFilePath)" AsArchive="false" />
46-
</ItemGroup>
4739

4840
<Target Name="CoreBuild">
4941
</Target>

src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
<PropertyGroup>
88
<HelixPostCommands Condition="$(IsPosixShell)">
99
$(HelixPostCommands);
10-
$HELIX_PYTHONPATH $HELIX_CORRELATION_PAYLOAD/reporter/run.py $(SYSTEM_TEAMFOUNDATIONCOLLECTIONURI) $(SYSTEM_TEAMPROJECT) $(TestRunId) $(SYSTEM_ACCESSTOKEN) || exit $?
10+
/bin/sh $HELIX_CORRELATION_PAYLOAD/reporter/run.sh $(SYSTEM_TEAMFOUNDATIONCOLLECTIONURI) $(SYSTEM_TEAMPROJECT) $(TestRunId) $(SYSTEM_ACCESSTOKEN) || exit $?
1111
</HelixPostCommands>
1212
<HelixPostCommands Condition="!$(IsPosixShell)">
1313
$(HelixPostCommands);
14-
%HELIX_PYTHONPATH% %HELIX_CORRELATION_PAYLOAD%\reporter\run.py $(SYSTEM_TEAMFOUNDATIONCOLLECTIONURI) $(SYSTEM_TEAMPROJECT) $(TestRunId) $(SYSTEM_ACCESSTOKEN) || exit /b
14+
call %HELIX_CORRELATION_PAYLOAD%\reporter\run.bat $(SYSTEM_TEAMFOUNDATIONCOLLECTIONURI) $(SYSTEM_TEAMPROJECT) $(TestRunId) $(SYSTEM_ACCESSTOKEN) || exit /b
1515
</HelixPostCommands>
1616
</PropertyGroup>
1717

0 commit comments

Comments
 (0)