-
Notifications
You must be signed in to change notification settings - Fork 546
Switch more over to System.Text.Json #9819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06ec5dd
to
7fda7e5
Compare
src/Xamarin.Android.Build.Tasks/Tasks/JavaDependencyVerification.cs
Outdated
Show resolved
Hide resolved
dellis1972
commented
Feb 24, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
dellis1972
commented
Feb 24, 2025
src/Xamarin.Android.Build.Tasks/Tasks/JavaDependencyVerification.cs
Outdated
Show resolved
Hide resolved
jonathanpeppers
approved these changes
Feb 25, 2025
@@ -116,7 +116,6 @@ | |||
<_MSBuildFiles Include="$(MicrosoftAndroidSdkOutDir)Mono.Options.dll" /> | |||
<_MSBuildFiles Include="$(MicrosoftAndroidSdkOutDir)Mono.Options.pdb" /> | |||
<_MSBuildFiles Include="$(MicrosoftAndroidSdkOutDir)MULTIDEX_JAR_LICENSE" /> | |||
<_MSBuildFiles Include="$(MicrosoftAndroidSdkOutDir)Newtonsoft.Json.dll" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, is System.Text.Json in the pack?
It would be needed for .NET framework.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP commit message: [Xamarin.Android.Build.Tasks] Remove use of Newtonsoft.Json (#9819)
Context: https://github.com/dotnet/android/issues/9229
Remove use of Newtonsoft.Json from `Xamarin.Android.Build.Tasks.dll`.
Notes:
* `JsonElement` is read only. This is why we convert them to
`JsonNode`.
* `JsonNode.Parse()` does NOT have the same features as
`JsonDocument.Parse()`, e.g you CANNOT tell it to ignore trailing
comma's; it will just throw an exception. This is the reason why
we have to load the `.json` via `JsonDocument` and then call the
extension method `.ToNode ()` on the Root `JsonElement` to convert
it to a `JsonNode`. (We use `JsonNode` to do the merging). Question: does this PR fix #9229? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.ToNode ()
on the Root JsonElement to convert it to a JsonNode. (We use JsonNode to do the merging).