[Xamarin.Android.Build.Tasks] use copilot to opt into NRT #9770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
reviewed
Feb 7, 2025
|
Something actually broke in the |
jpobst
reviewed
Feb 10, 2025
Context: https://code.visualstudio.com/docs/copilot/copilot-customization We have various MSBuild tasks that have not enabled C# nullable reference types. This is a bit tedious to do, so I tried VS Code Insiders and GitHub Copilot "Edits" to do this work. I did this for just a few files for now. I introduced a new file `.github/copilot-instructions.md` to keep copilot from going off the rails! I mostly had to fight it to respect our code formatting, not delete comments, etc. I would recommend the settings: "github.copilot.chat.codeGeneration.useInstructionFiles": true, "github.copilot.chat.codeGeneration.instructions": [ { "file": ".editorconfig" }, { "file": "README.md" } ], * `github.copilot.chat.codeGeneration.useInstructionFiles`: enables the use of `.github/copilot-instructions.md` * `github.copilot.chat.codeGeneration.instructions`: attaches `.editorconfig` and `README.md` so copilot has general context about this repo. In the end it did a decent job, but I had to manually fix a few things.
jonathanpeppers
force-pushed
the
dev/peppers/nrt1
branch
from
bbd493f to
3a0f3af
Compare
dellis1972
reviewed
Feb 11, 2025
dellis1972
approved these changes
Feb 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://code.visualstudio.com/docs/copilot/copilot-customization
We have various MSBuild tasks that have not enabled C# nullable reference types. This is a bit tedious to do, so I tried VS Code Insiders and GitHub Copilot "Edits" to do this work. I did this for just a few files for now.
I introduced a new file
.github/copilot-instructions.mdto keep copilot from going off the rails! I mostly had to fight it to respect our code formatting, not delete comments, etc.I would recommend the settings:
github.copilot.chat.codeGeneration.useInstructionFiles: enables the use of.github/copilot-instructions.mdgithub.copilot.chat.codeGeneration.instructions: attaches.editorconfigandREADME.mdso copilot has general context about this repo.In the end it did a decent job, but I had to manually fix a few things.