Skip to content

Conversation

@jonathanpeppers
Copy link
Member

@jonathanpeppers jonathanpeppers commented Oct 9, 2023

Changes: dotnet/java-interop@8e63cc8...ed63d89

  • [generator] restore [RegisterAttribute] for *Implementor types

@jonathanpeppers
Copy link
Member Author

The test passes now, but was failing before I bumped java.interop:

image

Changes: dotnet/java-interop@8e63cc8...ed63d89

* [generator] restore `[RegisterAttribute]` for *Implementor types
@jonathanpeppers jonathanpeppers changed the title Test for xamarin/java.interop#1149 Bump to xamarin/java.interop/main@ed63d890 Oct 10, 2023
@jonathanpeppers jonathanpeppers marked this pull request as ready for review October 10, 2023 02:20
@jonathanpeppers
Copy link
Member Author

We've seen timeouts on other PRs, this one seems OK to merge.

@jonathanpeppers jonathanpeppers merged commit 0945978 into dotnet:main Oct 10, 2023
@jonathanpeppers jonathanpeppers deleted the java.interop-1149 branch October 10, 2023 16:12
jonathanpeppers added a commit that referenced this pull request Oct 10, 2023
Changes: dotnet/java-interop@8e63cc8...ed63d89

* [generator] restore `[RegisterAttribute]` for *Implementor types

Other changes:

* Added test to verify `Lmono/android/view/View_OnClickListenerImplementor;` exists
  after a build using `AndroidLinkMode=r8`.

dotnet/java-interop#1149
grendello added a commit to grendello/xamarin-android that referenced this pull request Oct 11, 2023
* main:
  [Xamarin.Android.Build.Tasks] case-insensitive Legacy Designer fixup (dotnet#8376)
  [build] Update docs and remove `xabuild` mentions (dotnet#8406)
  Bump to xamarin/java.interop/main@ed63d890 (dotnet#8407)
jonathanpeppers added a commit that referenced this pull request Oct 17, 2023
Changes: dotnet/java-interop@8e63cc8...ed63d89

* [generator] restore `[RegisterAttribute]` for *Implementor types

Other changes:

* Added test to verify `Lmono/android/view/View_OnClickListenerImplementor;` exists
  after a build using `AndroidLinkMode=r8`.

dotnet/java-interop#1149
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants