Skip to content

Conversation

@grendello
Copy link
Contributor

NOTE: do not merge, since NDK r26 is still in beta

Changes: https://github.com/android/ndk/wiki/Changelog-r26#announcements

NDK r26 has the following changes which are interesting to us:

  • libc++ has been updated. The NDK's libc++ now comes directly from
    our LLVM toolchain, so every future LLVM update is also a libc++
    update.
  • Updated LLVM to clang-r487747c, based on LLVM 17 development

The libc++ update brings internal implementation changes, and as the
result we no longer need to partially instantiate a couple of classes
previously underlying the vector<T> and basic_string<T>
implementations.

Changes: https://github.com/android/ndk/wiki/Changelog-r26#announcements

NDK r26 has the following changes which are interesting to us:

  * libc++ has been updated. The NDK's libc++ now comes directly from
    our LLVM toolchain, so every future LLVM update is also a libc++
    update.
  * Updated LLVM to clang-r487747c, based on LLVM 17 development

The `libc++` update brings internal implementation changes, and as the
result we no longer need to partially instantiate a couple of classes
previously underlying the `vector<T>` and `basic_string<T>`
implementations.
@grendello grendello added the do-not-merge PR should not be merged. label Jul 24, 2023
* main:
  [ci] Add MAUI integration job (dotnet#8200)
* main:
  Bump to dotnet/installer@f8bab721ae 8.0.100-rc.1.23373.1 (dotnet#8202)
  [Mono.Android] Fix Context.RegisterReceiver() enumification (dotnet#7735)
* main: (57 commits)
  Bump to dotnet/installer@2809943e7a 8.0.100-rc.2.23431.5 (dotnet#8317)
  [build] Use Microsoft OpenJDK 17.0.8 (dotnet#8309)
  [Mono.Android] Add missing `[Flags]` attribute for generated enums. (dotnet#8310)
  Bump to dotnet/installer@c5e45fd659 8.0.100-rc.2.23427.4 (dotnet#8305)
  [xaprepare] Improve dotnet-install script logging (dotnet#8312)
  [xaprepare] Fix dotnet-install script size check (dotnet#8311)
  [Xamarin.Android.Build.Tasks] improve net6.0 "out of support" message (dotnet#8307)
  [monodroid] Fix the EnableNativeAnalyzers build (dotnet#8293)
  Bump to dotnet/installer@56d8c6497c 8.0.100-rc.2.23422.31 (dotnet#8291)
  [Xamarin.Android.Build.Tasks] Fix APT2264 error on Windows. (dotnet#8289)
  [Mono.Android] Marshal .NET stack trace to Throwable.getStackTrace() (dotnet#8185)
  [tests] Skip sign check when installing MAUI (dotnet#8288)
  Bump to xamarin/monodroid@057b17fe (dotnet#8286)
  [Xamarin.Android.Build.Tasks] add $(AndroidStripILAfterAOT) (dotnet#8172)
  Bump to dotnet/installer@ec2c1ec1b1 8.0.100-rc.2.23420.6 (dotnet#8281)
  Bump to dotnet/installer@001d8e4465 8.0.100-rc.2.23417.14 (dotnet#8276)
  [Mono.Android] [IntentFilter] pathSuffix & pathAdvancedPattern  (dotnet#8261)
  $(AndroidPackVersionSuffix)=rc.2; net8 is 34.0.0-rc.2 (dotnet#8278)
  Bump to xamarin/xamarin-android-tools/main@52f0866 (dotnet#8241)
  [build] set file extension for common `ToolExe` values (dotnet#8267)
  ...
* main:
  Localized file check-in by OneLocBuild Task (dotnet#8350)
  [ci] Install signing plugin after building (dotnet#8346)
  Bump to dotnet/installer@e1fd7d9649 8.0.100-rc.2.23468.1 (dotnet#8330)
  Localized file check-in by OneLocBuild Task (dotnet#8341)
  LEGO: Merge pull request 8344
  LEGO: Merge pull request 8343
  [ci] Run more MSBuild tests on Linux (dotnet#8335)
  [Xamarin.Android.Build.Tasks] Improve aapt2 error messages for paths (dotnet#7710)
  Bump to dotnet/installer@a6b9030047 8.0.100-rc.2.23462.1 (dotnet#8327)
  Bump to dotnet/installer@476310d94a 8.0.100-rc.2.23456.6 (dotnet#8325)
@grendello grendello changed the title [DO NOT MERGE] Bump NDK to r26 Bump NDK to r26 Sep 19, 2023
@grendello grendello removed the do-not-merge PR should not be merged. label Sep 19, 2023
@grendello grendello marked this pull request as ready for review September 19, 2023 14:50
    jni/reuse-threads.c(102,107): error GC3C66DD4: call to undeclared library function 'strerror' with type 'char *(int)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    jni/reuse-threads.c(302,36): error G59A96D9D: incompatible function pointer types passing 'int (void *)' to parameter of type 'void * _Nonnull (* _Nonnull)(void * _Nonnull)' [-Wincompatible-function-pointer-types]
Fix a typo in function return type and go back to `return`
statements with proper casts.

Fix some compiler warnings
@dellis1972 dellis1972 added do-not-merge PR should not be merged. and removed do-not-merge PR should not be merged. labels Sep 20, 2023
@jonpryor jonpryor merged commit 8ef7a6e into dotnet:main Sep 21, 2023
@grendello grendello deleted the bump-ndk branch September 21, 2023 22:16
grendello added a commit to grendello/xamarin-android that referenced this pull request Sep 22, 2023
* main:
  [Xamarin.Android.Build.Tasks] Add `RunWithLogging` target (dotnet#8324)
  [Xamarin.Android.Build.Tasks] AndroidJavaSource refs dependent jars (dotnet#8194)
  Bump to xamarin/Java.Interop/main@75d8221 (dotnet#8336)
  Bump NDK to r26 (dotnet#8213)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants