Skip to content

Attempt to get better logcat logging for failed tests #7816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Attempt to get better logcat logging for failed tests #7816

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9800f40
Attempt to get better logcat logging for failed tests
grendello Feb 21, 2023
8c58925
Merge branch 'main' into improve-logcat
grendello Feb 22, 2023
2c5e04f
Use WaitFor
grendello Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/DeviceTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public void AssertHasDevices (bool fail = true)
public void DeviceSetup ()
{
SetAdbLogcatBufferSize (64);
RunAdbCommand ("logcat -c");
ClearAdbLogcat ();
CreateGuestUser (GuestUserName);
}

Expand All @@ -69,6 +69,9 @@ public void CheckDevice ()
TestContext.Out.WriteLine ($"{nameof(CheckDevice)} is restarting the emulator.");
RestartDevice (Path.Combine (Root, "Emulator.csproj"));
}

// We want to start with a clean logcat buffer for each test
ClearAdbLogcat ();
}

[TearDown]
Expand All @@ -82,6 +85,9 @@ protected override void CleanupTest ()
string remote = "/data/local/tmp/screenshot.png";
string localUi = Path.Combine (outputDir, "ui.xml");
RunAdbCommand ($"shell screencap {remote}");

// Give the app a chance to finish logging
WaitFor (1000);
var output = RunAdbCommand ($"logcat -d");
File.WriteAllText (deviceLog, output);
RunAdbCommand ($"pull {remote} \"{local}\"");
Expand Down