[main] Update dependencies from dotnet/installer #7127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…220627.1 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-preview.6.22316.8 -> To Version 7.0.100-preview.7.22327.1 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Manifest-7.0.100 From Version 7.0.100-1.22310.2 -> To Version 7.0.100-1.22323.2 (parent: Microsoft.Dotnet.Sdk.Internal
dotnet-maestro
bot
requested review from
jonathanpeppers,
jonpryor and
pjcollins
as code owners
Member
|
A new assembly has appeared in apps? |
There appears to be a new System.Xml.Linq facade with:
[assembly: TypeForwardedTo(typeof(XAttribute))]
[assembly: TypeForwardedTo(typeof(XElement))]
We can ignore this.
Member
|
Ok, the Xamarin.Forms "app size" test, has a new System.Xml.Linq facade with: So, I think we can ignore this. |
Member
|
There is a test currently blocked on: |
Member
|
So we can wait for this fix to flow here: dotnet/runtime#71411 Or if we need it sooner for some reason, maybe I can disable some tests, let me know. |
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Jun 30, 2022
Context: https://github.com/xamarin/xamarin-android/tree/release/7.0.1xx-preview6 Context: dotnet#7127 We branched for .NET 7 Preview 6, and there is already a Maestro bump for .NET 7 Preview 7. Let's update xamarin-android/main's version number.
jonpryor
pushed a commit
that referenced
this pull request
Jun 30, 2022
Context: https://github.com/xamarin/xamarin-android/tree/release/7.0.1xx-preview6 Context: #7127 We branched for .NET 7 Preview 6, and there is already a Maestro bump for .NET 7 Preview 7. Let's update xamarin-android/main's version number.
jonathanpeppers
approved these changes
Jul 1, 2022
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
I think we can ignore the 1 test failure:
Exceeded expected time of 3850ms, actual 3885.37ms
Looking at the .binlog, I don't see an actual regression in there.
jonathanpeppers
deleted the
darc-main-c081764c-bbdd-4561-82bd-a59b76df22f3
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/installer