[Mono.Android.Export] Fix DynamicDependency to JavaArray #6105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For awhile, we've been observing ILLink warnings: ILLink warning IL2036: Java.Interop.DynamicInvokeTypeInfo.ToNative(CodeExpression): Unresolved type 'Android.Runtime.JavaArray' in DynamicDependencyAttribute The cause is a "typo" in commit 15269f6, which added the `[DynamicDependency]` custom attributes to `DynamicInvokeTypeInfo.ToNative()`: commit 15269f6 specified the non-generic type `Android.Runtime.JavaArray`, which does not exist. Fix the `[DynamicDependency]` custom attribute value to instead mention ``Android.Runtime.JavaArray`1``, the type `JavaArray<T>`. This should fix the IL2036 warning.
jonathanpeppers
approved these changes
Jul 20, 2021
jonpryor
added a commit
that referenced
this pull request
Jul 20, 2021
For awhile, we've been observing ILLink warnings: ILLink warning IL2036: Java.Interop.DynamicInvokeTypeInfo.ToNative(CodeExpression): Unresolved type 'Android.Runtime.JavaArray' in DynamicDependencyAttribute The cause is a "typo" in commit 15269f6, which added the `[DynamicDependency]` custom attributes to `DynamicInvokeTypeInfo.ToNative()`: commit 15269f6 specified the non-generic type `Android.Runtime.JavaArray`, which does not exist. Fix the `[DynamicDependency]` custom attribute value to instead mention ``Android.Runtime.JavaArray`1``, the type `JavaArray<T>`. This should fix the IL2036 warning.
thaystg
added a commit
to thaystg/xamarin-android
that referenced
this pull request
Jul 23, 2021
…er_unhandled_exception * origin/main: Bump to dotnet/installer@19943da 6.0.100-rc.1.21372.10 (dotnet#6110) [xaprepare] don't install microsoft-net-runtime-android workload (dotnet#6114) [Mono.Android] Use `mono_unhandled_exception` for NET6 (dotnet#6104) Bump to dotnet/installer@9c463710 6.0.100-rc.1.21369 (dotnet#6072) Bump to xamarin/xamarin-android-binutils/2.37-XA.1@77618674 v2.37 (dotnet#6096) [Mono.Android.Export] Fix DynamicDependency to JavaArray (dotnet#6105) [xaprepare] always delete ~/android-toolchain/dotnet (dotnet#6098) [CI] Add nuget to msi conversion and VS insert stage (dotnet#6030) [build] delete platform-31 folder on test jobs (dotnet#6103)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For awhile, we've been observing ILLink warnings:
The cause is a "typo" in commit 15269f6, which added the
[DynamicDependency]custom attributes toDynamicInvokeTypeInfo.ToNative(): commit 15269f6 specified thenon-generic type
Android.Runtime.JavaArray, which does not exist.Fix the
[DynamicDependency]custom attribute value to insteadmention
Android.Runtime.JavaArray`1, the typeJavaArray<T>.This should fix the IL2036 warning.