[tests] Disable a Mono.Posix test #4869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Android 11` / `API 30` made the `memfd_create(2)` Linux-specific API
fail whenever the `MFD_CLOEXEC | MFD_ALLOW_SEALING` combination of flags
is passed to it:
Xamarin.Android.Bcl_Tests, MonoTests.Mono.Unix.Native.MemfdTest.TestMemfd / Release
System.ArgumentOutOfRangeException : Current platform doesn't support this value.
Parameter name: value
Actual value was MFD_CLOEXEC, MFD_ALLOW_SEALING.
Disable the test altogether, since this API isn't used by
`Xamarin.Android` and any applications using it will/should check the
`errno` variable for the `ENOSYS` value to see if the API is supported
or not. This will unblock us, allowing update of our Android emulator
system image to API 30.
jonathanpeppers
approved these changes
Jun 25, 2020
jonpryor
pushed a commit
that referenced
this pull request
Jun 26, 2020
…4869) Android 11/API-30 made the [**memfd_create**(2)][0] Linux-specific API fail whenever the `MFD_CLOEXEC | MFD_ALLOW_SEALING` combination of flags is passed to it, resulting in "BCL" unit test failures: Xamarin.Android.Bcl_Tests, MonoTests.Mono.Unix.Native.MemfdTest.TestMemfd / Release System.ArgumentOutOfRangeException : Current platform doesn't support this value. Parameter name: value Actual value was MFD_CLOEXEC, MFD_ALLOW_SEALING. Disable the test altogether, since this API isn't used by `Xamarin.Android` and any applications using it will/should check the `errno` variable for the `ENOSYS` value to see if the API is supported or not. This will unblock us, allowing update of our Android emulator system image to API 30. [0]: https://man7.org/linux/man-pages/man2/memfd_create.2.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android 11/API 30made thememfd_create(2)Linux-specific APIfail whenever the
MFD_CLOEXEC | MFD_ALLOW_SEALINGcombination of flagsis passed to it:
Disable the test altogether, since this API isn't used by
Xamarin.Androidand any applications using it will/should check theerrnovariable for theENOSYSvalue to see if the API is supportedor not. This will unblock us, allowing update of our Android emulator
system image to API 30.