[Xamarin.Android.Build.Tasks] Wrong AndroidManifest.xml packaged to the APK while using binding library #4812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
requested review from
brendanzagaeski,
jonathanpeppers and
jonpryor
as code owners
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
Should we add a test in InstallTests.cs that was showing the issue? Was it as simple as using the support library and it wouldn't install successfully?
Contributor
Author
|
@jonathanpeppers waiting on a good repo from the custom. The steps they provided did not work |
dellis1972
force-pushed
the
Issue4804
branch
2 times, most recently
from
301caff to
21d98c1
Compare
dellis1972
force-pushed
the
Issue4804
branch
2 times, most recently
from
98e21eb to
15e68f1
Compare
…he APK while using binding library Fixes dotnet#4804 We were overwriting the AndroidManifest.xml file in the apk with ones from Support Libraries. This manifests itself with the following error ``` Failed to parse APK info: failed to parse AndroidManifest.xml, error: %!s() deploy failed, error: failed to get apk infos, output: W/ResourceType( 5266): Bad XML block: ``` This commit fixes this issue by ignoring files from .jar files which already exist in the apk. This stops things from being overwritten. A test has also been added.
jonathanpeppers
approved these changes
Jun 24, 2020
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
I'll restart the build once, the hang should be fixed now.
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonpryor
pushed a commit
that referenced
this pull request
Jun 26, 2020
…4812) Fixes: #4804 We were overwriting the `AndroidManifest.xml` file in the `.apk` with ones from Support Libraries. This manifests itself with the following runtime error: Failed to parse APK info: failed to parse AndroidManifest.xml, error: %!s() deploy failed, error: failed to get apk infos, output: W/ResourceType( 5266): Bad XML block: This commit fixes this issue by ignoring files from `.jar` files which already exist in the `.apk`. This stops things from being overwritten. A test has also been added.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4804
We were overwriting the AndroidManifest.xml file in the apk with
ones from Support Libraries. This manifests itself with the following error
This commit fixes this issue by ignoring files from .jar files
which already exist in the apk. This stops things from being
overwritten. A test has also been added.