[xabuild.exe] fix for .NET standard projects #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://github.com/Microsoft/msbuild/blob/master/src/Shared/BuildEnvironmentHelper.cs#L511 `xabuild.exe` did not support building .NET standard projects. It turns out a `MSBuildSDKPaths` environment variable needed to be set for locating the `Sdks` directory. On Windows, this path is relative to Visual Studio / MSBuild, but on Mac I had to hardcode the path to .NET Core. It seems to use the same path on Linux as well.
|
@jonathanpeppers, |
dellis1972
approved these changes
Nov 6, 2017
jonpryor
pushed a commit
that referenced
this pull request
Jul 19, 2022
Fixes: dotnet/java-interop#969 Fixes: dotnet/java-interop#982 Fixes: dotnet/java-interop#984 Changes: dotnet/java-interop@fadbb82...032f1e7 * dotnet/java-interop@032f1e71: [Xamarin.Android.Tools.Bytecode-Tests] Fix BuildClasses (#1013) * dotnet/java-interop@0eaa47e1: [Java.Interop.Tools.JavaCallableWrappers] NRT Support (#1012) * dotnet/java-interop@45fe3928: [generator] BG8403 when type name matches enclosing namespace name (#1010) * dotnet/java-interop@fe60483b: [generator] Mark abstract methods as [Obsolete] if needed (#1011) * dotnet/java-interop@275fa755: [generator] Kotlin metadata can apply to multiple Java method (#1009) * dotnet/java-interop@3ff6f8fb: [Java.Base] Fix CS0108 Warnings (#1008) Of note is dotnet/java-interop@fe60483b, which can cause public members to become marked as `[Obsolete]`. These members *always* should have been `[Obsolete]`, but weren't. (Oops.) This also required changes to the `Mono.Android` API-compat checks. Also of note is dotnet/java-interop@45fe3928, which introduces a new BG8403 binding warning when a bound type has the same name as its enclosing namespace name-part, e.g. `Example.View.View`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/Microsoft/msbuild/blob/master/src/Shared/BuildEnvironmentHelper.cs#L511
xabuild.exedid not support building .NET standard projects. It turnsout a
MSBuildSDKPathsenvironment variable needed to be set for locatingthe
Sdksdirectory. On Windows, this path is relative to Visual Studio /MSBuild, but on Mac I had to hardcode the path to .NET Core. It seems to
use the same path on Linux as well.