Skip to content

Commit e62dcb0

Browse files
Set TrimMode partial by default (#7132)
Companion to dotnet/linker#2856 * Update src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets * Remove more usages of TrimMode * Update linker versions manually Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
1 parent 3ca5c80 commit e62dcb0

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@
6464
<PublishTrimmed Condition=" '$(PublishTrimmed)' == '' and '$(Configuration)' == 'Release' and '$(AndroidLinkMode)' != 'None' ">true</PublishTrimmed>
6565
<AndroidLinkMode Condition=" '$(AndroidLinkMode)' == '' and '$(PublishTrimmed)' == 'true' ">SdkOnly</AndroidLinkMode>
6666
<AndroidLinkMode Condition=" '$(AndroidLinkMode)' == '' ">None</AndroidLinkMode>
67-
<TrimmerDefaultAction Condition=" '$(TrimmerDefaultAction)' == '' and '$(AndroidLinkMode)' == 'Full' ">link</TrimmerDefaultAction>
67+
<!-- For compat with user code not marked trimmable, only trim opt-in by default. -->
68+
<TrimMode Condition=" '$(TrimMode)' == '' and '$(AndroidLinkMode)' == 'Full' ">link</TrimMode>
69+
<TrimMode Condition="'$(TrimMode)' == ''">partial</TrimMode>
6870
<SuppressTrimAnalysisWarnings Condition=" '$(SuppressTrimAnalysisWarnings)' == '' ">true</SuppressTrimAnalysisWarnings>
6971
<!-- Prefer $(RuntimeIdentifiers) plural -->
7072
<RuntimeIdentifiers Condition=" '$(RuntimeIdentifier)' == '' And '$(RuntimeIdentifiers)' == '' ">android-arm;android-arm64;android-x86;android-x64</RuntimeIdentifiers>

src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.ILLink.targets

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -28,17 +28,6 @@ This file contains the .NET 5-specific targets to customize ILLink
2828
Condition="'$(VSAndroidDesigner)' != ''"
2929
Value="$(VSAndroidDesigner)"
3030
Trim="true" />
31-
<!-- Mark all assemblies to be linked for AndroidLinkMode=Full -->
32-
<ResolvedFileToPublish
33-
Update="@(ResolvedFileToPublish)"
34-
Condition=" '$(AndroidLinkMode)' == 'Full' and '%(ResolvedFileToPublish.Extension)' == '.dll' and '%(ResolvedFileToPublish.AssetType)' != 'native' "
35-
TrimMode="link"
36-
/>
37-
<!-- TODO: remove setting the trim mode here, once the support packages are updated to NET6 and compatability packages not needed -->
38-
<ResolvedFileToPublish
39-
Condition=" '$(AndroidLinkMode)' == 'SdkOnly' and ( $([System.String]::Copy(%(Filename)).StartsWith ('Xamarin.AndroidX.')) or $([System.String]::Copy(%(Filename)).StartsWith ('Xamarin.Android.Support.')) or $([System.String]::Copy(%(Filename)).StartsWith ('Xamarin.Google.')) or $([System.String]::Copy(%(Filename)).StartsWith ('Xamarin.GooglePlayServices.')) ) ">
40-
<TrimMode>link</TrimMode>
41-
</ResolvedFileToPublish>
4231

4332
<!--
4433
Used for the <ILLink CustomData="@(_TrimmerCustomData)" /> value:

0 commit comments

Comments
 (0)