[Xamarin.Android.Build.Tasks] error for Android.Support

Context: #8478

Some hardcoded paths/properties in Xamarin.AndroidX.Migration cause
tests failures in #8478 such as:

    (_AndroidXCecilfy target) ->
    /Users/runner/.nuget/packages/xamarin.androidx.migration/1.0.8/buildTransitive/monoandroid90/Xamarin.AndroidX.Migration.targets(227,9): error : Source assembly does not exist: 'obj/Debug/android/assets/UnnamedProject.dll'.

Where `$(MonoAndroidIntermediateAssetsDir)` does not account for a new
architecture in the path:

    <ItemGroup>
      <_AndroidXFileToCecilfy Include="@(ResolvedUserAssemblies->'$(MonoAndroidIntermediateAssetsDir)%(Filename)%(Extension)')"
        Condition="('%(ResolvedUserAssemblies.TargetFrameworkIdentifier)' == 'MonoAndroid' or '%(ResolvedUserAssemblies.HasMonoAndroidReference)' == 'true') and ('%(ResolvedUserAssemblies.AndroidXSkipAndroidXMigration)' != 'true')" />
    </ItemGroup>

We don't really *support* the old Android.Support libraries or
AndroidX.Migration, but we don't have any build warnings or errors in
place for this.

Introduce a `XA1039` error in .NET 9 if any packages are found matching:

* `Xamarin.Android.Support.*`
* `Xamarin.Android.Arch.*`

The biggest impact here is going to be many of our old tests, which
use the support libraries in various forms.

Improvements & general cleanup:

* Removed all old/unused packages in `KnownPackages.cs`

* Updated `KnownPackages.cs` to latest versions, including Xamarin.Forms

* Android Wear tests are now migrated from support to AndroidX:

https://android-developers.googleblog.com/2016/04/build-beautifully-for-android-wear.html

* `CheckEmbeddedSupportLibraryResources` -> moved to AndroidX

* `BuildHasNoWarnings` was not appropriately applying `IsRelease`.

* `Android.Support.v8.RenderScript` removed in favor of inline `.so` file.

* A few tests that used support libraries to create a project large
  numbers of dependencies, moved to `XamarinFormsAndroidApplicationProject`.

* `ResolveLibraryProjectImports` -> sorted comparisions

* `XamarinFormsAndroidApplicationProject` has a workaround for Guava:

dotnet/android-libraries#535

Removed tests:

* `AndroidXMigration`, `AndroidXMigrationBug`

* `ResolveLibraryImportsWithReadonlyFiles`, seemed duplicate of other
  Android Wear tests, and used support libraries.

* `ExtraAaptManifest` as it depends on `Xamarin.Android.Fabric` and
  `Xamarin.Android.Crashlytics`. These are deprecated and depend on
  support libraries.

* `BuildProguardEnabledProjectSource` now only tests `Release` mode.
  Since updating to AndroidX, `Debug` mode was triggering multi-dex.
  Making it difficult to assert contents of `*.dex` files.

In a future PR, we will backport these changes, but downgrade the error
to a warning:

    --<AndroidError Code="XA1039"
    ++<AndroidWarning Code="XA1039"
        ResourceName="XA1039"
        FormatArguments="9"
        Condition=" '@(_AndroidUnsupportedPackages->Count())' != '0' "
    />

Author: jonathanpeppers

Documentation/guides/messages/xa1039.md

@@ -0,0 +1,47 @@
+---
+title: Xamarin.Android error XA1039
+description: XA1039 error code
+ms.date: 1/10/2024
+---
+# Xamarin.Android error XA1039
+
+## Example messages
+
+```
+error XA1039: The Android Support libraries are not longer supported in .NET 9, please migrate to AndroidX. See https://aka.ms/xamarin/androidx for more details.
+```
+
+## Issue
+
+Outdated "Android Support Library" packages are no longer supported in .NET 9:
+
+* `Xamarin.Android.Arch.*`
+* `Xamarin.Android.Support.*`
+
+The underlying Java libraries are no longer supported by Google since the final
+28.0.0 release. See the [Android Support Library Documentation][support] for
+details.
+
+Some example prefixes of the newer, supported AndroidX packages are:
+
+* `Xamarin.AndroidX.*`
+* `Xamarin.AndroidX.Arch.*`
+
+For more information about the Android Support libraries or AndroidX, see:
+
+* [Android Support Library Documentation][support]
+* [AndroidX Documentation](https://developer.android.com/jetpack/androidx)
+
+[support]: https://developer.android.com/topic/libraries/support-library/packages
+
+## Solution
+
+Remove all NuGet package references to `Xamarin.Android.Support` or
+`Xamarin.Android.Arch` in favor of the new AndroidX equivalents.
+
+This also can occur if you are using a NuGet package with a transitive
+dependency on the Android support packages. In this case, you will need to
+remove the package or contact the package author.
+
+See the [AndroidX migration documentation](https://aka.ms/xamarin/androidx) for
+details.

src/Xamarin.Android.Build.Tasks/Properties/Resources.resx

@@ -1006,4 +1006,9 @@ To use a custom JDK path for a command line build, set the 'JavaSdkDirectory' MS
 {0} - The deprecated MSBuild property name
 {1} - The numeric version of .NET</comment>
   </data>
+  <data name="XA1039" xml:space="preserve">
+    <value>The Android Support libraries are no longer supported in .NET {0}, please migrate to AndroidX. See https://aka.ms/xamarin/androidx for more details.</value>
+    <comment>The following are literal names and should not be translated: Android Support, AndroidX, .NET.
+{0} - The numeric version of .NET</comment>
+  </data>
 </root>

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidUpdateResourcesTest.cs

@@ -138,23 +138,17 @@ public void DesignTimeBuild ([Values(false, true)] bool isRelease, [Values (fals
 		}
 
 		[Test]
-		public void CheckEmbeddedSupportLibraryResources ()
+		public void CheckEmbeddedAndroidXResources ()
 		{
 			var proj = new XamarinAndroidApplicationProject () {
 				IsRelease = true,
 				PackageReferences = {
-					KnownPackages.SupportMediaCompat_27_0_2_1,
-					KnownPackages.SupportFragment_27_0_2_1,
-					KnownPackages.SupportCoreUtils_27_0_2_1,
-					KnownPackages.SupportCoreUI_27_0_2_1,
-					KnownPackages.SupportCompat_27_0_2_1,
-					KnownPackages.AndroidSupportV4_27_0_2_1,
-					KnownPackages.SupportV7AppCompat_27_0_2_1,
+					KnownPackages.AndroidXAppCompat
 				},
 			};
 			using (var b = CreateApkBuilder ()) {
 				Assert.IsTrue (b.Build (proj), "First build should have succeeded.");
-				var Rdrawable = b.Output.GetIntermediaryPath (Path.Combine ("android", "bin", "classes", "android", "support", "v7", "appcompat", "R$drawable.class"));
+				var Rdrawable = b.Output.GetIntermediaryPath (Path.Combine ("android", "bin", "classes", "androidx", "appcompat", "R$drawable.class"));
 				Assert.IsTrue (File.Exists (Rdrawable), $"{Rdrawable} should exist");
 			}
 		}
@@ -410,8 +404,7 @@ protected override void OnClick()
 	}
 }"
 			});
-			proj.PackageReferences.Add (KnownPackages.AndroidSupportV4_27_0_2_1);
-			proj.PackageReferences.Add (KnownPackages.SupportV7AppCompat_27_0_2_1);
+			proj.PackageReferences.Add (KnownPackages.AndroidXAppCompat);
 			using (var libb = CreateDllBuilder (Path.Combine (projectPath, lib.ProjectName), cleanupOnDispose: false))
 			using (var b = CreateApkBuilder (Path.Combine (projectPath, proj.ProjectName), cleanupOnDispose: false)) {
 				Assert.IsTrue (libb.Build (lib), "Library Build should have succeeded.");
@@ -830,11 +823,7 @@ public void CheckFilesAreRemoved () {
 	</style>
 </resources>",
 					}
-				},
-				PackageReferences = {
-					KnownPackages.SupportV7AppCompat_27_0_2_1,
-					KnownPackages.AndroidSupportV4_27_0_2_1,
-				},
+				}
 			};
 			using (var builder = CreateApkBuilder ()) {
 				Assert.IsTrue (builder.Build (proj), "Build should have succeeded");
@@ -1033,13 +1022,7 @@ public void BuildAppWithManagedResourceParserAndLibraries ()
 					new BuildItem.ProjectReference (@"..\Lib1\Lib1.csproj", libProj.ProjectName, libProj.ProjectGuid),
 				},
 				PackageReferences = {
-					KnownPackages.SupportMediaCompat_27_0_2_1,
-					KnownPackages.SupportFragment_27_0_2_1,
-					KnownPackages.SupportCoreUtils_27_0_2_1,
-					KnownPackages.SupportCoreUI_27_0_2_1,
-					KnownPackages.SupportCompat_27_0_2_1,
-					KnownPackages.AndroidSupportV4_27_0_2_1,
-					KnownPackages.SupportV7AppCompat_27_0_2_1,
+					KnownPackages.AndroidXAppCompat
 				},
 			};
 			appProj.SetProperty ("AndroidUseManagedDesignTimeResourceGenerator", "True");
@@ -1224,20 +1207,7 @@ public void CustomViewAddResourceId ()
 		{
 			var proj = new XamarinAndroidApplicationProject ();
 			proj.LayoutMain = proj.LayoutMain.Replace ("</LinearLayout>", "<android.support.design.widget.BottomNavigationView android:id=\"@+id/navigation\" /></LinearLayout>");
-			proj.PackageReferences.Add (KnownPackages.Android_Arch_Core_Common_26_1_0);
-			proj.PackageReferences.Add (KnownPackages.Android_Arch_Lifecycle_Common_26_1_0);
-			proj.PackageReferences.Add (KnownPackages.Android_Arch_Lifecycle_Runtime_26_1_0);
-			proj.PackageReferences.Add (KnownPackages.AndroidSupportV4_27_0_2_1);
-			proj.PackageReferences.Add (KnownPackages.SupportCompat_27_0_2_1);
-			proj.PackageReferences.Add (KnownPackages.SupportCoreUI_27_0_2_1);
-			proj.PackageReferences.Add (KnownPackages.SupportCoreUtils_27_0_2_1);
-			proj.PackageReferences.Add (KnownPackages.SupportDesign_27_0_2_1);
-			proj.PackageReferences.Add (KnownPackages.SupportFragment_27_0_2_1);
-			proj.PackageReferences.Add (KnownPackages.SupportMediaCompat_27_0_2_1);
-			proj.PackageReferences.Add (KnownPackages.SupportV7AppCompat_27_0_2_1);
-			proj.PackageReferences.Add (KnownPackages.SupportV7CardView_27_0_2_1);
-			proj.PackageReferences.Add (KnownPackages.SupportV7MediaRouter_27_0_2_1);
-			proj.PackageReferences.Add (KnownPackages.SupportV7RecyclerView_27_0_2_1);
+			proj.PackageReferences.Add (KnownPackages.AndroidXAppCompat);
 			using (var b = CreateApkBuilder (Path.Combine ("temp", TestName))) {
 				Assert.IsTrue (b.Build (proj), "first build should have succeeded");
 
@@ -1257,7 +1227,7 @@ public void CustomViewAddResourceId ()
 				var r_java = Path.Combine (Root, b.ProjectDirectory, proj.IntermediateOutputPath, "android", "src", proj.PackageNameJavaIntermediatePath, "R.java");
 				FileAssert.Exists (r_java);
 				var r_java_contents = File.ReadAllLines (r_java);
-				Assert.IsTrue (StringAssertEx.ContainsText (r_java_contents, textView1), $"android/support/compat/R.java should contain `{textView1}`!");
+				Assert.IsTrue (StringAssertEx.ContainsText (r_java_contents, textView1), $"{r_java} should contain `{textView1}`!");
 			}
 		}
 

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BindingBuildTest.cs

@@ -167,7 +167,6 @@ public void BuildAarBindigLibraryWithNuGetPackageOfJar (string classParser)
 			var proj = new XamarinAndroidBindingProject () {
 				IsRelease = true,
 			};
-			proj.PackageReferences.Add (KnownPackages.AndroidSupportV4_27_0_2_1);
 			proj.Jars.Add (new AndroidItem.LibraryProjectZip ("Jars\\android-crop-1.0.1.aar") {
 				WebContent = "https://repo1.maven.org/maven2/com/soundcloud/android/android-crop/1.0.1/android-crop-1.0.1.aar"
 			});
@@ -187,13 +186,12 @@ public void BuildAarBindigLibraryWithNuGetPackageOfJar (string classParser)
 		[Test]
 		[TestCaseSource (nameof (ClassParseOptions))]
 		[NonParallelizable]
-		public void BuildLibraryZipBindigLibraryWithAarOfJar (string classParser)
+		public void BuildLibraryZipBindingLibraryWithAarOfJar (string classParser)
 		{
 			var proj = new XamarinAndroidBindingProject () {
 				IsRelease = true,
 			};
 			proj.AndroidClassParser = classParser;
-			proj.PackageReferences.Add (KnownPackages.AndroidSupportV4_27_0_2_1);
 			proj.Jars.Add (new AndroidItem.LibraryProjectZip ("Jars\\aFileChooserBinaries.zip") {
 				WebContentFileNameFromAzure = "aFileChooserBinaries.zip"
 			});
@@ -202,41 +200,6 @@ public void BuildLibraryZipBindigLibraryWithAarOfJar (string classParser)
 					<attr path=""/api/package[@name='com.ipaulpro.afilechooser']/class[@name='FileListAdapter']/method[@name='getItem' and count(parameter)=1 and parameter[1][@type='int']]"" name=""managedReturn"">Java.Lang.Object</attr>
 					<attr path=""/api/package[@name='com.ipaulpro.afilechooser']/class[@name='FileLoader']/method[@name='loadInBackground' and count(parameter)=0]"" name=""managedName"">LoadInBackgroundImpl</attr>
 				</metadata>";
-			proj.Sources.Add (new BuildItem (BuildActions.Compile, "Fixup.cs") {
-				TextContent = () => @"using System;
-using System.Collections.Generic;
-using Android.App;
-using Android.Runtime;
-
-namespace Com.Ipaulpro.Afilechooser {
-	[Activity (Name = ""com.ipaulpro.afilechooser.FileChooserActivity"",
-	           Icon = ""@drawable/ic_chooser"",
-	           Exported = true)]
-	[IntentFilter (new string [] {""android.intent.action.GET_CONTENT""},
-	               Categories = new string [] {
-				""android.intent.category.DEFAULT"",
-				//""android.intent.category.OPENABLE""
-				},
-	               DataMimeType = ""*/*"")]
-	public partial class FileChooserActivity
-	{
-	}
-
-	public partial class FileListFragment : global::Android.Support.V4.App.ListFragment, global::Android.Support.V4.App.LoaderManager.ILoaderCallbacks {
-
-		public void OnLoadFinished (global::Android.Support.V4.Content.Loader p0, Java.Lang.Object p1)
-		{
-			OnLoadFinished (p0, (IList<Java.IO.File>) new JavaList<Java.IO.File> (p1.Handle, JniHandleOwnership.DoNotTransfer));
-		}
-	}
-	public partial class FileLoader : Android.Support.V4.Content.AsyncTaskLoader {
-		public override Java.Lang.Object LoadInBackground ()
-		{
-			return (Java.Lang.Object) LoadInBackgroundImpl ();
-		}
-	}
-}"
-			});
 			using (var b = CreateDllBuilder ()) {
 				Assert.IsTrue (b.Build (proj), "Build should have succeeded.");
 			}
@@ -467,7 +430,6 @@ public void RemoveEventHandlerResolution ()
 	<attr path=""/api/package[@name='com.actionbarsherlock.view']"" name=""managedName"">Xamarin.ActionbarSherlockBinding.Views</attr>
 </metadata>",
 			};
-			binding.PackageReferences.Add (KnownPackages.AndroidSupportV4_27_0_2_1);
 			using (var bindingBuilder = CreateDllBuilder (Path.Combine ("temp", "RemoveEventHandlerResolution", "Binding"))) {
 				Assert.IsTrue (bindingBuilder.Build (binding), "binding build should have succeeded");
 			}

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest.cs

@@ -243,17 +243,9 @@ public void CheckAssemblyCounts (bool isRelease, bool aot)
 				EmbedAssembliesIntoApk = true,
 				AotAssemblies = aot,
 			};
-			proj.PackageReferences.Add (KnownPackages.AndroidXMigration);
-			proj.PackageReferences.Add (KnownPackages.AndroidXAppCompat);
-			proj.PackageReferences.Add (KnownPackages.AndroidXAppCompatResources);
-			proj.PackageReferences.Add (KnownPackages.AndroidXBrowser);
-			proj.PackageReferences.Add (KnownPackages.AndroidXMediaRouter);
-			proj.PackageReferences.Add (KnownPackages.AndroidXLegacySupportV4);
-			proj.PackageReferences.Add (KnownPackages.AndroidXLifecycleLiveData);
-			proj.PackageReferences.Add (KnownPackages.XamarinGoogleAndroidMaterial);
 
 			var abis = new [] { "armeabi-v7a", "x86" };
-			proj.SetAndroidSupportedAbis (abis);
+			proj.SetRuntimeIdentifiers (abis);
 			proj.SetProperty (proj.ActiveConfigurationProperties, "AndroidUseAssemblyStore", "True");
 
 			using (var b = CreateApkBuilder ()) {
@@ -292,10 +284,6 @@ public void SmokeTestBuildWithSpecialCharacters ([Values (false, true)] bool for
 			proj.IsRelease = true;
 			proj.AotAssemblies = aot;
 
-			if (forms) {
-				proj.PackageReferences.Clear ();
-				proj.PackageReferences.Add (KnownPackages.XamarinForms_4_7_0_1142);
-			}
 			using (var builder = CreateApkBuilder (Path.Combine (rootPath, proj.ProjectName))){
 				Assert.IsTrue (builder.Build (proj), "Build should have succeeded.");
 			}
@@ -445,26 +433,6 @@ public void ApplicationIdPlaceholder ()
 			}
 		}
 
-		[Test]
-		[Category ("XamarinBuildDownload")]
-		public void ExtraAaptManifest ()
-		{
-			var proj = new XamarinAndroidApplicationProject ();
-			proj.MainActivity = proj.DefaultMainActivity.Replace ("base.OnCreate (bundle);", "base.OnCreate (bundle);\nCrashlytics.Crashlytics.HandleManagedExceptions();");
-			proj.PackageReferences.Add (KnownPackages.Xamarin_Android_Crashlytics);
-			proj.PackageReferences.Add (KnownPackages.Xamarin_Android_Fabric);
-			proj.PackageReferences.Add (KnownPackages.Xamarin_Build_Download);
-			using (var builder = CreateApkBuilder (Path.Combine ("temp", TestName))) {
-				builder.Target = "Restore";
-				Assert.IsTrue (builder.Build (proj), "Restore should have succeeded.");
-				builder.Target = "Build";
-				Assert.IsTrue (builder.Build (proj), "Build should have succeeded.");
-				var manifest = File.ReadAllText (Path.Combine (Root, builder.ProjectDirectory, "obj", "Debug", "android", "AndroidManifest.xml"));
-				Assert.IsTrue (manifest.Contains ($"android:authorities=\"{proj.PackageName}.crashlyticsinitprovider\""), "placeholder not replaced");
-				Assert.IsFalse (manifest.Contains ("dollar_openBracket_applicationId_closeBracket"), "`aapt/AndroidManifest.xml` not ignored");
-			}
-		}
-
 		[Test]
 		public void AarContentExtraction ()
 		{
@@ -714,7 +682,10 @@ public void BuildAfterUpgradingNuget ()
 			var proj = new XamarinAndroidApplicationProject ();
 			proj.MainActivity = proj.DefaultMainActivity.Replace ("public class MainActivity : Activity", "public class MainActivity : AndroidX.AppCompat.App.AppCompatActivity");
 
-			proj.PackageReferences.Add (KnownPackages.AndroidXAppCompat);
+			proj.PackageReferences.Add (new Package {
+				Id = "Xamarin.AndroidX.AppCompat",
+				Version = "1.6.1.5",
+			});
 
 			using (var b = CreateApkBuilder (Path.Combine ("temp", TestContext.CurrentContext.Test.Name))) {
 				//[TearDown] will still delete if test outcome successful, I need logs if assertions fail but build passes
@@ -732,8 +703,8 @@ public void BuildAfterUpgradingNuget ()
 				FileAssert.Exists (build_props, "build.props should exist after first build.");
 
 				proj.PackageReferences.Clear ();
-				//NOTE: we can get all the other dependencies transitively, yay!
-				proj.PackageReferences.Add (KnownPackages.AndroidXAppCompat_1_6_0_1);
+				//NOTE: this should be newer than specified above
+				proj.PackageReferences.Add (KnownPackages.AndroidXAppCompat);
 				b.Save (proj, doNotCleanupOnUpdate: true);
 				Assert.IsTrue (b.Build (proj), "second build should have succeeded.");
 				Assert.IsFalse (b.Output.IsTargetSkipped ("_CleanIntermediateIfNeeded"), "`_CleanIntermediateIfNeeded` should have run for the second build!");
@@ -1165,6 +1136,7 @@ public MyWorker (Context c, WorkerParameters p) : base (c, p) { }
 "
 			});
 			proj.PackageReferences.Add (KnownPackages.AndroidXWorkRuntime);
+			proj.PackageReferences.Add (KnownPackages.AndroidXLifecycleLiveData);
 			using (var b = CreateApkBuilder (Path.Combine ("temp", TestName))) {
 				Assert.IsTrue (b.Build (proj), "Build should have succeeded.");
 			}
@@ -1438,8 +1410,7 @@ public void CheckLintErrorsAndWarnings ()
 
 			var proj = new XamarinAndroidApplicationProject () {
 				PackageReferences = {
-					KnownPackages.AndroidSupportV4_27_0_2_1,
-					KnownPackages.SupportConstraintLayout_1_0_2_2,
+					KnownPackages.AndroidXConstraintLayout
 				},
 			};
 			proj.SetProperty ("AndroidLintEnabled", true.ToString ());
@@ -1623,8 +1594,7 @@ public void CheckLintResourceFileReferencesAreFixed ()
 		{
 			var proj = new XamarinAndroidApplicationProject () {
 				PackageReferences = {
-					KnownPackages.AndroidSupportV4_27_0_2_1,
-					KnownPackages.SupportConstraintLayout_1_0_2_2,
+					KnownPackages.AndroidXConstraintLayout
 				},
 			};
 			proj.SetProperty ("AndroidLintEnabled", true.ToString ());