[ci] remove $(MicroBuildSignType) variable (#10521)

This will supposedly resolve our signing issues, so I removed this
value and copied the condition in each location.

Author: jonathanpeppers

build-tools/automation/azure-pipelines.yaml

@@ -47,14 +47,9 @@ variables:
 - ${{ if ne(variables['Build.DefinitionName'], 'Xamarin.Android-Private') }}:
   - name: DotNetFeedCredential
     value: dnceng-dotnet9
-- name: MicroBuildSignType
-  ${{ if and(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.DefinitionName'], 'Xamarin.Android')) }}:
-    value: Real
-  ${{ else }}:
-    value: Test
 
 extends:
-  ${{ if eq(variables['MicroBuildSignType'], 'Real') }}:
+  ${{ if and(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.DefinitionName'], 'Xamarin.Android')) }}:
     template: azure-pipelines/MicroBuild.1ES.Official.yml@1esPipelines
   ${{ else }}:
     template: azure-pipelines/MicroBuild.1ES.Unofficial.yml@1esPipelines
@@ -257,7 +252,10 @@ extends:
           name: sign_net_mac_win
           poolName: $(VSEngMicroBuildPool)
           artifactName: $(NuGetArtifactName)
-          signType: $(MicroBuildSignType)
+          ${{ if and(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.DefinitionName'], 'Xamarin.Android')) }}:
+            signType: Real
+          ${{ else }}:
+            signType: Test
           signedArtifactName: nuget-signed
           usePipelineArtifactTasks: true
           uploadPrefix: sign-mac-win
@@ -271,7 +269,10 @@ extends:
           displayName: Sign Linux Archive
           poolName: $(VSEngMicroBuildPool)
           artifactName: $(LinuxNuGetArtifactName)
-          signType: $(MicroBuildSignType)
+          ${{ if and(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.DefinitionName'], 'Xamarin.Android')) }}:
+            signType: Real
+          ${{ else }}:
+            signType: Test
           signedArtifactName: nuget-linux-signed
           usePipelineArtifactTasks: true
           uploadPrefix: sign-linux
@@ -287,7 +288,10 @@ extends:
           artifactPatterns: |
             !*Darwin*
           propsArtifactName: $(NuGetArtifactName)
-          signType: $(MicroBuildSignType)
+          ${{ if and(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.DefinitionName'], 'Xamarin.Android')) }}:
+            signType: Real
+          ${{ else }}:
+            signType: Test
           preConvertSteps:
           - task: DownloadPipelineArtifact@2
             inputs:

build-tools/automation/yaml-templates/commercial-build.yaml

@@ -51,7 +51,7 @@ steps:
 
 - task: DotNetCoreCLI@2
   displayName: macOS signing - add runtime entitlements
-  condition: and(succeeded(), eq(variables['MicroBuildSignType'], 'Real'))
+  condition: and(succeeded(), and(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.DefinitionName'], 'Xamarin.Android')))
   inputs:
     projects: ${{ parameters.xaSourcePath }}/build-tools/installers/sign-content.proj
     arguments: >-

build-tools/automation/yaml-templates/install-microbuild-tooling.yaml

@@ -1,5 +1,4 @@
 parameters:
-  signType: $(MicroBuildSignType)
   condition: succeeded()
 
 steps:
@@ -23,7 +22,10 @@ steps:
   displayName: install signing plugin
   condition: ${{ parameters.condition }}
   inputs:
-    signType: ${{ parameters.signType }}
+    ${{ if and(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.DefinitionName'], 'Xamarin.Android')) }}:
+      signType: Real
+    ${{ else }}:
+      signType: Test
     azureSubscription: MicroBuild Signing Task (DevDiv)
   env:
     SYSTEM_ACCESSTOKEN: $(System.AccessToken)