Skip to content

Commit a0f0711

Browse files
committed
Fix unit test
1 parent d9930e6 commit a0f0711

File tree

2 files changed

+6
-20
lines changed

2 files changed

+6
-20
lines changed

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/BaseTest.cs

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -553,24 +553,6 @@ protected string GetPathToAapt ()
553553
return GetPathToLatestBuildTools (exe);
554554
}
555555

556-
protected string GetResourceDesignerPath (DotNetCLI builder, XASdkProject project, bool designtime = false)
557-
{
558-
string path;
559-
if (Builder.UseDotNet) {
560-
path = Path.Combine (Root, builder.ProjectDirectory, project.IntermediateOutputPath);
561-
if (string.Compare (project.GetProperty ("AndroidUseDesignerAssembly"), "True", ignoreCase: true) == 0) {
562-
return Path.Combine (path, "_Microsoft.Android.Resource.Designer.dll");
563-
}
564-
if (designtime)
565-
path = Path.Combine (Root, builder.ProjectDirectory, project.IntermediateOutputPath);
566-
} else {
567-
path = Path.Combine (Root, builder.ProjectDirectory, "Resources");
568-
if (designtime)
569-
path = Path.Combine (Root, builder.ProjectDirectory, project.IntermediateOutputPath);
570-
}
571-
return Path.Combine (path, "Resource.designer" + project.Language.DefaultDesignerExtension);
572-
}
573-
574556
protected string GetResourceDesignerPath (ProjectBuilder builder, XamarinAndroidProject project, bool designtime = false)
575557
{
576558
string path;

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/XASdkTests.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -522,12 +522,16 @@ public void GenerateResourceDesigner_false([Values (false, true)] bool useDesign
522522
var dotnet = CreateDotNetBuilder (proj);
523523
Assert.IsTrue (dotnet.Build(target: "CoreCompile", parameters: new string[] { "BuildingInsideVisualStudio=true" }), "Designtime build should succeed.");
524524
var intermediate = Path.Combine (FullProjectDirectory, proj.IntermediateOutputPath);
525-
var resource_designer_cs = GetResourceDesignerPath (dotnet, proj, designtime: true);
525+
var resource_designer_cs = Path.Combine (intermediate, "designtime", "Resource.designer.cs");
526+
if (useDesignerAssembly)
527+
resource_designer_cs = Path.Combine (intermediate, "__Microsoft.Android.Resource.Designer.cs");
526528
FileAssert.DoesNotExist (resource_designer_cs);
527529

528530
Assert.IsTrue (dotnet.Build (), "build should succeed");
529531

530-
resource_designer_cs = GetResourceDesignerPath (dotnet, proj);
532+
resource_designer_cs = Path.Combine (intermediate, "Resource.designer.cs");
533+
if (useDesignerAssembly)
534+
resource_designer_cs = Path.Combine (intermediate, "__Microsoft.Android.Resource.Designer.cs");
531535
FileAssert.DoesNotExist (resource_designer_cs);
532536

533537
var assemblyPath = Path.Combine (FullProjectDirectory, proj.OutputPath, $"{proj.ProjectName}.dll");

0 commit comments

Comments
 (0)