Fix an off-by-one issue

grendello · grendello · commit 74681127fbfd · 2024-02-08T21:44:17.000+01:00
diff --git a/src/monodroid/jni/embedded-assemblies.hh b/src/monodroid/jni/embedded-assemblies.hh
@@ -334,7 +334,9 @@ namespace xamarin::android::internal {
 		template<bool IsSatelliteAssembly>
 		static constexpr size_t get_mangled_data_size ()
 		{
-			return SharedConstants::MANGLED_ASSEMBLY_REGULAR_ASSEMBLY_MARKER.size () + get_mangled_prefix_length<IsSatelliteAssembly> ();
+			return SharedConstants::MANGLED_ASSEMBLY_REGULAR_ASSEMBLY_MARKER.size () +
+				   get_mangled_prefix_length<IsSatelliteAssembly> () +
+				   1; // For the extra `-` char in the culture portion of satellite assembly's name;
 		}
 
 		template<bool IsSatelliteAssembly>

Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,9 @@ namespace xamarin::android::internal {`
`334`	`334`	`template<bool IsSatelliteAssembly>`
`335`	`335`	`static constexpr size_t get_mangled_data_size ()`
`336`	`336`	`{`
`337`		`- return SharedConstants::MANGLED_ASSEMBLY_REGULAR_ASSEMBLY_MARKER.size () + get_mangled_prefix_length<IsSatelliteAssembly> ();`
	`337`	`+ return SharedConstants::MANGLED_ASSEMBLY_REGULAR_ASSEMBLY_MARKER.size () +`
	`338`	`+ get_mangled_prefix_length<IsSatelliteAssembly> () +`
	`339`	+ 1; // For the extra `-` char in the culture portion of satellite assembly's name;
`338`	`340`	`}`
`339`	`341`
`340`	`342`	`template<bool IsSatelliteAssembly>`