…and try again!

Author: jonpryor

build-tools/Xamarin.Android.Tools.BootstrapTasks/Xamarin.Android.Tools.BootstrapTasks/CheckApiCompatibility.cs

@@ -67,6 +67,9 @@ public sealed class CheckApiCompatibility : Task
 		// In case API diffs vary between e.g. Classic MonoAndroid & .NET 6+
 		public string TargetFramework { get; set; }
 
+		// What's missing from acceptableIssuesFile?
+		public string LinesToAdd { get; set; }
+
 		// This Build tasks validates that changes are not breaking Api
 		public override bool Execute ()
 		{
@@ -260,6 +263,7 @@ void dataReceived (object sender, DataReceivedEventArgs args)
 					}
 
 					LogError ($"CheckApiCompatibility found nonacceptable Api breakages for ApiLevel: {ApiLevel}.{Environment.NewLine}{string.Join (Environment.NewLine, lines)}");
+					ReportMissingLines (acceptableIssuesFile.FullName, lines);
 
 					var missingItems = CodeGenDiff.GenerateMissingItems (CodeGenPath, contractAssembly.FullName, implementationAssembly.FullName);
 					if (missingItems.Any ()) {
@@ -285,6 +289,21 @@ void dataReceived (object sender, DataReceivedEventArgs args)
 			}
 		}
 
+		void ReportMissingLines (string acceptableIssuesFile, List<string> lines)
+		{
+			if (string.IsNullOrWhiteSpace (LinesToAdd)) {
+				return;
+			}
+			var known = new HashSet<string> (File.ReadAllLines (acceptableIssuesFile), StringComparer.Ordinal);
+			using var writer = File.CreateText (LinesToAdd);
+			foreach (var line in lines) {
+				if (known.Contains (line)) {
+					continue;
+				}
+				writer.WriteLine (line);
+			}
+		}
+
 		void LogError (string errorMessage)
 		{
 			if (!string.IsNullOrWhiteSpace (compatApiCommand)) {

external/Java.Interop

@@ -225,6 +225,7 @@
         TargetImplementationPath="$(OutputPath)"
         ApiCompatibilityPath="$(ApiCompatibilityDir)"
         TargetFramework="$(TargetFramework)"
+        LinesToAdd="$(MSBuildThisFileDirectory)ApiCompatLinesToAdd.txt"
     />
     <Touch
         Files="$(IntermediateOutputPath)CheckApiCompatibility.stamp"