Skip to content

Commit 192497b

Browse files
[tests] ignore .NET 5 tests (#4603)
Some of our tests are failing on CI with: dotnet\sdk\5.0.100-preview.2.20176.6\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(329,5): error NETSDK1082: There was no runtime pack for Microsoft.NETCore.App available for the specified RuntimeIdentifier 'android.21-x86'. These tests work fine if you install a master build of .NET 5, but not with the current .NET 5 Preview 3 release. We will need a build of .NET 5 Preview 4 for these tests to work. Let's ignore them for now, so our CI will be more greenish.
1 parent 20d5b6b commit 192497b

File tree

1 file changed

+5
-1
lines changed
  • src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests

1 file changed

+5
-1
lines changed

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/XASdkTests.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,11 @@ public void DotNetBuild ([Values (false, true)] bool isRelease)
5757
[TestCaseSource (nameof (DotNetPublishSource))]
5858
public void DotNetPublish (string runtimeIdentifier, bool isRelease)
5959
{
60+
var abi = MonoAndroidHelper.RuntimeIdentifierToAbi (runtimeIdentifier);
61+
//TODO: re-enable these when we have a public .NET 5 Preview 4 build
62+
if (abi == "x86" || abi == "x86_64")
63+
Assert.Ignore ($"Ignoring RID {runtimeIdentifier} until a new .NET 5 build is available.");
64+
6065
var proj = new XASdkProject (SdkVersion) {
6166
IsRelease = isRelease
6267
};
@@ -68,7 +73,6 @@ public void DotNetPublish (string runtimeIdentifier, bool isRelease)
6873
var apk = Path.Combine (Root, dotnet.ProjectDirectory, proj.OutputPath,
6974
runtimeIdentifier, "UnnamedProject.UnnamedProject.apk");
7075
FileAssert.Exists (apk);
71-
var abi = MonoAndroidHelper.RuntimeIdentifierToAbi (runtimeIdentifier);
7276
using (var zip = ZipHelper.OpenZip (apk)) {
7377
Assert.IsTrue (zip.ContainsEntry ($"lib/{abi}/libmonodroid.so"), "libmonodroid.so should exist.");
7478
}

0 commit comments

Comments
 (0)