Switch more over to System.Text.Json

Author: dellis1972

src/Xamarin.Android.Build.Tasks/Tasks/BuildAppBundle.cs

@@ -1,7 +1,7 @@
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;
-using Newtonsoft.Json;
-using Newtonsoft.Json.Linq;
+using System.Text.Json;
+using System.Text.Json.Nodes;
 using System;
 using System.Collections.Generic;
 using System.IO;
@@ -88,26 +88,24 @@ public override bool RunTask ()
 					}
 				}
 
-				var json = JObject.FromObject (new { });
+				JsonNode json = JsonNode.Parse("{}");
 				if (!string.IsNullOrEmpty (CustomBuildConfigFile) && File.Exists (CustomBuildConfigFile)) {
-					using (StreamReader file = File.OpenText (CustomBuildConfigFile))
-					using (JsonTextReader reader = new JsonTextReader (file)) {
-						json = (JObject)JToken.ReadFrom(reader);
-					}
+					using Stream fs = File.OpenRead (CustomBuildConfigFile);
+					json = JsonNode.Parse (fs);
 				}
-				var jsonAddition = JObject.FromObject (new {
+				var jsonAddition = new {
 					compression = new {
 						uncompressedGlob = uncompressed,
 					}
-				});
-
-				var mergeSettings = new JsonMergeSettings () {
-					MergeArrayHandling = MergeArrayHandling.Union,
-					MergeNullValueHandling = MergeNullValueHandling.Ignore
 				};
-				json.Merge (jsonAddition, mergeSettings);
-				Log.LogDebugMessage ("BundleConfig.json: {0}", json);
-				File.WriteAllText (temp, json.ToString ());
+
+				var jsonAdditionDoc = JsonSerializer.SerializeToNode(jsonAddition);
+
+				var mergedJson = json.Merge(jsonAdditionDoc);
+				var output = mergedJson.ToJsonString(new JsonSerializerOptions { WriteIndented = true });
+
+				Log.LogDebugMessage ("BundleConfig.json: {0}", output);
+				File.WriteAllText (temp, output);
 
 				//NOTE: bundletool will not overwrite
 				if (File.Exists (Output))

src/Xamarin.Android.Build.Tasks/Tasks/JavaDependencyVerification.cs

@@ -11,7 +11,8 @@
 using Microsoft.Android.Build.Tasks;
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;
-using Newtonsoft.Json;
+using System.Text.Json;
+using System.Text.Json.Serialization;
 using NuGet.ProjectModel;
 
 namespace Xamarin.Android.Tasks;
@@ -318,7 +319,7 @@ public MicrosoftNuGetPackageFinder (string? file, TaskLoggingHelper log)
 
 		try {
 			var json = File.ReadAllText (file);
-			package_list = JsonConvert.DeserializeObject<PackageListFile> (json);
+			package_list = JsonSerializer.Deserialize<PackageListFile> (json);
 		} catch (Exception ex) {
 			log.LogMessage ("There was an error reading 'microsoft-packages.json', Android NuGet suggestions will not be provided: {0}", ex);
 		}
@@ -331,16 +332,16 @@ public MicrosoftNuGetPackageFinder (string? file, TaskLoggingHelper log)
 
 	public class PackageListFile
 	{
-		[JsonProperty ("packages")]
+		[JsonPropertyName ("packages")]
 		public List<Package>? Packages { get; set; }
 	}
 
 	public class Package
 	{
-		[JsonProperty ("javaId")]
+		[JsonPropertyName ("javaId")]
 		public string? JavaId { get; set; }
 
-		[JsonProperty ("nugetId")]
+		[JsonPropertyName ("nugetId")]
 		public string? NuGetId { get; set; }
 	}
 }

src/Xamarin.Android.Build.Tasks/Utilities/JsonExtensions.cs

@@ -0,0 +1,73 @@
+using System;
+using System.Collections.Generic;
+using System.Text.Json;
+using System.Text.Json.Nodes;
+
+public static class JsonExtensions
+{
+    /// <summary>
+    /// Merges the specified Json Node into the base JsonNode for which this method is called.
+    /// It is null safe and can be easily used with null-check & null coalesce operators for fluent calls.
+    /// NOTE: JsonNodes are context aware and track their parent relationships therefore to merge the values both JsonNode objects
+    ///         specified are mutated. The Base is mutated with new data while the source is mutated to remove reverences to all
+    ///         fields so that they can be added to the base.
+    ///
+    /// Source taken directly from the open-source Gist here:
+    /// https://gist.github.com/cajuncoding/bf78bdcf790782090d231590cbc2438f
+    ///
+    /// </summary>
+    /// <param name="jsonBase"></param>
+    /// <param name="jsonMerge"></param>
+    /// <returns></returns>
+    /// <exception cref="ArgumentException"></exception>
+    public static JsonNode Merge(this JsonNode jsonBase, JsonNode jsonMerge)
+    {
+        if (jsonBase == null || jsonMerge == null)
+            return jsonBase;
+
+        switch (jsonBase)
+        {
+            case JsonObject jsonBaseObj when jsonMerge is JsonObject jsonMergeObj:
+                {
+                    var mergeNodesArray = new KeyValuePair<string, JsonNode?>[jsonMergeObj.Count];
+                    int index = 0;
+                    foreach (var prop in jsonMergeObj)
+                    {
+                        mergeNodesArray[index++] = prop;
+                    }
+                    jsonMergeObj.Clear();
+
+                    foreach (var prop in mergeNodesArray)
+                    {
+                        jsonBaseObj[prop.Key] = jsonBaseObj[prop.Key] switch
+                        {
+                            JsonObject jsonBaseChildObj when prop.Value is JsonObject jsonMergeChildObj => jsonBaseChildObj.Merge(jsonMergeChildObj),
+                            JsonArray jsonBaseChildArray when prop.Value is JsonArray jsonMergeChildArray => jsonBaseChildArray.Merge(jsonMergeChildArray),
+                            _ => prop.Value
+                        };
+                    }
+                    break;
+                }
+            case JsonArray jsonBaseArray when jsonMerge is JsonArray jsonMergeArray:
+                {
+                    var mergeNodesArray = new JsonNode?[jsonMergeArray.Count];
+                    int index = 0;
+                    foreach (var mergeNode in jsonMergeArray)
+                    {
+                        mergeNodesArray[index++] = mergeNode;
+                    }
+                    jsonMergeArray.Clear();
+                    foreach (var mergeNode in mergeNodesArray)
+                    {
+                        jsonBaseArray.Add(mergeNode);
+                    }
+                    break;
+                }
+            default:
+                throw new ArgumentException($"The JsonNode type [{jsonBase.GetType().Name}] is incompatible for merging with the target/base " +
+                                            $"type [{jsonMerge.GetType().Name}]; merge requires the types to be the same.");
+        }
+
+        return jsonBase;
+    }
+}