Skip to content

Commit 34877b6

Browse files
committed
All ARM32 builds target ARMv7-a
1 parent 40e3a57 commit 34877b6

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

src/gas/llvm_mc_runner.hh

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,15 @@ namespace xamarin::android::gas
162162
return iter->second;
163163
}
164164

165+
void append_attribute (std::string const& new_attr)
166+
{
167+
set_option (LlvmMcArgument::Mattr, new_attr);
168+
}
169+
165170
void append_attributes (std::vector<std::string> const& new_attrs)
166171
{
167172
for (std::string const& attr : new_attrs) {
168-
set_option (LlvmMcArgument::Mattr, attr);
173+
append_attribute (attr);
169174
}
170175
}
171176

@@ -193,7 +198,10 @@ namespace xamarin::android::gas
193198
public:
194199
LlvmMcRunnerARM32 ()
195200
: LlvmMcRunner (LlvmMcArchitecture::ARM32)
196-
{}
201+
{
202+
// We always target ARMv7-a
203+
append_attribute ("+armv7-a");
204+
}
197205

198206
virtual ~LlvmMcRunnerARM32 ()
199207
{}

src/gas/llvm_mc_runner_arm32.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ std::unordered_map<std::string, std::vector<std::string>> LlvmMcRunnerARM32::fpu
4646
{ "vfp10-r0", {}}, // no llvm-mc equivalent?
4747
{ "vfp9", {}}, // no llvm-mc equivalent?
4848
{ "vfpv2", {"+vfp2"}},
49-
{ "vfpv3", {"+vfp3", "+thumb2"}},
50-
{ "vfp3", {"+vfp3", "+thumb2"}}, // undocumented GAS option, alias for vfpv3 above
49+
{ "vfpv3", {"+vfp3"}},
50+
{ "vfp3", {"+vfp3"}}, // undocumented GAS option, alias for vfpv3 above
5151
{ "vfpv3-d16", {"+vfp3d16"}},
5252
{ "vfpv3-d16-fp16", {"vfp3d16,+fp16"}},
5353
{ "vfpv3-fp16", {"+vfp3,+fp16"}},

0 commit comments

Comments
 (0)