Use a temp file

Author: dellis1972

LibZipSharp.UnitTest/ZipTests.cs

@@ -272,9 +272,6 @@ public void InMemoryZipFile ()
 					zip.AddFile (Path.Combine (fileRoot, "object_spawn.json"), "object_spawn.json");
 				}
 
-				stream.Position = 0;
-				File.WriteAllBytes ("InMemory1.zip", stream.ToArray ());
-
 				stream.Position = 0;
 				using (var zip = ZipArchive.Open (stream)) {
 					Assert.AreEqual (3, zip.EntryCount);
@@ -290,9 +287,6 @@ public void InMemoryZipFile ()
 					zip.AddEntry ("info.json", File.ReadAllText (filePath), Encoding.UTF8, CompressionMethod.Deflate);
 				}
 
-				stream.Position = 0;
-				File.WriteAllBytes ("InMemory2.zip", stream.ToArray ());
-
 				stream.Position = 0;
 				using (var zip = ZipArchive.Open (stream)) {
 					Assert.AreEqual (3, zip.EntryCount);
@@ -308,9 +302,6 @@ public void InMemoryZipFile ()
 
 					}
 				}
-
-				stream.Position = 0;
-				File.WriteAllBytes ("InMemory3.zip", stream.ToArray ());
 			}
 		}
 

LibZipSharp/Xamarin.Tools.Zip/ZipArchive.cs

@@ -42,8 +42,9 @@ public abstract partial class ZipArchive : IDisposable, IEnumerable <ZipEntry>
 	{
 		internal class CallbackContext : IDisposable {
 			bool disposed;
-			public Stream Source = null;
-			public Stream Destination = null;
+			public Stream Source { get; set; } = null;
+			public Stream Destination {get; set;} = null;
+			public string DestinationFileName {get; set; } = null;
 
 			protected virtual void Dispose (bool disposing)
 			{
@@ -57,6 +58,10 @@ protected virtual void Dispose (bool disposing)
 							Destination.Dispose ();
 							Destination = null;
 						}
+						if (!string.IsNullOrEmpty (DestinationFileName)&& File.Exists (DestinationFileName)) {
+							File.Delete (DestinationFileName);
+							DestinationFileName = null;
+						}
 					}
 					disposed = true;
 				}
@@ -855,7 +860,8 @@ internal static unsafe Int64 stream_callback (IntPtr state, IntPtr data, UInt64
 					context.Destination = null;
 					break;
 				case SourceCommand.RollbackWrite:
-					// err do something?
+					destination.Dispose ();
+					context.Destination = null;
 					break;
 
 				case SourceCommand.Read:
@@ -869,7 +875,14 @@ internal static unsafe Int64 stream_callback (IntPtr state, IntPtr data, UInt64
 						ArrayPool<byte>.Shared.Return (buffer);
 					}
 				case SourceCommand.BeginWrite:
-					context.Destination = new MemoryStream ();
+					try {
+						string tempFile = Path.GetTempFileName ();
+						context.Destination = File.Open (tempFile, FileMode.OpenOrCreate, FileAccess.ReadWrite);
+						context.DestinationFileName = tempFile;
+					} catch (IOException) {
+						// ok use a memory stream as a backup
+						context.Destination = new MemoryStream ();
+					}
 					destination = context.Destination;
 					destination.Position = 0;
 					break;
@@ -886,12 +899,6 @@ internal static unsafe Int64 stream_callback (IntPtr state, IntPtr data, UInt64
 						handle.Free ();
 					break;
 
-				case SourceCommand.Error:
-					break;
-
-				case SourceCommand.Remove:
-					break;
-
 				case SourceCommand.Supports:
 					var supports = (Int64)Native.zip_source_make_command_bitmap (
 						SourceCommand.Open,