Skip to content

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Jan 3, 2024

Context: #829
Context: dotnet/android#8605

In #829, I got a little ahead of myself with my quote:

As expected for an open source, cross-platform project, there does not appear to be any issues found that need to be mitigated.

It turns out there were some issues being marked, but the scan doesn't fail the build so they were missed.

Fix 2 things:

  • Use @pjcollins's more complete solution to store the ApiScan logs and fail the build if any issues were found.
  • Fix the following failures by removing some framework assemblies that ship with dotnet and we are not redistributing with our packages.
system.objectmodel.dll(,): Error documentationnotfound: Documentation Not Found: presentationframework!System.Windows.Input.CommandValueSerializer is either an undocumented HVP API or the documentation is not discoverable.
mscorlib.dll(,): Error documentationnotfound: Documentation Not Found: system.runtime.compilerservices.visualc!System.Runtime.CompilerServices.SuppressMergeCheckAttribute is either an undocumented HVP API or the documentation is not discoverable.
netstandard.dll(,): Error documentationnotfound: Documentation Not Found: system.componentmodel.typeconverter!System.ComponentModel.Design.DesignerOptionService.DesignerOptionConverter is either an undocumented HVP API or the documentation is not discoverable.

CI Build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8875161

@jpobst jpobst force-pushed the apiscan-log branch 3 times, most recently from 0a9e671 to cb2eb58 Compare January 4, 2024 17:55
@jpobst jpobst marked this pull request as ready for review January 5, 2024 00:46
@jpobst jpobst requested review from moljac and pjcollins January 5, 2024 00:47
@jpobst jpobst merged commit 52b70c3 into main Jan 5, 2024
@jpobst jpobst deleted the apiscan-log branch January 5, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants