- 
                Notifications
    You must be signed in to change notification settings 
- Fork 63
Add androidx.health.connect:connect-client binding (1.1.0-rc02) #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
…lementation Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
| @copilot fix the one error:  | 
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
| 
 Fixed in commit a97dd14. Added  | 
| @moljac @sheiksyedm do you have any suggestions to fix this manually? What it did in a97dd14, doesn't seem right. | 
| 
 I need to check. 
 No. This is completely wrong. It will take quite a long time for Copilot to have good RAG or be fine tuned for Android bindings and even worse for binderator based bindings process. There is simply not enough samples for training. I started health bindings while ago, but it was not priority, because it was in preview and for my side projects I needed it for - there was simply no free time for those. IIRC there was one tougher aar that had tons of errors, but I cannot recall. I must check my repo and find backups from 9-12 months ago... https://github.com/HolisticWare-Bindings/HolisticWare.AndroidX.Jetpack.Health/blob/main/config.json | 
| Look for other ideas, such as the comment: #1306 (comment) There is a sample repo at: https://github.com/HolisticWare-Bindings/HolisticWare.AndroidX.Jetpack.Health | 
…pendency Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
| 
 Reverted a97dd14 in commit 95c85f3. Instead of using merge.targets (which modifies the build), I added a Xamarin.AndroidX.Health.Connect.Client.targets file that gets packaged with the NuGet and removes the proto PackageReference at consumption time. This is the correct MSBuild pattern for modifying package dependencies. | 
| My hands were tight, because of our rules - no previews, so in most cases we used to bind and publish from branches. I could add those (and few more I think it would make sense to add) to  | 
HealthConnect Records Implementation Fix
Fix for NU1101 Error
The build was failing because
connect-client-protowas referenced as a NuGet PackageReference but doesn't exist on NuGet.org yet.Solution: Added
Xamarin.AndroidX.Health.Connect.Client.targetsfile that:<PackageReference Remove="..."/>This allows the binding to work without requiring a separate proto NuGet package, as the proto classes are internal implementation details.
Result
Record classes now properly implement
IRecordthrough the Java inheritance chain:Code that previously failed now compiles:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.