Merge pull request #1409 from NiklasGustafsson/unit

Further adjustments based on API compat

Author: NiklasGustafsson

azure-pipelines.yml

@@ -448,7 +448,7 @@ jobs:
   - script: dotnet restore pkg/pack.proj /p:Configuration=Release
     displayName: Restore package projects
 
-  - script: dotnet pack -c $(BuildConfig) --no-build -v:n /p:SkipNative=true /p:SkipTests=true /p:IncludeTorchSharpPackage=false /p:IncludeLibTorchCpuPackages=false /p:IncludeLibTorchCudaPackages=true pkg/pack.proj
+  - script: dotnet pack -c $(BuildConfig) --no-build -v:n /p:SkipNative=true /p:SkipTests=true /p:ApiCompatGenerateSuppressionFile=true /p:IncludeTorchSharpPackage=false /p:IncludeLibTorchCpuPackages=false /p:IncludeLibTorchCudaPackages=true pkg/pack.proj
     displayName: Create Packages
 
   # We are 10GB space-constrained on the Azure Pipelines CI system so clean up what we can

src/TorchSharp/NN/Activation/Sigmoid.cs

@@ -45,7 +45,7 @@ public static Sigmoid Sigmoid()
             /// </summary>
             /// <param name="inplace">Do the operation in-place. Default: False</param>
             /// <returns></returns>
-            public static Sigmoid Sigmoid(bool inplace = false)
+            public static Sigmoid Sigmoid(bool inplace)
             {
                 return new Sigmoid(inplace);
             }

src/TorchSharp/NN/Activation/Softsign.cs

@@ -32,11 +32,19 @@ public static partial class torch
     {
         public static partial class nn
         {
+            /// <summary>
+            /// Softsign
+            /// </summary>
+            public static Softsign Softsign()
+            {
+                return new Softsign(false);
+            }
+
             /// <summary>
             /// Softsign
             /// </summary>
             /// <param name="inplace">Do the operation in-place. Default: False</param>
-            public static Softsign Softsign(bool inplace = false)
+            public static Softsign Softsign(bool inplace)
             {
                 return new Softsign(inplace);
             }

src/TorchSharp/NN/Activation/Tanhshrink.cs

@@ -67,7 +67,7 @@ public static Tensor tanhshrink(Tensor x, bool inplace = false)
                 /// </summary>
                 /// <param name="x">The input tensor</param>
                 [Obsolete("Not using the PyTorch naming convention.",false)]
-                public static Tensor tanhshrink(Tensor x) => tanhshrink(x, false);
+                public static Tensor Tanhshrink(Tensor x) => tanhshrink(x, false);
             }
         }
     }

src/TorchSharp/NN/Activation/Threshold.cs

@@ -70,8 +70,9 @@ public static Tensor threshold(Tensor x, double threshold, double value, bool in
                 /// <param name="x">The input tensor</param>
                 /// <param name="threshold">The value to threshold at</param>
                 /// <param name="value">The value to replace with</param>
+                /// <param name="inplace">Do the operation in-place</param>
                 [Obsolete("Not using the PyTorch naming convention.",false)]
-                public static Tensor Threshold(Tensor x, double threshold, double value) => nn.functional.threshold(x, threshold, value, false);
+                public static Tensor Threshold(Tensor x, double threshold, double value, bool inplace = false) => nn.functional.threshold(x, threshold, value, inplace);
             }
         }
     }

src/TorchSharp/NN/Module.cs

@@ -818,6 +818,11 @@ public virtual void register_module(string name, Module submodule)
                     }
                 }
 
+                protected void ConditionallyRegisterParameter(string name, Tensor value)
+                {
+                    ConditionallyRegisterParameter(name, value as Parameter);
+                }
+
                 protected void ConditionallyRegisterParameter(string name, Parameter? value)
                 {
                     if (value is null) {

src/TorchSharp/Tensor/Tensor.cs

@@ -2812,19 +2812,19 @@ public Tensor celu_(Scalar alpha)
                 return this;
             }
 
-            public Tensor elu(double alpha = 1) =>  elu1(alpha, 1.0, 1.0);
+            public Tensor elu(double alpha = 1) =>  elu(alpha, 1.0, 1.0);
 
-            public Tensor elu_(double alpha = 1) =>  elu2(alpha, 1.0, 1.0);
+            public Tensor elu_(double alpha = 1) =>  elu(alpha, 1.0, 1.0);
 
-            private Tensor elu1(Scalar alpha, Scalar scale, Scalar input_scale)
+            public Tensor elu(Scalar alpha, Scalar scale, Scalar input_scale)
             {
                 var res = NativeMethods.THSTensor_elu(Handle, alpha.Handle, scale.Handle, input_scale.Handle);
                 if (res == IntPtr.Zero)
                     CheckForErrors();
                 return new Tensor(res);
             }
 
-            private Tensor elu2(Scalar alpha, Scalar scale, Scalar input_scale)
+            public Tensor elu_(Scalar alpha, Scalar scale, Scalar input_scale)
             {
                 NativeMethods.THSTensor_elu_(Handle, alpha.Handle, scale.Handle, input_scale.Handle);
                 CheckForErrors();