Improved decimal scale conversion #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavoudEshtehari
requested review from
cheenamalhotra,
karinazhou,
David-Engel and
JRahnama
JRahnama
reviewed
Mar 17, 2020
src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
JRahnama
reviewed
Mar 17, 2020
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
JRahnama
reviewed
Mar 17, 2020
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/TvpTest.cs
Outdated
Show resolved
Hide resolved
DavoudEshtehari
force-pushed
the
ScaledDecimalParameterImprovement
branch
from
d3dc447 to
6cf9b90
Compare
David-Engel
reviewed
Mar 18, 2020
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml
Outdated
Show resolved
Hide resolved
For SqlParameter and SqlBulckCopy
DavoudEshtehari
force-pushed
the
ScaledDecimalParameterImprovement
branch
from
6cf9b90 to
d7d8e22
Compare
Co-Authored-By: David Engel <dengel1012@gmail.com>
Co-Authored-By: David Engel <dengel1012@gmail.com>
cheenamalhotra
added
the
🆕 Public API
DavoudEshtehari
force-pushed
the
ScaledDecimalParameterImprovement
branch
3 times, most recently
from
8442fe3 to
878bebc
Compare
DavoudEshtehari
force-pushed
the
ScaledDecimalParameterImprovement
branch
from
878bebc to
de3dced
Compare
David-Engel
reviewed
Mar 26, 2020
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
Show resolved
Hide resolved
DavoudEshtehari
force-pushed
the
ScaledDecimalParameterImprovement
branch
from
09095db to
549c62d
Compare
Changed Microsoft.Data.SqlClient.TruncateScaledDecimal to Switch.Microsoft.Data.SqlClient.TruncateScaledDecimal for unification. Merge branch 'master' of https://github.com/dotnet/SqlClient into ScaledDecimalParameterImprovement # Conflicts: # BUILDGUIDE.md
DavoudEshtehari
force-pushed
the
ScaledDecimalParameterImprovement
branch
from
5f0d30c to
069aa9f
Compare
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/TvpTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/ParametersTest.cs
Show resolved
Hide resolved
cheenamalhotra
added
the
🔨 Breaking Change
cheenamalhotra
approved these changes
Apr 7, 2020
David-Engel
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the decimal data scale implicitly was truncated. And now, it is rounding as same as Microsoft SQL Server.
For backwards compatibility, you can add the 'Switch.Microsoft.Data.SqlClient.TruncateScaledDecimal' switch inside the AppContext with the value 'true'.