-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed wrong application domain selected #410
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidEshtehari
force-pushed
the
Issue#401
branch
5 times, most recently
from
February 7, 2020 02:50
ddd45a3
to
67dd18b
Compare
JRahnama
reviewed
Feb 7, 2020
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlDependencyTest/SqlDependencyTest.cs
Show resolved
Hide resolved
DavidEshtehari
force-pushed
the
Issue#401
branch
from
February 7, 2020 16:53
67dd18b
to
93a8b8f
Compare
DavidEshtehari
force-pushed
the
Issue#401
branch
from
February 7, 2020 17:42
93a8b8f
to
c9ff8df
Compare
David-Engel
reviewed
Feb 7, 2020
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlDependencyTest/SqlDependencyTest.cs
Outdated
Show resolved
Hide resolved
DavidEshtehari
force-pushed
the
Issue#401
branch
from
February 10, 2020 16:43
c9ff8df
to
a696100
Compare
cheenamalhotra
approved these changes
Mar 10, 2020
DavoudEshtehari
changed the title
Fix issue (#401)
Fixed wrong application domain selected
Mar 10, 2020
Uploading package for testing: |
David-Engel
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of starting the listener to receive the notifications from SQL Server instance, if there is not a process dispatcher, we should obtain it first. In this process, we need the main application domain in the active process that has access to
Microsoft.Data.SqlClient
assembly to create an instance ofSqlDependencyProcessDispatcher
type.The issue occurred when we tried to create the instance on the wrong domain.