Skip to content

Conversation

@apoorvdeshmukh
Copy link
Contributor

Description

This commit enable the vector tests against Azure SQLDb Instance add adds testcase to validate ref assembly for vector APIs.

Testing

Vector tests for backward compatibility scenarios and native testcases.

Guidelines

Please review the contribution guidelines before submitting a pull request:

Copilot AI review requested due to automatic review settings August 12, 2025 13:57
@apoorvdeshmukh apoorvdeshmukh requested a review from a team as a code owner August 12, 2025 13:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables vector tests against Azure SQLDb instances and adds validation for vector API reference assemblies. The changes focus on making vector functionality testable in Azure environments and ensuring API completeness.

  • Enables vector support for Azure SQL Database instances by updating the IsVectorSupported flag
  • Adds DisableDiscoveryEnumeration = true to vector test methods to optimize test discovery
  • Includes a new test case to validate vector API functionality and reference assembly completeness

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
NativeVectorFloat32Tests.cs Adds DisableDiscoveryEnumeration to test attributes and includes new VectorAPITest method for API validation
DataTestUtility.cs Enables vector support for Azure SQL Database by changing IsVectorSupported logic
SqlVector.cs Fixes XML documentation comment reference path

Copy link
Contributor

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment needed. I'm not sure if Copilot is correct with its suggestion.

@cheenamalhotra
Copy link
Member

@apoorvdeshmukh please port this PR to release/6.1 as well on merge.

paulmedynski
paulmedynski previously approved these changes Aug 12, 2025
@cheenamalhotra
Copy link
Member

@paulmedynski @apoorvdeshmukh I think JSON tests enablement will be done separately, and its not covered in this PR.

@paulmedynski paulmedynski self-assigned this Aug 27, 2025
@mdaigle mdaigle self-assigned this Aug 27, 2025
paulmedynski
paulmedynski previously approved these changes Aug 28, 2025
Copy link
Contributor

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request.

@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.75%. Comparing base (cf2bdc7) to head (6dbb4db).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3559      +/-   ##
==========================================
- Coverage   63.19%   61.75%   -1.45%     
==========================================
  Files         274      269       -5     
  Lines       62478    61202    -1276     
==========================================
- Hits        39486    37797    -1689     
- Misses      22992    23405     +413     
Flag Coverage Δ
addons ?
netcore 63.83% <ø> (-2.94%) ⬇️
netfx 64.57% <ø> (-1.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apoorvdeshmukh apoorvdeshmukh merged commit 0b16250 into dotnet:main Sep 2, 2025
236 checks passed
apoorvdeshmukh added a commit that referenced this pull request Sep 2, 2025
benrr101 pushed a commit that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants