Backport 6.0 | SqlDecimal Extract Data #3466
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Backport of the .NET 6.0 change to simplify how SqlDecimal data fields are extracted in the netfx build, replacing the old serialization-based decomposer with a direct call to SqlDecimal.Data.
- Removed complex serialization/
DynamicMethod-based decomposer forSqlDecimal - Added a straightforward
SqlDecimalExtractDataimplementation usingDataproperty - Cleaned up unused usings and added XML doc comments and links
Comments suppressed due to low confidence (1)
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlTypes/SqlTypeWorkarounds.netfx.cs:137
- [nitpick] Add unit tests for
SqlDecimalExtractData, especially for theSqlDecimal.Nullcase and typical non-null values, to verify that data fields are correctly extracted and nulls are handled safely.
internal static void SqlDecimalExtractData(
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlTypes/SqlTypeWorkarounds.netfx.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to legal reasons, we have to take a change to the SqlDecimal type workarounds in netfx.
Issues
N/A
Testing
This is a drop-in replacement for the existing method, CI should successfully verify.