Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix | Fix Async issue with Azure Attestation Service #346

Merged
merged 17 commits into from
Dec 13, 2019
Merged

Fix | Fix Async issue with Azure Attestation Service #346

merged 17 commits into from
Dec 13, 2019

Conversation

karinazhou
Copy link
Member

  • Modify SqlColumnEncryptionEnclaveProvider APIs to accept more parameters to pass some custom data on driver level.
  • Get rid of the initial thread caching workaround which does not work with Async scenarios.
  • Add generateCustomData flag to avoid unnecessary nonce generation.

@karinazhou
Merge pull request #1 from dotnet/master
85ef645 
Merge From dotnet
@karinazhou
Merge branch 'master' of https://github.com/dotnet/SqlClient
3351abd
@karinazhou
Merge pull request #2 from dotnet/master
5b34d06 
merge dotnet to local repo
@karinazhou
Merge pull request #3 from dotnet/master
ca1c910 
Update from Microsoft SqlClient
@karinazhou
Merge pull request #4 from dotnet/master
4a2e322 
Update from Microsoft
@karinazhou
Merge pull request #5 from dotnet/master
06f29a3 
Update from dotnet/SqlClient
@karinazhou
Merge pull request #6 from dotnet/master
06a02b9 
Merge from dotnet/SqlClient
@karinazhou
Merge branch 'master' of https://github.com/dotnet/SqlClient
cef6b8b
@karinazhou
Merge branch 'master' of https://github.com/dotnet/SqlClient
fedd72e
@karinazhou
Merge branch 'master' of https://github.com/dotnet/SqlClient
735da27
@karinazhou
Merge branch 'master' of https://github.com/dotnet/SqlClient
ae50df8
@karinazhou
Merge branch 'master' of https://github.com/dotnet/SqlClient
4a3c2a1
@karinazhou
Fix Async issue when using Azure Attestation Service
3445835
@karinazhou
Merge branch 'master' of https://github.com/dotnet/SqlClient into Asy…
ec79e67 
…nc_AAS
@karinazhou
Named argument specifications issue
2c1ee97
@cheenamalhotra cheenamalhotra added this to the 2.0.0-preview1 milestone Dec 7, 2019
@cheenamalhotra cheenamalhotra added the 🔨 Breaking Change Issues/PRs that are related with breaking API changes in the driver. label Dec 9, 2019
msrajatj
msrajatj approved these changes Dec 13, 2019
View reviewed changes
Copy link

@msrajatj msrajatj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@karinazhou karinazhou merged commit a4efef8 into dotnet:master Dec 13, 2019
@karinazhou karinazhou changed the title Fix Async issue with Azure Attestation Service Fix | Fix Async issue with Azure Attestation Service Dec 13, 2019
@karinazhou karinazhou deleted the Async_AAS branch January 14, 2020 23:53
@cheenamalhotra cheenamalhotra mentioned this pull request Jan 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msrajatj msrajatj msrajatj approved these changes

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@David-Engel David-Engel Awaiting requested review from David-Engel

@JRahnama JRahnama Awaiting requested review from JRahnama

@saurabh500 saurabh500 Awaiting requested review from saurabh500

Assignees
No one assigned
Labels
🔨 Breaking Change Issues/PRs that are related with breaking API changes in the driver.
Projects
None yet
Milestone
2.0.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@karinazhou @cheenamalhotra @msrajatj