5.1 | APIScan | MSAL WithClientName (3rd attempt)

[benrr101]

Description

Backporting rewriting MSAL application building code to use CreateWithApplicationOptions and avoid (formerly) undocumented APIs. See #3354 for full details of change.

Issues

An attempt to resolve ADO APIScan issue, but technically no longer necessary.

Testing

Local build succeeds, far too much work to setup to validate locally.

[Copilot]

Pull Request Overview

This PR backports changes to the MSAL application building code to use CreateWithApplicationOptions and remove the usage of formerly undocumented APIs.

• Unifies client application creation using a builder pattern.
• Adjusts configuration for different frameworks (NETSTANDARD vs NETFRAMEWORK).

Comments suppressed due to low confidence (2)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs:543

• The new implementation no longer applies WithParentActivityOrWindow for NETSTANDARD (_parentActivityOrWindowFunc), which was present in the previous version. Please verify this change is intentional and that no functionality is lost compared to the original branch.

PublicClientApplicationBuilder builder = PublicClientApplicationBuilder.CreateWithApplicationOptions(new PublicClientApplicationOptions

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs:560

• Automated tests appear to be lacking for the new MSAL client configuration paths. Consider adding tests to validate the builder setup for both NETSTANDARD and NETFRAMEWORK scenarios.

return builder.Build();

[paulmedynski]

Missing .NET Standard case?

[mdaigle]

Same comment as @paulmedynski

[codecov]

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.74%. Comparing base (5df1ac3) to head (b5c38f3).
Report is 1 commits behind head on release/5.1.

Files with missing lines	Patch %	Lines
...SqlClient/ActiveDirectoryAuthenticationProvider.cs	91.66%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           release/5.1    #3367      +/-   ##
===============================================
- Coverage        71.89%   71.74%   -0.16%     
===============================================
  Files              293      293              
  Lines            61650    61647       -3     
===============================================
- Hits             44323    44228      -95     
- Misses           17327    17419      +92     

Flag	Coverage Δ
addons	92.38% <ø> (ø)
netcore	75.79% <100.00%> (-0.25%)	⬇️
netfx	69.50% <91.66%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.