- 
                Notifications
    You must be signed in to change notification settings 
- Fork 316
Cleanup | SNI Native Wrapper #3156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    mdaigle
  
              
              approved these changes
              
                  
                    Feb 18, 2025 
                  
              
              
            
            
| /azp run | 
| Azure Pipelines successfully started running 1 pipeline(s). | 
| Codecov ReportAttention: Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #3156      +/-   ##
==========================================
- Coverage   72.57%   72.52%   -0.05%     
==========================================
  Files         288      289       +1     
  Lines       59526    59503      -23     
==========================================
- Hits        43201    43156      -45     
- Misses      16325    16347      +22     
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
5aa8c2c    to
    bc5bc5b      
    Compare
  
    
              
                    paulmedynski
  
              
              reviewed
              
                  
                    Mar 6, 2025 
                  
              
              
            
            
        
          
                src/Microsoft.Data.SqlClient/src/Interop/Windows/Sni/SniNativeWrapper.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
              
                    paulmedynski
  
              
              reviewed
              
                  
                    Mar 6, 2025 
                  
              
              
            
            
        
          
                src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDependency.cs
          
            Show resolved
            Hide resolved
        
      
              
                    paulmedynski
  
              
              approved these changes
              
                  
                    Mar 6, 2025 
                  
              
              
            
            
              
                    paulmedynski
  
              
              approved these changes
              
                  
                    Mar 7, 2025 
                  
              
              
            
            
12614c8    to
    ac9be84      
    Compare
  
    
  This was referenced Oct 13, 2025 
      
  This was referenced Oct 20, 2025 
      
  This was referenced Oct 27, 2025 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    Code Health 💊
  Issues/PRs that are targeted to source code quality improvements. 
  
    Common Project 🚮
  Things that relate to the common project project 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This is a replacement of #3056 that will give us the complete CI
Description: This is a followup to the SNI Native Wrapper code merge. Each commit in this PR is an atomic change, so if the PR gets too cluttered to review all up, it can be stepped through one commit at a time. Most of these changes are just renaming and moving code around. One larger change is removing a bunch of private methods that were no longer necessary after extracting the DLL imports (as mentioned by @edwardneal).
Testing: There aren't really any functional changes here, so CI pass should be sufficient validation.