Fix | Don't validate server certificate when using Authentication option but not encrypting #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion but not encrypting
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2224 +/- ##
==========================================
+ Coverage 68.46% 72.36% +3.90%
==========================================
Files 309 309
Lines 62181 62196 +15
==========================================
+ Hits 42570 45008 +2438
+ Misses 19611 17188 -2423
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
arellegue
approved these changes
Nov 17, 2023
DavoudEshtehari
added
the
Area\Netfx
|
Could we have a unit test to cover this case if already there isn't one? |
The test ADIntegratedUsingSSPI (renamed in this PR from the inaccurate ADInteractiveUsingSSPI) was exercising this bad path in our Kerberos pipelines but the old ones are configured with TrustServerCertificate=true to avoid this issue. The new Kerberos pipeline wasn't using TrustServerCertificate=true, so it was hitting this issue. I added another test to specifically / force Authentication=SqlPassword and TrustServerCertificate=false to help ensure this doesn't regress in localhost pipelines. |
DavoudEshtehari
approved these changes
Nov 30, 2023
vadymkutsenko
added a commit
to rabotaua/SqlClient
that referenced
this pull request
Oct 11, 2024
commit 2f0de19396721dd10ca8587c73ba1e1347d444a5
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Fri Oct 11 02:13:34 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit 88086308fc36c1e570f230e4e1a83303461857c8
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Wed Oct 9 06:13:20 2024 +0100
Merged DbConnectionPool (#2812)
commit 40206cd514bb5eed80fca84ff2934fc1aac17a4c
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Wed Oct 9 05:22:04 2024 +0100
Enrol GetSchema commands into current transaction (#2876)
commit 2a015d2197177791bac2d454ed5dc27d08af9ae2
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Wed Oct 9 05:21:49 2024 +0100
Allow errors with negative numbers to be considered transient (#2896)
commit bfb2579e3e59e2a7d3d229104bc151eaa3b997ee
Author: David Engel <davidengel@microsoft.com>
Date: Tue Oct 8 21:21:04 2024 -0700
CertificateTests are broken (#2805)
commit a852709376e34f7bbeb2c3942795dc7c04d831ce
Author: David Engel <davidengel@microsoft.com>
Date: Tue Oct 8 21:18:41 2024 -0700
Retry Build Ext Utilities and Nuget Restore on failure (#2906)
commit 467701e0bb6786e7bd7fd49b8e14db2003162ac1
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Tue Oct 8 21:57:04 2024 +0100
Merge SqlColumnEncryptionEnclaveProvider, SqlColumnEncryptionCspProvider, SqlColumnEncryptionCngProvider (#2501)
Thanks @edwardneal !
* Merged SqlColumnEncryptionEnclaveProvider.NetCoreApp.cs
* Merged SqlColumnEncryptionEnclaveProvider
* Merged SqlColumnEncryptionCspProvider
* Merged SqlColumnEncryptionCngProvider
* Corrected project files post-merge
commit 9b9bdc1c0348d272fab1d2a6586beb482c7fc5b6
Author: Benjamin Russell <russellben@microsoft.com>
Date: Tue Oct 8 13:51:33 2024 -0500
Cleanup | Flatten Interop Folders (#2900)
* Remove the extra src folder in interop, etc.
* Move netfx common files out of src folder
* Fixing a couple file includes
* Delete files that weren't part of the project
commit b0433f019fa0daeba141aa7e6548a0c72be20b38
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Tue Oct 8 17:49:56 2024 +0100
Merge AAsyncCallContext, cleanup for SqlDataReader merge (#2383)
Thanks again to @edwardneal !
* Merged AAsyncCallContext.
Also changed netfx SqlDataReader to use the common class hierarchy, and made whitespace changes to SqlDataReader to make the netcore/netfx diff slightly shorter
* Expanding use of CallerMemberName in SqlDataReader
* Adjusted comments and variable names, added conditional compilation blocks.
These aren't functional changes, but they do pare down the diff between netcore and netfx.
Also sealed the Snapshot class in both codebases for performance improvements.
* Reverted change to ObjectID following compilation and testing
* Corrected a failing manual test
* Further post-merge changes
Keeps SqlDataReader in sync with main
* Code review comments
Also one AlwaysEncrypted sync/bugfix in SqlDataReader from netfx to netcore
* Corrected conditional compilation directive
commit ca9272d1eb1db843119ef120ff02f7067b0f4e4a
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Mon Oct 7 21:26:27 2024 +0100
Add test coverage for PR 2873 (#2897)
commit 7a7b247aa66c5eafb5a39f750d819084b1d551a9
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Mon Oct 7 19:54:17 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit 76338d3800ed7c906e00220294e8b353c0bb5735
Author: Benjamin Russell <russellben@microsoft.com>
Date: Mon Oct 7 11:14:59 2024 -0500
Merge | Bring netcore Interop to Common Project (#2893)
* Move ntdll interop files from netcore to common folder
* Moving enough interop files into the common project to enable SqlFileStream migration
* Move Interop.FileTypes and Interop.SetThreadErrorMode into common interop folder.
* Move Interop.IoControlCodeAccess
* Moving Interop.Libraries into the common project
* Removing files that were moved
commit 9433389ebba4528a192abaa386dea97da202d166
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Mon Oct 7 17:01:01 2024 +0100
Removed references to CTAIP and client certificate authentication (#2831)
commit 4e118ae2b792a51a9866a94ad5cbf198fee9bba7
Author: Maxim Markelow <markelow.dev@gmail.com>
Date: Mon Oct 7 18:56:46 2024 +0300
Fixed incorrect string format at event tracing when OutOfMemory exception thrown (#2797)
commit c0ae757809fa43441832d6ac220bb310e5102cc2
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Sat Oct 5 08:36:52 2024 +0100
Merge AlwaysEncryptedHelperClasses, TdsParserHelperClasses (#2376)
commit 32b5a67fe6b95a4e15ace8fae7a20e6db6421136
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Sat Oct 5 08:30:43 2024 +0100
Removed unreferenced/unused code (#2814)
commit d3772fcb8c9fb48cad577abce1f3f6474d97da48
Author: Javad Rahnama <j.rahnama79@gmail.com>
Date: Sat Oct 5 00:28:23 2024 -0700
Fix | Increase routing attempt to 10 in netcore for LoginNoFailover and adding routing support to LoginWithFailover (#2873)
commit cab54224419ae81c30f05eb2ea3aebc154ca99be
Author: Benjamin Russell <russellben@microsoft.com>
Date: Tue Oct 1 11:32:12 2024 -0500
Project for Common Files (#2887)
* Project file for common files. Not built in any configuration.
* Removing root namespace to prevent warnings for wrong namespace.
commit 72951f45468e0944db64440f15718b7d3094ede8
Author: Deepak Saini <deepaksaini@microsoft.com>
Date: Tue Oct 1 19:59:23 2024 +0530
Fix SqlDataReader.IsDBNull() for json (#2892)
commit cc58d7923952a8b2e9e397490dca2b08f7f3ce80
Author: Deepak Saini <deepaksaini@microsoft.com>
Date: Tue Oct 1 00:42:28 2024 +0530
Enhancement tasks for json support (#2891)
* some enhancements tasks for json support
* added some missing drop table funtion
* remove unique naming for tables and SPs
commit 0266b4a2209f732ead650181ae924a74a0c4cf40
Author: Deepak Saini <deepaksaini@microsoft.com>
Date: Sun Sep 29 01:38:33 2024 +0530
Adding SqlJson and Data write with SqlJson (#2752) (#2880)
* Adding SqlJson and Data write with SqlJson (#2752)
* Adding the SqlJson type
Remove unused
Adding all the json tests
Revert "Remove unused"
This reverts commit c448b6e2e810630d217826e73a644f7f9815d366.
Remove unused
* Change to static
* Adding the SqlJson support
* Adding the assert for column encryption
* Adding the support for Json writes
* Adding more support
* Enabling the following
SqlString sqlString = reader.GetSqlString(0);
Assert.NotNull(sqlString.Value);
var sqlJson = reader.GetSqlJson(0);
Assert.NotNull(sqlJson);
string fieldval = reader.GetFieldValue<string>(0);
Assert.NotNull(fieldval);
JsonDocument jsondoc = reader.GetFieldValue<JsonDocument>(0);
Assert.NotNull(jsondoc);
* Revert "Enabling the following"
This reverts commit 6739e455b62c88a56100552072eea368d05e23ea.
* ref update for SqlJson
* resolve PR comments
---------
Co-authored-by: Saurabh Singh <1623701+saurabh500@users.noreply.github.com>
commit 4806059d1d2a40f00c2f9adfc2d9d4f0f3a02eae
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Fri Sep 27 12:42:57 2024 -0700
Fix | Addressing documentation issues along with spelling errors (#2889)
commit 6064d026858fc2585e81bda5600ac60388be75ea
Author: Apoorv Deshmukh <apdeshmukh@microsoft.com>
Date: Fri Sep 27 09:52:33 2024 +0530
Add streaming support for JSON (#2882)
This commit adds support for streaming JSON data to and from Sql Server.
JsonStreamTest has been added to demonstrate this functionality.
commit ed0a132d365611afaf114ab2281e71c402e32f37
Author: Benjamin Russell <russellben@microsoft.com>
Date: Tue Sep 24 18:01:51 2024 -0500
Fix build breaks (#2885)
commit 135120af6556ca0151cd834450e54751d0f6e84f
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Tue Sep 24 16:51:55 2024 +0100
XML documentation corrections - batch 1 (#2836)
Thanks @edwardneal!
* Rollup of feedback from Batch 1 PR
* Respond to code review
Also expanded SqlBatch corrections to code files and other instances in the XML documentation.
commit c690120925476280542e38a28c7d3b1be8478455
Author: Benjamin Russell <russellben@microsoft.com>
Date: Mon Sep 23 11:22:31 2024 -0500
XML Documentation Fixes - Batch 7 (#2869)
* Batch 7 w/o testing
* Spot checking!
* Fixing build issue
commit 3d9c1e4178034cc1c709ad18832b056fc1c380a2
Author: Benjamin Russell <russellben@microsoft.com>
Date: Mon Sep 23 11:22:07 2024 -0500
XML Documentation Fixes - Batch 8 (#2871)
* Batch 8.1
* Batch 8.2
* Batch 8.3
* Batch 8.4?
* Checking things over
commit cb11317441e091d9ad40ad8f6e738831f252476c
Author: Benjamin Russell <russellben@microsoft.com>
Date: Fri Sep 20 16:54:30 2024 -0500
XML Documentation Fixes - Batch 5 (#2864)
* Batch 5 part 1
* Batch 5 part 2
* Finishing up changes to batch 5
* PR Comments
commit bc08543c1d3380b1ef6cac7e27761ce568cfb010
Author: Deepak Saini <deepaksaini@microsoft.com>
Date: Fri Sep 20 11:58:08 2024 +0530
Implement read and write functionality for JSON (#2829)
* Implement read and write functionality for JSON col (#2722)
* Implement read functionality for JSON col
* Remove SqlJson class
* Implement JSON write functionality
* Remove code comment for new datatypes
* Json read and write tests (#2744)
* Json read and write tests
* added sp tests
* remove AppContext Switch
* resolve some PR comments
* refactored tests
* add async testing
* fix build errors
* Ref update for SqlDbTypeExtensions (#2745)
* resolve PR comments
* Apply suggestions from code review
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
---------
Co-authored-by: Apoorv Deshmukh <apdeshmukh@microsoft.com>
Co-authored-by: Saurabh Singh <1623701+saurabh500@users.noreply.github.com>
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
commit 95cd389878cc8f9f638eafff9e7f64be577c36d2
Author: Benjamin Russell <russellben@microsoft.com>
Date: Thu Sep 19 13:06:45 2024 -0500
XML Documentation Fixes - Batch 6 (#2865)
* Batch 6 part 1
* Finishing up batch 6
commit 3416ad92b9107d2618bc7ffdf1d595a86cf0e7d0
Author: Benjamin Russell <russellben@microsoft.com>
Date: Thu Sep 19 12:26:42 2024 -0500
XML Documentation Fixes - Batch 4 (#2863)
* Batch 4
* Touching up and fixing mistakes
* Tabs to spaces
* Using new sample file
commit cdc33d91a64308e4861844da755ffbe9a407cc1c
Author: David Engel <davidengel@microsoft.com>
Date: Mon Sep 16 11:19:18 2024 -0700
Sync sample changes into snippet doc (#2837)
commit 68a5be4eee9224c9c6007398e952d1f7f02c2570
Author: Benjamin Russell <russellben@microsoft.com>
Date: Mon Sep 16 11:49:04 2024 -0500
XML Documentation Fixes - Batch 3 (#2851)
* Batch 3
* Fixing issue from last PR
* Making sure everything is ready for PR (left off at sqlcommand.xml)
* Finishing up work for batch 3
* PR comments
commit 321080e2b25b39e42b3aadc325610a96654c298b
Author: dauinsight <145612907+dauinsight@users.noreply.github.com>
Date: Fri Sep 13 10:57:12 2024 -0700
Update CDP_BUILD_TYPE condition in AKV provider (#2854)
commit 764add38972945f5212c9cc5cf346c493c310187
Author: Benjamin Russell <russellben@microsoft.com>
Date: Thu Sep 12 12:53:43 2024 -0500
XML Documentation Fix - Batch #2 (#2834)
* Batch #2
* Reverting removal of the snippet files.
* Fixing build break caused by parameter not having a comment.
* These changes should fix the broken comments
commit b1d3a8297a8d7d3b62e35cb87924feb90afa4cb3
Author: Malcolm Daigle <mdaigle@microsoft.com>
Date: Tue Sep 10 11:01:37 2024 -0700
Port double clean fix to netfx (#2843)
commit 069c052922c7183ec66f39904bfaf77fa2622c1f
Merge: db64574c eb4c0f04
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Mon Sep 9 23:01:05 2024 +0000
Merge in 'main' changes
commit db64574c63daff25026000d9c84e3b3822b11263
Merge: f8f2a964 8412215e
Author: Daniel Au <v-audaniel@microsoft.com>
Date: Mon Sep 9 21:16:08 2024 +0000
Merged PR 4909: eng | Fix strong name in AKV provider
Bug fix to address the missing strong name in the Azure Key Vault (AKV) provider.
This pull request fixes the strong name issue in the AKV provider for various .NET frameworks.
- `Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj`: Added strong name generation configurations.
- `build-all-configurations-signed-dlls-step.yml`: Updated MSBuild arguments to use `SigningKeyPath`.
- `code-analyze-step.yml`: Updated MSBuild command line to include `SigningKeyPath`.
Related work items: #31596
commit eb4c0f043bff30c7f3bb58704b41c73faef9d63b
Author: Malcolm Daigle <mdaigle@microsoft.com>
Date: Mon Sep 9 11:04:55 2024 -0700
Advance column index to avoid double clean. (#2825)
commit 8412215e9f8231bb10e4ef8ba98d113450025aaa
Author: dauinsight <v-audaniel@microsoft.com>
Date: Mon Sep 9 08:39:32 2024 -0700
Simplify assembly key file condition
commit 62af3b51318ebba36327aa61b014264fd57a4130
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Fri Sep 6 11:16:27 2024 -0700
Fix | Adding readme to nuget package (#2826)
commit cf92a05fd5ba458c1001dcd4af1b5bfba93dde66
Author: David Engel <davidengel@microsoft.com>
Date: Thu Sep 5 11:30:55 2024 -0700
Sample code improvements around token caching (#2821)
commit 5dc7b06e16705f6dcb8a0f437b28cd320ee2a719
Author: Benjamin Russell <russellben@microsoft.com>
Date: Thu Sep 5 13:06:13 2024 -0500
Reverting removal of the snippet files. (#2835)
commit 77b2c7aae21a4953c816d5426513471dccb8370b
Author: dauinsight <v-audaniel@microsoft.com>
Date: Thu Sep 5 10:21:05 2024 -0700
Remove sign assembly from AKV build command
commit b6a28f7f9b65a36af41533a44b4d4fb7bf0c1c65
Author: Benjamin Russell <russellben@microsoft.com>
Date: Thu Sep 5 10:56:20 2024 -0500
XML Documentation Fix - Batch 1 (#2822)
* Batch 1 of fixing xml files
* Removing CDATA blocks, fixing cref links
* Fixing a couple more issues
commit dbe09f1152f448ec7b6037579d9bcbf98b016fce
Author: dauinsight <v-audaniel@microsoft.com>
Date: Wed Sep 4 14:34:17 2024 -0700
Update AKV strong name
commit d89372af4153ec41f320b912748e032b160160c9
Author: Deepak Saini <deepaksaini@microsoft.com>
Date: Sat Aug 31 04:04:13 2024 +0530
Add Feature Extension for Json Support (#2773)
* Add Feature Extension for Json Support (#2696)
* change json hexa code and fix invalid login error
* Change name to match other naming conventions
* process JSONSUpport acknowledgement
* Fix naming conventions
* Processing 2nd byte from server
* Changes for netfx
* Json support feature ack in Test TDS server
* Remove enabled flag
* address PR comments
* Enable JSON only in debug bits
* Enable json tests in debug mode only
* resolve PR comments
---------
Co-authored-by: saurabh500 <1623701+saurabh500@users.noreply.github.com>
commit 8ff48a707ca0db95a18449c108a37e073f04b640
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Fri Aug 30 10:39:34 2024 -0700
Update README file (#2809)
commit aa0db93336511390b9e389123f25a5ae74e55c62
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Thu Aug 29 17:59:42 2024 +0000
Test | Fix Unit Tests for GetSqlServerSPN (#2442)
commit 9573da26fbab3de0ab75110f769b3c5b2f55199a
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Wed Aug 28 10:51:41 2024 -0700
Doc | Release notes v6.0 preview1 (#2813)
commit 5ea0e25d68b18e14e4446bd783fb91c4bc7cdf19
Author: David Engel <davidengel@microsoft.com>
Date: Tue Aug 27 16:24:24 2024 -0700
Add porting information about NLS to ICU .NET 5+ change (#2820)
commit c223dfb9c301812a4a73cad80d9f3c15d58c6a9b
Author: dauinsight <145612907+dauinsight@users.noreply.github.com>
Date: Tue Aug 27 15:48:48 2024 -0700
Hotfix v5.2.2 Release notes (#2770)
commit 12d5391686bb2795670d749a97b563e2da4f84d4
Author: dauinsight <145612907+dauinsight@users.noreply.github.com>
Date: Tue Aug 27 14:56:09 2024 -0700
Hotfix v5.1.6 Release notes (#2769)
commit f8f2a96403e99c008f5beb3a56e43f554af24db1
Merge: b50c074d bea3e67f
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Tue Aug 27 19:07:19 2024 +0000
Merge in 'main' changes
commit b50c074d9bb5cb5e19b0256bbe4f848b92d06f9f
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Tue Aug 27 17:33:34 2024 +0000
Merged PR 4888: eng | Fix package validation stage against the preview
commit bea3e67f3ee2b7f12cc3547455868c084a5d9e40
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Tue Aug 27 00:37:42 2024 +0100
Merged DbConnectionClosed, DbConnectionFactory, SqlAuthenticationProviderManager (#2410)
commit 71deba6427dbb4d50c4329508de827e2fd0ef15e
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Mon Aug 26 12:41:19 2024 -0700
Refine version.props and nuspec files (#2811)
commit 50767d79069226816b8b3367fae6db4c375a48ea
Author: dauinsight <145612907+dauinsight@users.noreply.github.com>
Date: Fri Aug 23 09:01:12 2024 -0700
Hotfix v4.0.6 Release notes (#2768)
commit 6d33e9d20e95f5f8d8eebe7db1458f88ca4dbd78
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Wed Aug 21 23:34:00 2024 +0100
Merged PoolWaitHandles, DbConnectionPoolIdentity, removed DbBuffer (#2390)
commit 85b9407e4ee699b3229c5bb1629f4219e52fdf74
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Aug 21 15:14:16 2024 -0700
Eng | Add strong name validation to package validator (#2802)
commit cc144a8a1c383106264cf348c5f889bd051d7463
Author: dauinsight <145612907+dauinsight@users.noreply.github.com>
Date: Wed Aug 21 15:10:58 2024 -0700
Hotfix v3.1.7 Release notes (#2800)
* Add release notes for 3.1.7
commit ef8d6cc6629395801aeca5a53571cdbd1b84fb5e
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Mon Aug 19 18:04:46 2024 -0700
Doc | Reorder release notes (#2791)
commit 4eafe1f7715ae00c94d898a583d0e6f9e9b75779
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Mon Aug 19 16:27:33 2024 +0000
Merged PR 4847: eng | Add support preview on MDS
commit ac1012a6b7ddaf0b14526ced7cea8c16e0791b23
Author: dauinsight <145612907+dauinsight@users.noreply.github.com>
Date: Fri Aug 16 13:22:55 2024 -0700
Hotfix v3.1.6 Release notes (#2767)
commit 619fa749551ed0d9e387d75cb3e6d85fe00a3df4
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Thu Aug 15 13:48:15 2024 -0700
Fix | Fix the issue with Socke.Connect in managed SNI (#2777)
commit d3658edfcda0d7eecabc09afb5459bb3f79e6290
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Wed Aug 14 17:18:51 2024 -0700
Update SNI version to 6.0.0-preview1.24226.4 (#2772)
commit 7216e84fb9819b56df1d51ca13969d4f89bf507a
Author: Benjamin Russell <russellben@microsoft.com>
Date: Fri Aug 9 12:40:30 2024 -0500
`null != x` => `x != null` (#2751)
commit 6fbbb787cd7ea35c06e292bb83d01ae94900b0bf
Author: Benjamin Russell <russellben@microsoft.com>
Date: Sat Aug 3 11:47:53 2024 -0500
Code Cleanup | `null == x` to `x == null` (#2749)
- With one approval and CI success, I think that's enough to move ahead on this one.
* `null == x` to `x == null`
* Update src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Co-authored-by: David Engel <dengel1012@gmail.com>
---------
Co-authored-by: David Engel <dengel1012@gmail.com>
commit 6f177e30f2a8bbd59a7ec093ef934e29e0578004
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Tue Jul 30 19:52:38 2024 +0000
Fix | Fixed some Azure managed identity authentication unit test failures (#2652)
commit 85956440bb0886c59dfa31475b9a6f5c510e3ac0
Author: Benjamin Russell <russellben@microsoft.com>
Date: Mon Jul 29 16:05:41 2024 -0500
Replace unused out arguments with discards (#2726)
* Replace unused out arguments with discards
* Removing unnecessary types in discarded out arguments
commit 0c4519871c9b69f7e05fe90f59d224d5f9ab3e3e
Author: Cédric Luthi <cedric.luthi@gmail.com>
Date: Sat Jul 27 05:30:08 2024 +0700
Avoid "early" access to SqlAuthenticationProviderManager.Instance (#2636)
commit 38ce399a77115a6f95fbe8ef54ee300aac58370b
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Fri Jul 26 11:33:47 2024 -0700
FIX | Revert the change to TargetFrameworkMonikerAssemblyAttributesPath from PR #2497 (#2725)
commit 04d610211027be0ea70eb2c1e55c24ffa3a5704f
Merge: 9e3bbacc 9d8062f1
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Thu Jul 25 07:29:05 2024 +0000
Merge in 'main' changes
commit 9e3bbaccc448d708a0d1ff96032f890c9a2045b6
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Wed Jul 24 21:23:40 2024 +0000
Merged PR 4782: eng | Secure symbols publishing
commit 9d8062f135d9b0491668eb40af5b7caeda2df5f2
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Jul 24 14:18:17 2024 -0700
Minor adjustment to sourcelink translation (#2713)
commit 1152fcf0c628ee84862779d86b9348376f64f4a8
Merge: f7313f81 c4fa6827
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Wed Jul 24 00:45:12 2024 +0000
Merge in 'main' changes
commit f7313f81542228f5fea1c974e5fda12bb4d5e2c0
Merge: be5fba23 e3cf4149
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Tue Jul 23 23:46:13 2024 +0000
Merge in 'main' changes
commit c4fa682749110f030d4f43caa488ec4832e04df1
Author: Wraith <wraith2@gmail.com>
Date: Wed Jul 24 00:46:09 2024 +0100
Change internal read functions to return TdsOperationResult (#2690)
commit e3cf4149a202218919fb9b83e275765aa908a40b
Author: David Engel <davidengel@microsoft.com>
Date: Tue Jul 23 10:38:25 2024 -0700
Fix macOS CI (#2699)
commit 79adbc23e786c1b07d3995d5e6717700324555ad
Author: Saurabh Singh <1623701+saurabh500@users.noreply.github.com>
Date: Tue Jul 23 06:29:52 2024 -0700
Adding the SqlDbTypeExtensions (#2688)
commit cf8cc22ae7c4e22764d8561e99cc3dbaa2325a78
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Tue Jul 23 02:09:52 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit 56c07c627e75fa8a9531b76d02ec8e0113ff3e08
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Mon Jul 22 13:59:01 2024 -0700
2698)
commit 3d7896ff7f656e35d987ce43bc1cb91d95eac5ae
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Mon Jul 22 11:28:25 2024 -0700
set DisableSourceLinkTranslation to false (#2691)
commit 7110d29922e402a722ec5bc32fdc8f7bcdf596a4
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Mon Jul 22 02:09:38 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit a9621bdc411002f15adba0c849a4ccfbfa210707
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Sun Jul 21 02:17:48 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit be5fba235947f2712df3267ccf3654cede5be4f6
Merge: aa0a39be e2273713
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Thu Jul 18 21:48:11 2024 +0000
Merge in 'main' changes
commit e22737137ad2d7387c452af79d6c95ef9f6549d0
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Thu Jul 18 14:47:08 2024 -0700
eng | Add Delay sign to ref csprojs (#2684)
commit aa0a39be63d7240ec3eac315eadd0aba9d3230ad
Merge: 49e4da77 5c0ce12d
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Tue Jul 16 00:39:23 2024 +0000
Merge in 'main' changes
commit 5c0ce12d19972824f0e6b118812de916a6e90c49
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Fri Jul 12 19:00:13 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit 766b72a752a8df9670e273012b6a6b3718baee80
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Thu Jul 11 10:53:48 2024 -0700
Fix | Fix decrypt failure to drain data (#2618)
commit 784046fdbf02e97fb7190542e81ba20d93843261
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Thu Jul 11 10:42:56 2024 -0700
eng | Initial YAML CI pipeline (#2575)
commit ce7393b4d12dbd35c0b4ad61acbfc1f14a4edc8e
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Jul 10 11:34:17 2024 -0700
eng | Add delay signed to official builds (#2653)
commit a34ec48fb8b4cabbe349ef8019a0a885d3aefab1
Author: David Engel <davidengel@microsoft.com>
Date: Mon Jul 8 12:44:40 2024 -0700
Fix - Don't error when using infinte connect timeout and Entra auth (#2651)
commit bad621f7c141079c77574f1eb5b929ed195921a8
Author: David Engel <v-davidengel@microsoft.com>
Date: Fri Jul 5 10:32:31 2024 -0700
Test fixes to accommodate recent infra changes (#2646)
* Test fixes to accomodate recent infra changes
commit 0352a50f779b7977d87714c1934d1f21ea231b6d
Author: Benjamin Russell <russellben@microsoft.com>
Date: Tue Jul 2 17:36:55 2024 -0500
3 Small Changes (#2594)
* * Port sqlclientx datasource changes
* Remove link to missing nuget.config file
* Remove root namespaces from sqlclient csproj files
* Test to see if namespace changes are breaking the pr build
* Reinstate removing the root namespace and fix resource filename generation
commit f55c5a2065f947942d11c52f2a62a349419278cb
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Thu Jun 27 16:34:57 2024 +0000
Merged common code base for AlwaysEncryptedKeyConverter (#2538)
* Merged AlwaysEncryptedKeyConverter.CrossPlatform and AlwaysEncryptedKeyConverter.Cng.
commit aece3669a9ae47145d9d68e91c47119079ba7cf8
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Thu Jun 27 14:53:48 2024 +0200
Add test for issue 2456 (#2457)
commit f91dc82ca52957ee1bc3d4f233a6e950a8a8dcbb
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Wed Jun 26 22:06:33 2024 +0200
Change | Remove some unneeded references and update Azure.Identity (#2577)
commit eb46c58805e562a59c1f8d9fb2338645e1a39b05
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Wed Jun 26 16:29:52 2024 +0200
Add | No-op if engineedition is 6 or 11 due to lack of support for ASSEMBLYPROPERTY function (#2593)
commit 8777fceef974e95697728f9889e6ce734add759d
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Tue Jun 25 13:58:15 2024 +0100
Merge SqlColumnEncryptionCertificateStoreProvider (#2521)
commit 49e4da777e33d81e4b7c551bd007a240f28207cb
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Fri Jun 21 21:48:23 2024 +0000
Merged PR 4673: eng | Upgrade ESRP to v5.0
- [Sample run](https://dev.azure.com/SqlClientDrivers/ADO.Net/_build/results?buildId=91327&view=results)
Related work items: #30897
commit 55f48c57a9b2a200c266b8739a2a477f974ab41d
Merge: 1dfd4833 d4b2bb32
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Wed Jun 12 21:30:06 2024 +0000
Merge in 'main' changes
commit d4b2bb32ac2ab2f9ecd12c441733f8d179bf255d
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Jun 12 14:28:37 2024 -0700
Addressing conflict (#2560)
commit a240c2432614c156f0f81b9beb7994f2d35ebc52
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Jun 12 13:15:39 2024 -0700
Address conflicts (#2562)
commit d7f84eb09dd8e70ac73f190f913e1dd1a9641138
Author: David Engel <v-davidengel@microsoft.com>
Date: Wed Jun 12 12:11:41 2024 -0700
Add scope trace for GenerateSspiClientContext (#2497)
commit c822b6917da7e38445777869acdaf13634a826f8
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Wed Jun 12 17:16:35 2024 +0000
Merged common code base for SqlUtil.cs (#2533)
commit 080e66950d9d0b6d113c8eae3a2056372159f258
Author: David Engel <v-davidengel@microsoft.com>
Date: Wed Jun 12 09:20:14 2024 -0700
Add | Cache TokenCredential objects to take advantage of token caching (#2380)
commit a7405ded70a0139a41e97c2ace76977b3a5260a4
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Tue Jun 11 14:53:27 2024 -0700
Add | Add SourceLink translation (#2552)
commit 689cc257fa250d42728c5d240b888b1f151cfd7c
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Tue Jun 11 21:05:07 2024 +0000
Fix | Replaced System.Runtime.Caching with Microsoft.Extensions.Caching.Memory (#2493)
commit ffd8771a599f90557facdebd983cd4e60dbb6f83
Author: Wraith <wraith2@gmail.com>
Date: Tue Jun 11 21:46:23 2024 +0100
Strong typed diagnostics (#2226)
commit 3f0c4b1a706136e417efa3a49bc168342470513e
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Tue Jun 11 19:14:48 2024 +0000
Fix | Fixed GenerateSspiClientContext to retry negotiation with default port (#2559)
commit f7ab11591d6fe736f26e1d21756e29e2a2d259d2
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Sat Jun 8 10:44:31 2024 -0700
Fix | Adjust path for .AssemblyAttributes in obj folder (#2550)
commit 1dfd48333c30d031f2f96cd0a40dcf0954cd0ba4
Author: Daniel Au <v-audaniel@microsoft.com>
Date: Fri May 31 22:36:06 2024 +0000
Merged PR 4621: eng | Fix policheck
commit 348ae2ee13ddccd64fe5fe4220ff22ba04ef9a4b
Author: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Date: Fri May 31 17:07:36 2024 -0500
Improve AccessTokenCallback sample code (#2543)
commit 42e9f08f91a3e1a1602d6b632df00f89abe04760
Author: dauinsight <145612907+dauinsight@users.noreply.github.com>
Date: Fri May 31 14:57:21 2024 -0700
Hotfix v5.2.1 Release notes (#2534)
commit 7af2438ee177738131c6b13dc37743a2dafe6910
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Thu May 30 12:11:53 2024 -0700
Fix | Enhance certificate validation (#2487)
commit 808d4c3b5a935e6954c96ce02d99c53b624099dc
Author: Benjamin Russell <russellben@microsoft.com>
Date: Wed May 29 18:45:55 2024 -0500
Change | Separate tests for NetFx and NetCore - NetFx-Only Connection String Properties (#2466)
* Adding TransparentNetworkIpResolution to list of unsupported on platform connection string error messages
Splitting unit test for netfx-only connection string properties such that test does not fail on netcore
* Remove DeprecatedSynonymCount since referencing the unsupported array is not possible
commit 815e5ab19e9e096bc52f13a82170aa1c5e641826
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Tue May 28 09:37:31 2024 -0700
Doc | Fix SNI dependencies of 5.1 and 5.2 release notes (#2537)
commit 4c088eb47c80209ed4506237b201a276f552f5bf
Author: Aris Rellegue <v-arellegue@microsoft.com>
Date: Fri May 24 20:05:54 2024 +0000
Merged PR 4583: eng | Fix policheck errors.
Fix policheck errors.
Sample pipeline run which did not have policheck errors:
https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=88114&view=sariftools.scans.build-tab
Related work items: #30279
commit b7c4007d0deb2c2ffa8281f7f731a59f42a5fce1
Author: David Engel <v-davidengel@microsoft.com>
Date: Fri May 24 10:21:39 2024 -0700
Enhancement | Add trace logs for packet size (#2522)
commit b178ba5d324cfc77a4ff68cf7c250895f766dbeb
Author: David Engel <v-davidengel@microsoft.com>
Date: Thu May 23 12:10:21 2024 -0700
Fix | Clone of SqlConnection should include AccessTokenCallback (#2525)
commit cd7a3d10e88a15e6151afca1d0f2b972d6058fcb
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Thu May 23 09:20:03 2024 -0700
Updating Azure.Identity version to 1.11.3 (#2526)
commit 5cb73fdc9fa408fcd033510b2e2182085c1f14c9
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Tue May 14 19:31:10 2024 +0100
Merged SqlClientFactory between .NET Core and Framework (#2369)
commit cc6ea2181af5473648d5c7f79b71be30132d0ac0
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Tue May 14 20:30:08 2024 +0200
Streamline conditional compilation symbols (#2486)
commit 9a71c94c172fd5b231e9673525e95c7079528fa9
Author: Saurabh Singh <1623701+saurabh500@users.noreply.github.com>
Date: Mon May 13 15:37:01 2024 -0700
Update build guide for Linux (#2499)
Adding the detail about installing powershell on linux to build the driver
commit 4c0f013bac63d8bd928c985440acb1e2bc13d3c6
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Tue May 7 18:02:12 2024 +0200
Remove UWP (uap) references and special cased code (#2483)
commit b4f38f50d4fb03e49956b8007496c50c22fbbea2
Author: Taylor Southwick <tasou@microsoft.com>
Date: Mon May 6 16:27:12 2024 -0700
Use ReadOnlyMemory in (#2447)
commit 55d30c71b9c17b804710b4d7ba83d92f2b2676be
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Mon May 6 10:58:22 2024 -0700
Test | Remove AAS - VBS tests from test pipelines (#2474)
commit 48ab625f82bc2f147276e02862b47b24f06d576c
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Sat May 4 02:08:39 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit 05d51bf26732a1784eb4a0b2d96b50bea6989486
Merge: 7def235d 910bdb47
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Fri May 3 21:58:12 2024 +0000
Merge in 'main' changes
commit 7def235d764c1b1fa12db242afecf146a18a60f6
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Fri May 3 21:51:35 2024 +0000
Merged PR 4490: eng | Remove netstandard from production pipeline
- Complementary code change of PR [#2386](https://github.com/dotnet/SqlClient/pull/2386).
- This should be merged after merging the related PR to remove support of .NET Standard in the production pipeline.
- The first commit has the related PR's changes(review them on GH).
- After having merged the related GH PR and updating the CI pipeline, I'll sync with this PR to unify the changes and get passed the pipeline.
- Only the YAML changes under the `eng` folder should be reviewed (ignore the other changes as they are identical to the GH).
- Introduced `oneBranchType` parameter to switch between **Official** and **NonOfficial** templates
- [new sample run](https://dev.azure.com/SqlClientDrivers/ADO.Net/_build/results?buildId=86908&view=results)
Related work items: #30122
commit 910bdb4754bfd11c2043c8f8b89b91df49e46888
Author: Wraith <wraith2@gmail.com>
Date: Fri May 3 21:10:35 2024 +0100
make EnableOptimizedParameterBinding only apply to text mode commands and update documentation to match. (#2417)
commit ba288ef35c09101e0d3b8e96b4003dffbaae7c98
Merge: f05be20e cd4805b1
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Fri May 3 20:03:36 2024 +0000
Merge in 'main' changes
commit cd4805b144e170c946602d5c54d65ef649bce9a5
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Fri May 3 21:42:21 2024 +0200
Remove support for .NET Standard 2.0 and 2.1 (#2386)
commit 792479efaa7155143f3276965fac42c84de35e2e
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Fri May 3 09:22:31 2024 -0700
Test | Remove field with ClientSecretCredential (#2479)
commit 226bdb8e4cedd3933ca415a91d69b8c814b5b9df
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Thu May 2 09:50:38 2024 -0700
Fix | Fix DateTimeOffset size in TdsValueSetter.cs class file. (#2453)
commit aefd723026e75e68cea6bc98173404a5c765ab60
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Tue Apr 30 11:00:01 2024 -0700
Test | Updating tests to acquire token from user-assigned managed identity (#2473)
commit f05be20efe40d356f6313f810123a2e5870714dc
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Fri Apr 26 20:34:02 2024 +0000
Merged PR 4529: eng | fix a few issues and improvements
- Fixed a typo, publish symbols, and commit number
- Updated the cron for daily run in case of any code changes, besides the weekly run
- Added parameters instead of pipeline's variables
- TSA, SBOM, and CodeQL tools moved out of the `syncSdl` for compatibility with OneBranch's NonOfficial template
Related work items: #29920
commit c33bde24d4b68116938423c728903ebb3fa74b34
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Fri Apr 26 11:12:08 2024 -0700
Change | Updating Azure.Identity version to 1.11.2 (#2462)
commit 3f3380ccde46102987e527be18b26aee3e9b2026
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Thu Apr 25 12:25:42 2024 -0700
Test | Address XUnit failure on Windows Principal functionality is not supported on this platform (#2469)
commit 4bce7de7bef52823e7733e553c3fd29c3ac6f4ae
Merge: abff6630 68d35bb5
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Tue Apr 23 17:21:01 2024 +0000
Merge in 'main' changes
commit 68d35bb5f116feb2fd10f6b0b2d09a4a835562d5
Author: Benjamin Russell <russellben@microsoft.com>
Date: Thu Apr 18 15:35:25 2024 -0500
Change | Simplify Conditional File Inclusion (#2425)
* Wrap files in appropriate `#if` and simplify project file
* Sorting file includes
* Pulling over changes from a different branch from before rebase
* Merge changes that should've come in during merge ...
* Add <IsTestProject>true</IsTestProject>
* Change that should've been brought in on merge :thinking:
commit abff6630e79ed9fa15c63355a88a5f90819ba199
Author: MerlinBot <MerlinBot>
Date: Wed Apr 17 15:42:10 2024 +0000
Merge pull request 4357 from dependabot/docker/dotnet_docker_images/1708216907 into internal/main
commit ea7ad53b26ce24fcb22e643691f50eb6627f35a4
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Mon Apr 15 19:57:54 2024 +0000
Merged PR 4474: eng | Add AKV provider signed package
commit ae988c3e6c09725f1190cfb399c6d51835357aa7
Merge: 0c46cd7e 61e89f95
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Fri Apr 12 19:49:16 2024 +0000
Merge in 'main' changes
commit 61e89f9570bbe53dff0e4c750ccbdb7a46b274b0
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Tue Apr 9 21:27:44 2024 +0200
Fix | ArgumentNullException on SqlDataRecord.GetValue when using Udt data type (#2448)
commit f5df519f5e9783d6a726fb370678e05a04a3084b
Author: Evgeny Akhtimirov <evgeny@devduty.com>
Date: Tue Apr 9 15:04:53 2024 -0400
Fix | SqlBuffer.SqlGuid (#2310)
commit 8c9b6992aa812cad39d21460314cd68f5a989b45
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Tue Apr 9 20:33:07 2024 +0200
Extend DateOnly/TimeOnly support to include DataTable as structured parameter (#2258)
commit 4e6853e2dd61be2d0cde181c4c85e61dd7a2d2b5
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Tue Apr 9 20:32:27 2024 +0200
Update Microsoft.Identity dependencies (#2429)
commit 1bf025afeb76eef9eddfdddd306241730d1d61af
Author: Trayan Zapryanov <lrt80@abv.bg>
Date: Mon Apr 8 22:19:37 2024 +0300
Rent byte buffers in SqlSequentialTextReader (#2356)
commit 0c46cd7e019fa67465cf9ca6ba63254f3e7ac206
Merge: 294f8666 9811c657
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Fri Apr 5 22:04:44 2024 +0000
Merge in 'main' changes
commit 9811c657db1cd1ddc270addc9221579df32af6ba
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Fri Apr 5 22:03:34 2024 +0000
eng | Fix production pipeline (#2450)
commit 294f8666aebbe713b9d634dbc8b17c2f5617d02d
Merge: af118d72 9645c01a
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Fri Apr 5 22:02:38 2024 +0000
Merge in 'main' changes
commit 9645c01a1ef235cb2342a3847f508f5887dc76b7
Author: Benjamin Russell <russellben@microsoft.com>
Date: Fri Apr 5 13:37:36 2024 -0500
Add <IsTestProject>true</IsTestProject> (#2446)
commit bc2a83414804ffe6f21f6778df73cfc6367cd95e
Author: Taylor Southwick <tasou@microsoft.com>
Date: Thu Apr 4 16:32:45 2024 -0700
Consolidate SSPI context generation to single abstraction (#2255)
* Abstract the SSPI context generation
This change introduces SSPIContextProvider that can generate payloads for SSPI. Specifically, this change plumbs the current SSPI context generation into this object, while later changes will continue to update the shape to be a more general purpose, public API.
commit af118d72e4d60bbe26a824c0dd9de6400d2753f7
Merge: 226b83ec 4778b876
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Thu Apr 4 18:48:59 2024 +0000
Merge in 'main' changes
commit 226b83ec0f94e2ea00834c0127886ca97a517d2d
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Thu Apr 4 16:19:50 2024 +0000
Merged PR 4462: eng | Fix pipeline netfx build change
Addressing the failure on [dotnet-sqlclient-Official](https://dev.azure.com/SqlClientDrivers/ADO.Net/_build/results?buildId=84259&view=logs&j=a59e3b7b-7df8-53a3-7568-e4c5ffd2c23d&t=fa94fa55-e846-59ba-ffea-8e9b3df3ad3a)
commit 4778b8760dfc83037e259e5f79845b21ac844c7d
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Thu Apr 4 01:02:40 2024 +0000
Moved NuGet.config to the root (#2443)
commit 537eba862d6c2a6e8793cbf874515424df2e8bab
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Tue Apr 2 21:06:05 2024 +0000
Doc | update a sample description in SqlConnection (#2440)
commit 908f563699989d8d118c5cc3d330e59a45e9428d
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Mon Apr 1 07:47:03 2024 -0700
Fix | Suppress CodeQL warning for usage of deprecated Ssl2. (#2428)
commit 740069d657d8e201973fc7b650965a830280abc1
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Mon Apr 1 07:42:04 2024 -0700
Fix | Suppress CodeQL X509RevocationMode warning. (#2432)
commit 74084b010eb0c4834476eade199f6e5e0307286b
Author: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Date: Sat Mar 30 03:24:58 2024 +0530
Fixes UdtTestDb creating script (#2421)
commit 1594cc5fa02a942346deffb0064313b130758f6a
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Fri Mar 29 14:23:43 2024 -0700
Merge common code base for DBReferenceCollection (#2403)
commit 0d455647cdad87d32beea3173eef421bd1a88264
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Thu Mar 28 16:49:55 2024 +0000
Merged PR 4422: Pipeline | Initiate YAML pipelines
- A successful sample run can be found with the non-official template [here](https://dev.azure.com/SqlClientDrivers/ADO.Net/_build/results?buildId=82875&view=results) without SDL tools.
- There are a few errors reported by code analyzer that need to be addressed as well.
- Due to the known issue with APIScan and Onebranch, it's temporarily deactivated.
Related work items: #28134
commit 30cd171e0129ccf80bd95add6191687e987bbd4d
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Mon Mar 25 11:57:36 2024 -0700
Change | Convert Netfx to SDK style (#2413)
commit bdfa5d8dbe9acfc01d034bc1fe8b73ce8fe28109
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Mon Mar 25 11:56:49 2024 -0700
Regression | Revert PR #2281 SNIProxy code change (#2395)
commit 4e23bf94c566e04a2fa7fb930af05f3d76fb30c8
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Thu Mar 21 10:44:40 2024 -0700
Fix | The SqlConnection.FireInfoMessageEventOnUserErrors when set to true throws an exception (#2399)
commit 9056f13a18b82dc2698ad04da905c16ed5d4ed3f
Author: Benjamin Russell <russellben@microsoft.com>
Date: Tue Mar 12 13:31:06 2024 -0500
Downgrade Xunit, Improve exception handling for Diagnonstic Tests (#2379)
**Description**: While doing some investigation into improving the diagnostic tracing tests, I noticed that test failures are logged very non-descriptly by remote executor. To resolve this issue, we have to downgrade xunit to v2.4.2. Here's the rationale for this change:
* RemoteExecutor throws `XunitException`s from xunit.assert nuget and uses the `(string, string)` constructor
* The `(string, string)` constructor was removed in >=2.5 of xunit.assert
* RemoteExecutor was fixed to inherit from Exception in newer versions, but for us to take this requires upgrading to .net 7 or 8 (which I imagine is a much larger lift)
* In order to downgrade xunit.assert, we need to downgrade xunit
* In order to downgrade xunit, we also need to downgrade Microsoft.DotNet.XunitExtensions
* Without this change, exceptions from RemoteExecutor will fail to construct, masking all errors with "MethodNotFound"
Although normally downgrading is bad for security reasons, I believe this to be a safe change since it only affects tests.
This PR also makes a bunch of improvements to the `DiagnosticTest`s:
* Remove conditional facts when test TDS server is used
* Remove try/catch with empty catch block, replace with assert.throws
* Ensure that connections are opened before trying test conditions
* Document scenarios where test TDS server doesn't obey actual behavior, or where test TDS server cannot be used
* Formatting improvements
**Testing**:
* All tests (that are expected to pass) continue to pass
* In a synthetic failure of diagnostic tests, here's the before and after of the error messages:
* Before:
```
System.MissingMethodException: Method not found: 'Void Xunit.Sdk.XunitException..ctor(System.String, System.String)'.
System.MissingMethodException
Method not found: 'Void Xunit.Sdk.XunitException..ctor(System.String, System.String)'.
```
* After:
```
Microsoft.DotNet.RemoteExecutor.RemoteExecutionException: Remote process failed with an unhandled exception.
Microsoft.DotNet.RemoteExecutor.RemoteExecutionException
Remote process failed with an unhandled exception.
Child exception:
Xunit.Sdk.FailException: Assert.Fail(): Foo
at Microsoft.Data.SqlClient.ManualTesting.Tests.DiagnosticTest.<>c.<SyntheticFailure>b__1_0() in
C:\Projects\benrr101\sqlclient\src\Microsoft.Data.SqlClient\tests\ManualTests\TracingTests\DiagnosticTest.cs:line 34
```
* Downgrade xunit for better error logging from remote executor
* All but one test improved ... ?
* Understanding why test was failing
* Add arcade and xunit nugets to .net8+ special versions
* Remove xunitextensions version boost (which I spelled wrong anyhow)
commit 769b982606bc97fee797d6c061973c28400aa362
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Mar 6 19:24:54 2024 -0800
Adding CommonSourceRoot variable to Directory.Build.Props (#2392)
commit 4e341dcba8e5fe7248f2e3870e355aa78af46a3f
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Mar 6 14:20:33 2024 -0800
Update | updating version props for MDS v6.0.0 (#2382)
commit 5376a04adf786735422029e808333d2a3c6d1fef
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Tue Mar 5 09:12:26 2024 -0800
Fix | Fixed SqlBulkCopy.WriteToServer to ensure successful completion of consecutive calls to it. (#2375)
commit 2ddf7237328b45a4a5a9d41dc7d7edf4f566ae9b
Author: Jihoon Park <bartleby2718@gmail.com>
Date: Mon Mar 4 13:44:09 2024 -0500
Doc | Fix typo in SqlConnectionEncryptOption.xml (#2381)
commit ced726a3ee7b955be238267cc6dd7d61971731b4
Author: David Engel <v-davidengel@microsoft.com>
Date: Fri Mar 1 13:04:36 2024 -0800
Remove test reference to deprecated ADAL library (#2360)
commit 1a009b46c9729080c477882b3ce4c26285964de5
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Fri Mar 1 18:49:25 2024 +0100
Test | Improve test quality of life (#2331)
commit 8ef005a2ee67c55b2900bcbe32a931e3de64c556
Author: Benjamin Russell <benrr101@outlook.com>
Date: Wed Feb 28 17:38:28 2024 -0600
Build Tweaks for Onboarding (#2366)
commit 64bfe506d77e39ab31db5999b64253210907a59b
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Feb 28 10:39:12 2024 -0800
Release Notes 5.2.0 (#2370)
commit faf9b95995e6200a980bb6b1980f1d7af9f46cef
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Wed Feb 28 03:17:52 2024 +0000
Fix | ExecuteReaderAsync API xml and ref files (#2373)
commit 51ef22cd50eaa26432e6ec589bf70f7b72f5b60a
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Tue Feb 27 22:41:32 2024 +0000
Fix | ExecuteReaderAsync API return type in ref file (#2372)
commit e9cab013454b257ef70a004791f28682ac1f8019
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Tue Feb 27 20:30:02 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit 10c9e17283f7a4f1cfefcb080f9499461cc31d21
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Tue Feb 27 19:41:38 2024 +0000
Fix | Refine documents for GA v5.2 (#2371)
commit 94c089e75842909efb2226edc248f41c3776a037
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Mon Feb 26 14:00:09 2024 -0800
Fix | Fix unit test for SPN to include port number with Managed SNI (#2281)
commit 5cd9514cf27b78cf74f4d784b63246c5477552f2
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Mon Feb 26 12:46:16 2024 -0800
Test | Adjust tests to read IsAzureSynapse value from database (#2367)
commit 5a98166c6668b2d12e841d1dc9f69d9d2c0cbde2
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Thu Feb 22 03:11:15 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit 8b1b7a94ab3560c6b78377d85239af71f80b904b
Author: Javad <v-jarahn@microsoft.com>
Date: Wed Feb 21 13:06:55 2024 -0800
Fix | Removing non-breaking space from links inside some of exception messages. (#2364)
commit ed949d5b3dc504e1dc822c07c2c8f14332305b29
Author: Javad <v-jarahn@microsoft.com>
Date: Wed Feb 21 10:13:47 2024 -0800
Change | Updating SNI version to 5.2.0 (#2363)
commit e3cf59d226675acf7ae9169989ac692aea04f3da
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Wed Feb 14 03:08:15 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit af7d39d4496c23fa1660c828a84f31680c0079fc
Author: Javad <v-jarahn@microsoft.com>
Date: Tue Feb 13 13:52:23 2024 -0800
Fix | Addressing typo in exception message (#2357)
commit 237f260f600752b69eba05a65582d19f7f02e88d
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Tue Feb 13 17:24:35 2024 +0000
Test | Docker test enhancement (#2345)
commit ca5e3e835feff5836a06aff511acf7080ce76f49
Author: Javad <v-jarahn@microsoft.com>
Date: Fri Feb 9 20:17:21 2024 -0800
Removing DSA public key from SqlColumnEncryptionProvider to address CodeQL flags. (#2347)
commit 91df016175f2b24fd210b641d3e35eb2a708ad27
Author: H. Yeo <138053434+H-Yeo@users.noreply.github.com>
Date: Fri Feb 9 15:39:19 2024 -0800
Docs | Update Release Documentation for Contributors (#2351)
commit 06632465470be52ab472d4eee9b6028c5cef5422
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Fri Feb 9 10:34:19 2024 -0800
Fix | Mismatch System.Diagnostics.DiagnosticSource between versions.props and nuspec (#2349)
commit 507e8dd64d8c6235f81c9c1864013e7ee3f3f100
Author: Javad <v-jarahn@microsoft.com>
Date: Fri Feb 2 09:51:59 2024 -0800
AKV Release notes (#2335)
commit 4a2522df26abd6b8818b3f765c3745211272b07d
Author: Javad <v-jarahn@microsoft.com>
Date: Thu Feb 1 14:44:44 2024 -0800
Fix | Adding missing commitID to AKV nuspec (#2334)
commit 5e07b2959a5cd07d0f920e0484ad5c549ea29ec9
Author: Javad <v-jarahn@microsoft.com>
Date: Wed Jan 31 00:09:16 2024 -0800
Change | Updating AKV dependencies (#2330)
* Updating AKV dependencies
commit 5d106fe8c543230df8fa2f8dd9db341c89bd196b
Author: Javad <v-jarahn@microsoft.com>
Date: Mon Jan 29 16:20:53 2024 -0800
Release notes 5.1.5 (#2326)
commit 644cabaeab2e78bfa4d33effcc8ecd278cff7722
Author: Javad <v-jarahn@microsoft.com>
Date: Mon Jan 29 13:55:53 2024 -0800
removing pdb from nuget's ref folder (#2329)
commit 14d7292d9c22040be45a3d9e1f2c135ad013fc60
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Fri Jan 26 01:10:59 2024 +0000
Test | Fix test projects package dependencies (#2319)
commit 586cf04cf5ee9deaa5c5263ba8e15810840a5587
Author: H. Yeo <138053434+H-Yeo@users.noreply.github.com>
Date: Thu Jan 25 11:53:07 2024 -0800
Preview Release Notes 5.2.0-Preview5 (#2316)
commit 348738961a88421629308a012fe7c2c3216d9108
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Wed Jan 24 13:02:59 2024 -0800
Fix | Fix driver to not send expired token and refresh token first before sending it. (#2273)
commit 9347412583cbf7e25f84fcc9ab5995308224893f
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Wed Jan 24 18:56:24 2024 +0100
Update nuspec on .net 6.0 (#2317)
commit 7fd34dfeba9c864182d8e9d39830c4d1e1f1607c
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Wed Jan 24 08:47:53 2024 -0800
Enhance project and target files to generate debugging symbol package files (#2137)
commit c8b70f1aa0870d0a927a0142735405077ebb11ec
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Wed Jan 24 00:57:28 2024 +0100
Enhancement | Add explicit version for major .NET version dependencies (#2303)
commit 4ca71d901a0f5d21b47195e0044279c2ac71878c
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Tue Jan 23 17:44:57 2024 +0100
Revert "Perf | avoid boxing of SqlGuid in SqlBuffer (#2306)" (#2311)
This reverts commit 9602271e20a1983cf4f0edf3fb8e18d8538e112c.
commit 838b931809af6c6236a600d559a086cfe1e77593
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Fri Jan 19 23:44:26 2024 +0000
Fix | Invalid transaction exception against the connections and distributed transactions (#2301)
commit 9602271e20a1983cf4f0edf3fb8e18d8538e112c
Author: Evgeny Akhtimirov <evgeny@devduty.com>
Date: Fri Jan 19 18:43:41 2024 -0500
Perf | avoid boxing of SqlGuid in SqlBuffer (#2306)
commit b460fd098e94af6c12f3b3fdc9bb9dbe67fc2f10
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Fri Jan 19 03:01:28 2024 +0100
Fix | Add missing dependency update for netstandard2.0 (#2305)
fixes #2304
commit 900d051965a630aba0c42e61fe9b843a67570d3e
Author: panoskj <37297673+panoskj@users.noreply.github.com>
Date: Wed Jan 17 21:57:31 2024 +0200
Merge common code bases for TdsParserStateObject.cs (4) (#2254)
commit b12b15d6f61d99870e420c169e4a58711ebf9e0c
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Sat Jan 13 00:56:22 2024 +0100
Fix | Enable reading AE date as DateOnly (#2275)
commit 55aa1eeb620bcbd5f9c10f5305249af74ae3fac1
Author: H. Yeo <138053434+H-Yeo@users.noreply.github.com>
Date: Fri Jan 12 13:31:01 2024 -0800
Tests | Fix Tests regarding Concurrency both Sync and Async versions. (#2279)
commit eb68e1b52ac6acbce00d29b262ebd4d3140dd1e4
Author: Javad <v-jarahn@microsoft.com>
Date: Fri Jan 12 10:00:09 2024 -0800
Add | Adding net8 support (#2230)
commit 8663853b4df831f3b52cd14b9ba3f94c2b9cd260
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Fri Jan 12 17:28:04 2024 +0000
CVE | Version bump Microsoft.IdentityModel.JsonWebTokens to 6.35.0 (#2290)
commit 2e4d1b69793e7ca3d7d9f2bc85206b933808ef3c
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Tue Jan 9 21:58:25 2024 +0000
Fix | SQL auth method validation on debug (#2288)
commit 84720a74fa640cf9cea7967a3b74d0220d00961b
Merge: ee638d4f 5f00e1ce
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Tue Jan 9 19:30:41 2024 +0000
Merge in 'main' changes
commit ee638d4ffd5bcb542998b706c7ba183853a0077e
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Mon Jan 8 17:05:13 2024 +0000
Merged PR 4233: Release notes 3.1.5
Add note
commit 7cb40938b85cb3901f2c0e30c63da63ee531de1f
Author: Davoud <v-deshtehari@microsoft.com>
Date: Tue Jan 9 10:13:49 2024 -0800
Merged PR 4228: Address encryption downgrade issue
commit 5ed0717b46e5901194504a03025ca06cea75eb88
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Tue Jan 9 05:58:04 2024 +0000
Merged PR 4229: Certificate chain validation logic fix
Ports PR [#4047](https://dev.azure.com/SqlClientDrivers/ADO.Net/_git/dotnet-sqlclient/pullrequest/4047)
commit a1769cda2eac047f6a3a0042d754e6e14e9f8817
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Mon Jan 8 23:02:22 2024 +0000
Merged PR 4236: Release notes 5.1.4
commit ce6526ac9db7c8b14421b0ad1f56752f75df1d8d
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Mon Jan 8 18:55:13 2024 +0000
Merged PR 4230: Release notes 5.1.3
commit 665af6cabe6e3bf6be0db7973377a3bd201202a1
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Mon Jan 8 18:49:16 2024 +0000
Merged PR 4234: Release notes 2.1.7
add note
commit 81a54d8233f7edf6c060218e162335963bd94faa
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Mon Jan 8 18:48:59 2024 +0000
Merged PR 4232: Release notes 4.0.5
Add notes
commit 5f00e1ce77b17f548c658b19b31d60f5968f50d2
Author: Sanjam Panda <36253777+saitama951@users.noreply.github.com>
Date: Fri Jan 5 02:22:43 2024 +0530
gc collect fix for mono (#2277)
commit 5794ab3af5b58e66b2829a1355b692a73210ee9c
Author: Javad <v-jarahn@microsoft.com>
Date: Fri Dec 15 15:37:03 2023 -0800
Test | Updating xunit version (#2271)
commit 04b531bab5ad5c0bdf204d443b6f3da88c2429b9
Author: Javad <v-jarahn@microsoft.com>
Date: Tue Dec 12 09:02:50 2023 -0800
Release notes v5.2.0-preview4 (#2263)
commit 923cad7d303de222ba0aa3630fbedfac96a71e82
Author: Javad <v-jarahn@microsoft.com>
Date: Fri Dec 8 09:56:23 2023 -0800
Update | Adding ActiveDirectoryWorkloadIdentity to ref folder and soring the n… (#2264)
commit d18e5c1557c8bbe08b1a876cc137a6c207de5751
Author: Sanjam Panda <36253777+saitama951@users.noreply.github.com>
Date: Fri Dec 8 05:46:56 2023 +0530
Support For Big Endian Systems (#2170)
commit 59080c8e5eca0b3455aed362ec9ba913b59ef788
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Thu Dec 7 23:38:26 2023 +0000
Fix | Linux SPN port number using named instance and Kerberos authentication does not return port# (#2240)
commit 09c9588c760317a3115489c0c9875b951f02610e
Author: Javad <v-jarahn@microsoft.com>
Date: Thu Dec 7 14:10:04 2023 -0800
Change | Change Azure.Core in M.D.S.AE.AKV (#2261)
commit 17590d3c3f393d66717e0680fdb03fb09b0df409
Author: Will Sugarman <will.sugarman@gmail.com>
Date: Thu Dec 7 12:01:19 2023 -0800
Add | Add Workload Identity Support (#2159)
commit 4319661269be1fa15d7d2f819079b6840bfe11d3
Author: Javad <v-jarahn@microsoft.com>
Date: Wed Dec 6 14:08:32 2023 -0800
Change | Change SNI Version to v5.2.0-preview1 (#2257)
commit 420323799b60c3d7b058fcf944eb46d06fcf9a43
Author: David Engel <v-davidengel@microsoft.com>
Date: Wed Nov 29 17:44:48 2023 -0800
Fix | Don't validate server certificate when using Authentication option but not encrypting (#2224)
commit 1543998220fe81e372b484d48925c648c6a9b3c8
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Wed Nov 29 18:15:09 2023 +0000
Doc | Improve connect retry count for high demand endpoints on Azure (#2233)
commit 416afcdf5141d19716b9b94e8f3146998c29b538
Author: panoskj <37297673+panoskj@users.noreply.github.com>
Date: Tue Nov 28 22:13:37 2023 +0200
Merge common code bases for TdsParserStateObject.cs (3) (#2168)
commit e6109f8d60766bf9b9ed5e323f5bd50e221cb527
Author: Wraith <wraith2@gmail.com>
Date: Wed Nov 22 16:57:10 2023 +0000
SqlBatch: Add missing overrides and tests (#2223)
commit b02cf417a5e8a35bee3903d8b8229a25c61fb864
Author: Wraith <wraith2@gmail.com>
Date: Tue Nov 21 21:13:30 2023 +0000
cache all appcontext switches (#2227)
commit 4f7335550ef1c54910575855d199373ce2ee0a44
Author: David Engel <v-davidengel@microsoft.com>
Date: Thu Nov 16 15:33:05 2023 -0800
Test Fix | CertificateTests are only designed to run against localhost SQL installs (#2219)
commit d30d9d107eca0f11b735a550aa187e57167858c9
Author: Wraith <wraith2@gmail.com>
Date: Thu Nov 9 18:47:44 2023 +0000
Add | Feature: SqlBatch api (#1825)
commit 7f203dd03875d1167425dcc92619c143e41f9e59
Author: Wraith <wraith2@gmail.com>
Date: Tue Nov 7 20:01:46 2023 +0000
Remove duplicated ForceColumnEncryption property check (#2166)
commit b3110be60d18e358ad23fa40e9ba9f952aadbca0
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Mon Nov 6 12:39:55 2023 -0800
Test | Fix HNIC tests to support named instance sql servers (#2205)
commit 6456d71414347238d4bd519dbfdf1d936ca4cea6
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Tue Oct 31 22:40:24 2023 +0000
[3.1.4] Release notes (#2200)
commit d5df671376b3114e8f7adc570b95073b796b6e16
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Tue Oct 31 11:20:17 2023 -0700
Fix | Fixing issue for SQL named Instances in Managed SNI using named pipes. (#2142)
commit 5a4feed431149802c8497c2a720b1b721adbfba6
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Mon Oct 30 20:02:40 2023 +0000
[4.0.4] Release notes (#2199)
commit e719601a69070ca0f94f44b3345936603380826f
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Thu Oct 26 17:50:21 2023 +0000
[5.1.2] Release notes (#2197)
commit 6beab6a69477959429f3f5905ca17c286b777113
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Wed Oct 25 01:09:32 2023 +0000
Fix | Support Georgian collation (#2194)
commit b86ddf19f992b8c5e6a0ff1b4b43ed37d31b19bf
Author: Wraith <wraith2@gmail.com>
Date: Wed Oct 25 02:07:19 2023 +0100
move PacketData and list management to shared and reimplement as doubly linked list. (#2164)
commit 57d287c1ca0a4750b7421bc7a2a70b09ac71ca05
Author: Javad <v-jarahn@microsoft.com>
Date: Mon Oct 23 14:39:55 2023 -0700
Test | Removing internal build of XunitExtensions and using the nuget (#2033)
commit 97863e59ad613ba275912bc93f1aef34f0ee0014
Author: Javad <v-jarahn@microsoft.com>
Date: Mon Oct 23 10:46:15 2023 -0700
Fix | Upgrade dependencies versions (#2189)
commit b7167c02255a4785a400037f89060b3d275c53d3
Author: Daniel Marbach <daniel.marbach@openplace.net>
Date: Fri Oct 20 19:59:52 2023 +0000
Ports Fix deadlock in transaction (#1242) to .NET (#2161)
commit 85ba241aaa0750089c1409a98220d88ef3e14146
Author: Viktor Hofer <viktor.hofer@microsoft.com>
Date: Fri Oct 20 19:43:30 2023 +0200
Remove stale dependencies from SqlClient (#2186)
commit 55eb1305bdf958767611b9a506d4ac4b94b8bb63
Author: JJ <103335846+computerscienceiscool@users.noreply.github.com>
Date: Thu Oct 19 14:56:28 2023 -0700
Update README.md (#2185)
Removed a double word
commit 9e0d8b7095e051a6146904ed34738fb3497ceb62
Author: Wraith <wraith2@gmail.com>
Date: Wed Sep 27 05:10:00 2023 +0100
deprioritize altmetadata and altrow tokens and annotate them as deprecated (#2165)
commit 111033e65625c435295cea500508a13e00a3d764
Author: Wraith <wraith2@gmail.com>
Date: Wed Sep 20 19:18:19 2023 +0100
move stateObj snapshot to a new class in shared (#2157)
commit c1984b822f8d31794cd8c85245cc6d7bd1059526
Author: David Engel <v-davidengel@microsoft.com>
Date: Fri Sep 15 14:14:15 2023 -0700
Doc | Move attestation protocol remark to the correct place (#2153)
commit cc5f05a8e18d188bfa49adb51f6df2e4f5533e48
Author: Wraith <wraith2@gmail.com>
Date: Fri Sep 15 17:31:18 2023 +0100
Merge TDSParserStateObject.StateSnapshot state flags (#2132)
commit 816a7d3dc8ae2f9c6a691d133723a73b54e5e628
Author: Javad <v-jarahn@microsoft.com>
Date: Thu Sep 14 12:36:32 2023 -0700
SDL | Changing ReadXml to a more secure overload. (#2147)
commit 7b2e2fc9f002e8b270894595f5f92670670053d7
Author: Javad <v-jarahn@microsoft.com>
Date: Wed Sep 13 11:24:06 2023 -0700
Test | Fixing MARS manual tests on some debug field's names and some minor changes (#…
vadymkutsenko
added a commit
to rabotaua/SqlClient
that referenced
this pull request
Oct 11, 2024
commit 2f0de19396721dd10ca8587c73ba1e1347d444a5
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Fri Oct 11 02:13:34 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit 88086308fc36c1e570f230e4e1a83303461857c8
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Wed Oct 9 06:13:20 2024 +0100
Merged DbConnectionPool (#2812)
commit 40206cd514bb5eed80fca84ff2934fc1aac17a4c
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Wed Oct 9 05:22:04 2024 +0100
Enrol GetSchema commands into current transaction (#2876)
commit 2a015d2197177791bac2d454ed5dc27d08af9ae2
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Wed Oct 9 05:21:49 2024 +0100
Allow errors with negative numbers to be considered transient (#2896)
commit bfb2579e3e59e2a7d3d229104bc151eaa3b997ee
Author: David Engel <davidengel@microsoft.com>
Date: Tue Oct 8 21:21:04 2024 -0700
CertificateTests are broken (#2805)
commit a852709376e34f7bbeb2c3942795dc7c04d831ce
Author: David Engel <davidengel@microsoft.com>
Date: Tue Oct 8 21:18:41 2024 -0700
Retry Build Ext Utilities and Nuget Restore on failure (#2906)
commit 467701e0bb6786e7bd7fd49b8e14db2003162ac1
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Tue Oct 8 21:57:04 2024 +0100
Merge SqlColumnEncryptionEnclaveProvider, SqlColumnEncryptionCspProvider, SqlColumnEncryptionCngProvider (#2501)
Thanks @edwardneal !
* Merged SqlColumnEncryptionEnclaveProvider.NetCoreApp.cs
* Merged SqlColumnEncryptionEnclaveProvider
* Merged SqlColumnEncryptionCspProvider
* Merged SqlColumnEncryptionCngProvider
* Corrected project files post-merge
commit 9b9bdc1c0348d272fab1d2a6586beb482c7fc5b6
Author: Benjamin Russell <russellben@microsoft.com>
Date: Tue Oct 8 13:51:33 2024 -0500
Cleanup | Flatten Interop Folders (#2900)
* Remove the extra src folder in interop, etc.
* Move netfx common files out of src folder
* Fixing a couple file includes
* Delete files that weren't part of the project
commit b0433f019fa0daeba141aa7e6548a0c72be20b38
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Tue Oct 8 17:49:56 2024 +0100
Merge AAsyncCallContext, cleanup for SqlDataReader merge (#2383)
Thanks again to @edwardneal !
* Merged AAsyncCallContext.
Also changed netfx SqlDataReader to use the common class hierarchy, and made whitespace changes to SqlDataReader to make the netcore/netfx diff slightly shorter
* Expanding use of CallerMemberName in SqlDataReader
* Adjusted comments and variable names, added conditional compilation blocks.
These aren't functional changes, but they do pare down the diff between netcore and netfx.
Also sealed the Snapshot class in both codebases for performance improvements.
* Reverted change to ObjectID following compilation and testing
* Corrected a failing manual test
* Further post-merge changes
Keeps SqlDataReader in sync with main
* Code review comments
Also one AlwaysEncrypted sync/bugfix in SqlDataReader from netfx to netcore
* Corrected conditional compilation directive
commit ca9272d1eb1db843119ef120ff02f7067b0f4e4a
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Mon Oct 7 21:26:27 2024 +0100
Add test coverage for PR 2873 (#2897)
commit 7a7b247aa66c5eafb5a39f750d819084b1d551a9
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Mon Oct 7 19:54:17 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit 76338d3800ed7c906e00220294e8b353c0bb5735
Author: Benjamin Russell <russellben@microsoft.com>
Date: Mon Oct 7 11:14:59 2024 -0500
Merge | Bring netcore Interop to Common Project (#2893)
* Move ntdll interop files from netcore to common folder
* Moving enough interop files into the common project to enable SqlFileStream migration
* Move Interop.FileTypes and Interop.SetThreadErrorMode into common interop folder.
* Move Interop.IoControlCodeAccess
* Moving Interop.Libraries into the common project
* Removing files that were moved
commit 9433389ebba4528a192abaa386dea97da202d166
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Mon Oct 7 17:01:01 2024 +0100
Removed references to CTAIP and client certificate authentication (#2831)
commit 4e118ae2b792a51a9866a94ad5cbf198fee9bba7
Author: Maxim Markelow <markelow.dev@gmail.com>
Date: Mon Oct 7 18:56:46 2024 +0300
Fixed incorrect string format at event tracing when OutOfMemory exception thrown (#2797)
commit c0ae757809fa43441832d6ac220bb310e5102cc2
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Sat Oct 5 08:36:52 2024 +0100
Merge AlwaysEncryptedHelperClasses, TdsParserHelperClasses (#2376)
commit 32b5a67fe6b95a4e15ace8fae7a20e6db6421136
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Sat Oct 5 08:30:43 2024 +0100
Removed unreferenced/unused code (#2814)
commit d3772fcb8c9fb48cad577abce1f3f6474d97da48
Author: Javad Rahnama <j.rahnama79@gmail.com>
Date: Sat Oct 5 00:28:23 2024 -0700
Fix | Increase routing attempt to 10 in netcore for LoginNoFailover and adding routing support to LoginWithFailover (#2873)
commit cab54224419ae81c30f05eb2ea3aebc154ca99be
Author: Benjamin Russell <russellben@microsoft.com>
Date: Tue Oct 1 11:32:12 2024 -0500
Project for Common Files (#2887)
* Project file for common files. Not built in any configuration.
* Removing root namespace to prevent warnings for wrong namespace.
commit 72951f45468e0944db64440f15718b7d3094ede8
Author: Deepak Saini <deepaksaini@microsoft.com>
Date: Tue Oct 1 19:59:23 2024 +0530
Fix SqlDataReader.IsDBNull() for json (#2892)
commit cc58d7923952a8b2e9e397490dca2b08f7f3ce80
Author: Deepak Saini <deepaksaini@microsoft.com>
Date: Tue Oct 1 00:42:28 2024 +0530
Enhancement tasks for json support (#2891)
* some enhancements tasks for json support
* added some missing drop table funtion
* remove unique naming for tables and SPs
commit 0266b4a2209f732ead650181ae924a74a0c4cf40
Author: Deepak Saini <deepaksaini@microsoft.com>
Date: Sun Sep 29 01:38:33 2024 +0530
Adding SqlJson and Data write with SqlJson (#2752) (#2880)
* Adding SqlJson and Data write with SqlJson (#2752)
* Adding the SqlJson type
Remove unused
Adding all the json tests
Revert "Remove unused"
This reverts commit c448b6e2e810630d217826e73a644f7f9815d366.
Remove unused
* Change to static
* Adding the SqlJson support
* Adding the assert for column encryption
* Adding the support for Json writes
* Adding more support
* Enabling the following
SqlString sqlString = reader.GetSqlString(0);
Assert.NotNull(sqlString.Value);
var sqlJson = reader.GetSqlJson(0);
Assert.NotNull(sqlJson);
string fieldval = reader.GetFieldValue<string>(0);
Assert.NotNull(fieldval);
JsonDocument jsondoc = reader.GetFieldValue<JsonDocument>(0);
Assert.NotNull(jsondoc);
* Revert "Enabling the following"
This reverts commit 6739e455b62c88a56100552072eea368d05e23ea.
* ref update for SqlJson
* resolve PR comments
---------
Co-authored-by: Saurabh Singh <1623701+saurabh500@users.noreply.github.com>
commit 4806059d1d2a40f00c2f9adfc2d9d4f0f3a02eae
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Fri Sep 27 12:42:57 2024 -0700
Fix | Addressing documentation issues along with spelling errors (#2889)
commit 6064d026858fc2585e81bda5600ac60388be75ea
Author: Apoorv Deshmukh <apdeshmukh@microsoft.com>
Date: Fri Sep 27 09:52:33 2024 +0530
Add streaming support for JSON (#2882)
This commit adds support for streaming JSON data to and from Sql Server.
JsonStreamTest has been added to demonstrate this functionality.
commit ed0a132d365611afaf114ab2281e71c402e32f37
Author: Benjamin Russell <russellben@microsoft.com>
Date: Tue Sep 24 18:01:51 2024 -0500
Fix build breaks (#2885)
commit 135120af6556ca0151cd834450e54751d0f6e84f
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Tue Sep 24 16:51:55 2024 +0100
XML documentation corrections - batch 1 (#2836)
Thanks @edwardneal!
* Rollup of feedback from Batch 1 PR
* Respond to code review
Also expanded SqlBatch corrections to code files and other instances in the XML documentation.
commit c690120925476280542e38a28c7d3b1be8478455
Author: Benjamin Russell <russellben@microsoft.com>
Date: Mon Sep 23 11:22:31 2024 -0500
XML Documentation Fixes - Batch 7 (#2869)
* Batch 7 w/o testing
* Spot checking!
* Fixing build issue
commit 3d9c1e4178034cc1c709ad18832b056fc1c380a2
Author: Benjamin Russell <russellben@microsoft.com>
Date: Mon Sep 23 11:22:07 2024 -0500
XML Documentation Fixes - Batch 8 (#2871)
* Batch 8.1
* Batch 8.2
* Batch 8.3
* Batch 8.4?
* Checking things over
commit cb11317441e091d9ad40ad8f6e738831f252476c
Author: Benjamin Russell <russellben@microsoft.com>
Date: Fri Sep 20 16:54:30 2024 -0500
XML Documentation Fixes - Batch 5 (#2864)
* Batch 5 part 1
* Batch 5 part 2
* Finishing up changes to batch 5
* PR Comments
commit bc08543c1d3380b1ef6cac7e27761ce568cfb010
Author: Deepak Saini <deepaksaini@microsoft.com>
Date: Fri Sep 20 11:58:08 2024 +0530
Implement read and write functionality for JSON (#2829)
* Implement read and write functionality for JSON col (#2722)
* Implement read functionality for JSON col
* Remove SqlJson class
* Implement JSON write functionality
* Remove code comment for new datatypes
* Json read and write tests (#2744)
* Json read and write tests
* added sp tests
* remove AppContext Switch
* resolve some PR comments
* refactored tests
* add async testing
* fix build errors
* Ref update for SqlDbTypeExtensions (#2745)
* resolve PR comments
* Apply suggestions from code review
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
---------
Co-authored-by: Apoorv Deshmukh <apdeshmukh@microsoft.com>
Co-authored-by: Saurabh Singh <1623701+saurabh500@users.noreply.github.com>
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
commit 95cd389878cc8f9f638eafff9e7f64be577c36d2
Author: Benjamin Russell <russellben@microsoft.com>
Date: Thu Sep 19 13:06:45 2024 -0500
XML Documentation Fixes - Batch 6 (#2865)
* Batch 6 part 1
* Finishing up batch 6
commit 3416ad92b9107d2618bc7ffdf1d595a86cf0e7d0
Author: Benjamin Russell <russellben@microsoft.com>
Date: Thu Sep 19 12:26:42 2024 -0500
XML Documentation Fixes - Batch 4 (#2863)
* Batch 4
* Touching up and fixing mistakes
* Tabs to spaces
* Using new sample file
commit cdc33d91a64308e4861844da755ffbe9a407cc1c
Author: David Engel <davidengel@microsoft.com>
Date: Mon Sep 16 11:19:18 2024 -0700
Sync sample changes into snippet doc (#2837)
commit 68a5be4eee9224c9c6007398e952d1f7f02c2570
Author: Benjamin Russell <russellben@microsoft.com>
Date: Mon Sep 16 11:49:04 2024 -0500
XML Documentation Fixes - Batch 3 (#2851)
* Batch 3
* Fixing issue from last PR
* Making sure everything is ready for PR (left off at sqlcommand.xml)
* Finishing up work for batch 3
* PR comments
commit 321080e2b25b39e42b3aadc325610a96654c298b
Author: dauinsight <145612907+dauinsight@users.noreply.github.com>
Date: Fri Sep 13 10:57:12 2024 -0700
Update CDP_BUILD_TYPE condition in AKV provider (#2854)
commit 764add38972945f5212c9cc5cf346c493c310187
Author: Benjamin Russell <russellben@microsoft.com>
Date: Thu Sep 12 12:53:43 2024 -0500
XML Documentation Fix - Batch #2 (#2834)
* Batch #2
* Reverting removal of the snippet files.
* Fixing build break caused by parameter not having a comment.
* These changes should fix the broken comments
commit b1d3a8297a8d7d3b62e35cb87924feb90afa4cb3
Author: Malcolm Daigle <mdaigle@microsoft.com>
Date: Tue Sep 10 11:01:37 2024 -0700
Port double clean fix to netfx (#2843)
commit 069c052922c7183ec66f39904bfaf77fa2622c1f
Merge: db64574c eb4c0f04
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Mon Sep 9 23:01:05 2024 +0000
Merge in 'main' changes
commit db64574c63daff25026000d9c84e3b3822b11263
Merge: f8f2a964 8412215e
Author: Daniel Au <v-audaniel@microsoft.com>
Date: Mon Sep 9 21:16:08 2024 +0000
Merged PR 4909: eng | Fix strong name in AKV provider
Bug fix to address the missing strong name in the Azure Key Vault (AKV) provider.
This pull request fixes the strong name issue in the AKV provider for various .NET frameworks.
- `Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj`: Added strong name generation configurations.
- `build-all-configurations-signed-dlls-step.yml`: Updated MSBuild arguments to use `SigningKeyPath`.
- `code-analyze-step.yml`: Updated MSBuild command line to include `SigningKeyPath`.
Related work items: #31596
commit eb4c0f043bff30c7f3bb58704b41c73faef9d63b
Author: Malcolm Daigle <mdaigle@microsoft.com>
Date: Mon Sep 9 11:04:55 2024 -0700
Advance column index to avoid double clean. (#2825)
commit 8412215e9f8231bb10e4ef8ba98d113450025aaa
Author: dauinsight <v-audaniel@microsoft.com>
Date: Mon Sep 9 08:39:32 2024 -0700
Simplify assembly key file condition
commit 62af3b51318ebba36327aa61b014264fd57a4130
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Fri Sep 6 11:16:27 2024 -0700
Fix | Adding readme to nuget package (#2826)
commit cf92a05fd5ba458c1001dcd4af1b5bfba93dde66
Author: David Engel <davidengel@microsoft.com>
Date: Thu Sep 5 11:30:55 2024 -0700
Sample code improvements around token caching (#2821)
commit 5dc7b06e16705f6dcb8a0f437b28cd320ee2a719
Author: Benjamin Russell <russellben@microsoft.com>
Date: Thu Sep 5 13:06:13 2024 -0500
Reverting removal of the snippet files. (#2835)
commit 77b2c7aae21a4953c816d5426513471dccb8370b
Author: dauinsight <v-audaniel@microsoft.com>
Date: Thu Sep 5 10:21:05 2024 -0700
Remove sign assembly from AKV build command
commit b6a28f7f9b65a36af41533a44b4d4fb7bf0c1c65
Author: Benjamin Russell <russellben@microsoft.com>
Date: Thu Sep 5 10:56:20 2024 -0500
XML Documentation Fix - Batch 1 (#2822)
* Batch 1 of fixing xml files
* Removing CDATA blocks, fixing cref links
* Fixing a couple more issues
commit dbe09f1152f448ec7b6037579d9bcbf98b016fce
Author: dauinsight <v-audaniel@microsoft.com>
Date: Wed Sep 4 14:34:17 2024 -0700
Update AKV strong name
commit d89372af4153ec41f320b912748e032b160160c9
Author: Deepak Saini <deepaksaini@microsoft.com>
Date: Sat Aug 31 04:04:13 2024 +0530
Add Feature Extension for Json Support (#2773)
* Add Feature Extension for Json Support (#2696)
* change json hexa code and fix invalid login error
* Change name to match other naming conventions
* process JSONSUpport acknowledgement
* Fix naming conventions
* Processing 2nd byte from server
* Changes for netfx
* Json support feature ack in Test TDS server
* Remove enabled flag
* address PR comments
* Enable JSON only in debug bits
* Enable json tests in debug mode only
* resolve PR comments
---------
Co-authored-by: saurabh500 <1623701+saurabh500@users.noreply.github.com>
commit 8ff48a707ca0db95a18449c108a37e073f04b640
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Fri Aug 30 10:39:34 2024 -0700
Update README file (#2809)
commit aa0db93336511390b9e389123f25a5ae74e55c62
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Thu Aug 29 17:59:42 2024 +0000
Test | Fix Unit Tests for GetSqlServerSPN (#2442)
commit 9573da26fbab3de0ab75110f769b3c5b2f55199a
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Wed Aug 28 10:51:41 2024 -0700
Doc | Release notes v6.0 preview1 (#2813)
commit 5ea0e25d68b18e14e4446bd783fb91c4bc7cdf19
Author: David Engel <davidengel@microsoft.com>
Date: Tue Aug 27 16:24:24 2024 -0700
Add porting information about NLS to ICU .NET 5+ change (#2820)
commit c223dfb9c301812a4a73cad80d9f3c15d58c6a9b
Author: dauinsight <145612907+dauinsight@users.noreply.github.com>
Date: Tue Aug 27 15:48:48 2024 -0700
Hotfix v5.2.2 Release notes (#2770)
commit 12d5391686bb2795670d749a97b563e2da4f84d4
Author: dauinsight <145612907+dauinsight@users.noreply.github.com>
Date: Tue Aug 27 14:56:09 2024 -0700
Hotfix v5.1.6 Release notes (#2769)
commit f8f2a96403e99c008f5beb3a56e43f554af24db1
Merge: b50c074d bea3e67f
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Tue Aug 27 19:07:19 2024 +0000
Merge in 'main' changes
commit b50c074d9bb5cb5e19b0256bbe4f848b92d06f9f
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Tue Aug 27 17:33:34 2024 +0000
Merged PR 4888: eng | Fix package validation stage against the preview
commit bea3e67f3ee2b7f12cc3547455868c084a5d9e40
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Tue Aug 27 00:37:42 2024 +0100
Merged DbConnectionClosed, DbConnectionFactory, SqlAuthenticationProviderManager (#2410)
commit 71deba6427dbb4d50c4329508de827e2fd0ef15e
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Mon Aug 26 12:41:19 2024 -0700
Refine version.props and nuspec files (#2811)
commit 50767d79069226816b8b3367fae6db4c375a48ea
Author: dauinsight <145612907+dauinsight@users.noreply.github.com>
Date: Fri Aug 23 09:01:12 2024 -0700
Hotfix v4.0.6 Release notes (#2768)
commit 6d33e9d20e95f5f8d8eebe7db1458f88ca4dbd78
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Wed Aug 21 23:34:00 2024 +0100
Merged PoolWaitHandles, DbConnectionPoolIdentity, removed DbBuffer (#2390)
commit 85b9407e4ee699b3229c5bb1629f4219e52fdf74
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Aug 21 15:14:16 2024 -0700
Eng | Add strong name validation to package validator (#2802)
commit cc144a8a1c383106264cf348c5f889bd051d7463
Author: dauinsight <145612907+dauinsight@users.noreply.github.com>
Date: Wed Aug 21 15:10:58 2024 -0700
Hotfix v3.1.7 Release notes (#2800)
* Add release notes for 3.1.7
commit ef8d6cc6629395801aeca5a53571cdbd1b84fb5e
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Mon Aug 19 18:04:46 2024 -0700
Doc | Reorder release notes (#2791)
commit 4eafe1f7715ae00c94d898a583d0e6f9e9b75779
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Mon Aug 19 16:27:33 2024 +0000
Merged PR 4847: eng | Add support preview on MDS
commit ac1012a6b7ddaf0b14526ced7cea8c16e0791b23
Author: dauinsight <145612907+dauinsight@users.noreply.github.com>
Date: Fri Aug 16 13:22:55 2024 -0700
Hotfix v3.1.6 Release notes (#2767)
commit 619fa749551ed0d9e387d75cb3e6d85fe00a3df4
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Thu Aug 15 13:48:15 2024 -0700
Fix | Fix the issue with Socke.Connect in managed SNI (#2777)
commit d3658edfcda0d7eecabc09afb5459bb3f79e6290
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Wed Aug 14 17:18:51 2024 -0700
Update SNI version to 6.0.0-preview1.24226.4 (#2772)
commit 7216e84fb9819b56df1d51ca13969d4f89bf507a
Author: Benjamin Russell <russellben@microsoft.com>
Date: Fri Aug 9 12:40:30 2024 -0500
`null != x` => `x != null` (#2751)
commit 6fbbb787cd7ea35c06e292bb83d01ae94900b0bf
Author: Benjamin Russell <russellben@microsoft.com>
Date: Sat Aug 3 11:47:53 2024 -0500
Code Cleanup | `null == x` to `x == null` (#2749)
- With one approval and CI success, I think that's enough to move ahead on this one.
* `null == x` to `x == null`
* Update src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Co-authored-by: David Engel <dengel1012@gmail.com>
---------
Co-authored-by: David Engel <dengel1012@gmail.com>
commit 6f177e30f2a8bbd59a7ec093ef934e29e0578004
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Tue Jul 30 19:52:38 2024 +0000
Fix | Fixed some Azure managed identity authentication unit test failures (#2652)
commit 85956440bb0886c59dfa31475b9a6f5c510e3ac0
Author: Benjamin Russell <russellben@microsoft.com>
Date: Mon Jul 29 16:05:41 2024 -0500
Replace unused out arguments with discards (#2726)
* Replace unused out arguments with discards
* Removing unnecessary types in discarded out arguments
commit 0c4519871c9b69f7e05fe90f59d224d5f9ab3e3e
Author: Cédric Luthi <cedric.luthi@gmail.com>
Date: Sat Jul 27 05:30:08 2024 +0700
Avoid "early" access to SqlAuthenticationProviderManager.Instance (#2636)
commit 38ce399a77115a6f95fbe8ef54ee300aac58370b
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Fri Jul 26 11:33:47 2024 -0700
FIX | Revert the change to TargetFrameworkMonikerAssemblyAttributesPath from PR #2497 (#2725)
commit 04d610211027be0ea70eb2c1e55c24ffa3a5704f
Merge: 9e3bbacc 9d8062f1
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Thu Jul 25 07:29:05 2024 +0000
Merge in 'main' changes
commit 9e3bbaccc448d708a0d1ff96032f890c9a2045b6
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Wed Jul 24 21:23:40 2024 +0000
Merged PR 4782: eng | Secure symbols publishing
commit 9d8062f135d9b0491668eb40af5b7caeda2df5f2
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Jul 24 14:18:17 2024 -0700
Minor adjustment to sourcelink translation (#2713)
commit 1152fcf0c628ee84862779d86b9348376f64f4a8
Merge: f7313f81 c4fa6827
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Wed Jul 24 00:45:12 2024 +0000
Merge in 'main' changes
commit f7313f81542228f5fea1c974e5fda12bb4d5e2c0
Merge: be5fba23 e3cf4149
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Tue Jul 23 23:46:13 2024 +0000
Merge in 'main' changes
commit c4fa682749110f030d4f43caa488ec4832e04df1
Author: Wraith <wraith2@gmail.com>
Date: Wed Jul 24 00:46:09 2024 +0100
Change internal read functions to return TdsOperationResult (#2690)
commit e3cf4149a202218919fb9b83e275765aa908a40b
Author: David Engel <davidengel@microsoft.com>
Date: Tue Jul 23 10:38:25 2024 -0700
Fix macOS CI (#2699)
commit 79adbc23e786c1b07d3995d5e6717700324555ad
Author: Saurabh Singh <1623701+saurabh500@users.noreply.github.com>
Date: Tue Jul 23 06:29:52 2024 -0700
Adding the SqlDbTypeExtensions (#2688)
commit cf8cc22ae7c4e22764d8561e99cc3dbaa2325a78
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Tue Jul 23 02:09:52 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit 56c07c627e75fa8a9531b76d02ec8e0113ff3e08
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Mon Jul 22 13:59:01 2024 -0700
2698)
commit 3d7896ff7f656e35d987ce43bc1cb91d95eac5ae
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Mon Jul 22 11:28:25 2024 -0700
set DisableSourceLinkTranslation to false (#2691)
commit 7110d29922e402a722ec5bc32fdc8f7bcdf596a4
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Mon Jul 22 02:09:38 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit a9621bdc411002f15adba0c849a4ccfbfa210707
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Sun Jul 21 02:17:48 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit be5fba235947f2712df3267ccf3654cede5be4f6
Merge: aa0a39be e2273713
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Thu Jul 18 21:48:11 2024 +0000
Merge in 'main' changes
commit e22737137ad2d7387c452af79d6c95ef9f6549d0
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Thu Jul 18 14:47:08 2024 -0700
eng | Add Delay sign to ref csprojs (#2684)
commit aa0a39be63d7240ec3eac315eadd0aba9d3230ad
Merge: 49e4da77 5c0ce12d
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Tue Jul 16 00:39:23 2024 +0000
Merge in 'main' changes
commit 5c0ce12d19972824f0e6b118812de916a6e90c49
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Fri Jul 12 19:00:13 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit 766b72a752a8df9670e273012b6a6b3718baee80
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Thu Jul 11 10:53:48 2024 -0700
Fix | Fix decrypt failure to drain data (#2618)
commit 784046fdbf02e97fb7190542e81ba20d93843261
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Thu Jul 11 10:42:56 2024 -0700
eng | Initial YAML CI pipeline (#2575)
commit ce7393b4d12dbd35c0b4ad61acbfc1f14a4edc8e
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Jul 10 11:34:17 2024 -0700
eng | Add delay signed to official builds (#2653)
commit a34ec48fb8b4cabbe349ef8019a0a885d3aefab1
Author: David Engel <davidengel@microsoft.com>
Date: Mon Jul 8 12:44:40 2024 -0700
Fix - Don't error when using infinte connect timeout and Entra auth (#2651)
commit bad621f7c141079c77574f1eb5b929ed195921a8
Author: David Engel <v-davidengel@microsoft.com>
Date: Fri Jul 5 10:32:31 2024 -0700
Test fixes to accommodate recent infra changes (#2646)
* Test fixes to accomodate recent infra changes
commit 0352a50f779b7977d87714c1934d1f21ea231b6d
Author: Benjamin Russell <russellben@microsoft.com>
Date: Tue Jul 2 17:36:55 2024 -0500
3 Small Changes (#2594)
* * Port sqlclientx datasource changes
* Remove link to missing nuget.config file
* Remove root namespaces from sqlclient csproj files
* Test to see if namespace changes are breaking the pr build
* Reinstate removing the root namespace and fix resource filename generation
commit f55c5a2065f947942d11c52f2a62a349419278cb
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Thu Jun 27 16:34:57 2024 +0000
Merged common code base for AlwaysEncryptedKeyConverter (#2538)
* Merged AlwaysEncryptedKeyConverter.CrossPlatform and AlwaysEncryptedKeyConverter.Cng.
commit aece3669a9ae47145d9d68e91c47119079ba7cf8
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Thu Jun 27 14:53:48 2024 +0200
Add test for issue 2456 (#2457)
commit f91dc82ca52957ee1bc3d4f233a6e950a8a8dcbb
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Wed Jun 26 22:06:33 2024 +0200
Change | Remove some unneeded references and update Azure.Identity (#2577)
commit eb46c58805e562a59c1f8d9fb2338645e1a39b05
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Wed Jun 26 16:29:52 2024 +0200
Add | No-op if engineedition is 6 or 11 due to lack of support for ASSEMBLYPROPERTY function (#2593)
commit 8777fceef974e95697728f9889e6ce734add759d
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Tue Jun 25 13:58:15 2024 +0100
Merge SqlColumnEncryptionCertificateStoreProvider (#2521)
commit 49e4da777e33d81e4b7c551bd007a240f28207cb
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Fri Jun 21 21:48:23 2024 +0000
Merged PR 4673: eng | Upgrade ESRP to v5.0
- [Sample run](https://dev.azure.com/SqlClientDrivers/ADO.Net/_build/results?buildId=91327&view=results)
Related work items: #30897
commit 55f48c57a9b2a200c266b8739a2a477f974ab41d
Merge: 1dfd4833 d4b2bb32
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Wed Jun 12 21:30:06 2024 +0000
Merge in 'main' changes
commit d4b2bb32ac2ab2f9ecd12c441733f8d179bf255d
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Jun 12 14:28:37 2024 -0700
Addressing conflict (#2560)
commit a240c2432614c156f0f81b9beb7994f2d35ebc52
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Jun 12 13:15:39 2024 -0700
Address conflicts (#2562)
commit d7f84eb09dd8e70ac73f190f913e1dd1a9641138
Author: David Engel <v-davidengel@microsoft.com>
Date: Wed Jun 12 12:11:41 2024 -0700
Add scope trace for GenerateSspiClientContext (#2497)
commit c822b6917da7e38445777869acdaf13634a826f8
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Wed Jun 12 17:16:35 2024 +0000
Merged common code base for SqlUtil.cs (#2533)
commit 080e66950d9d0b6d113c8eae3a2056372159f258
Author: David Engel <v-davidengel@microsoft.com>
Date: Wed Jun 12 09:20:14 2024 -0700
Add | Cache TokenCredential objects to take advantage of token caching (#2380)
commit a7405ded70a0139a41e97c2ace76977b3a5260a4
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Tue Jun 11 14:53:27 2024 -0700
Add | Add SourceLink translation (#2552)
commit 689cc257fa250d42728c5d240b888b1f151cfd7c
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Tue Jun 11 21:05:07 2024 +0000
Fix | Replaced System.Runtime.Caching with Microsoft.Extensions.Caching.Memory (#2493)
commit ffd8771a599f90557facdebd983cd4e60dbb6f83
Author: Wraith <wraith2@gmail.com>
Date: Tue Jun 11 21:46:23 2024 +0100
Strong typed diagnostics (#2226)
commit 3f0c4b1a706136e417efa3a49bc168342470513e
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Tue Jun 11 19:14:48 2024 +0000
Fix | Fixed GenerateSspiClientContext to retry negotiation with default port (#2559)
commit f7ab11591d6fe736f26e1d21756e29e2a2d259d2
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Sat Jun 8 10:44:31 2024 -0700
Fix | Adjust path for .AssemblyAttributes in obj folder (#2550)
commit 1dfd48333c30d031f2f96cd0a40dcf0954cd0ba4
Author: Daniel Au <v-audaniel@microsoft.com>
Date: Fri May 31 22:36:06 2024 +0000
Merged PR 4621: eng | Fix policheck
commit 348ae2ee13ddccd64fe5fe4220ff22ba04ef9a4b
Author: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Date: Fri May 31 17:07:36 2024 -0500
Improve AccessTokenCallback sample code (#2543)
commit 42e9f08f91a3e1a1602d6b632df00f89abe04760
Author: dauinsight <145612907+dauinsight@users.noreply.github.com>
Date: Fri May 31 14:57:21 2024 -0700
Hotfix v5.2.1 Release notes (#2534)
commit 7af2438ee177738131c6b13dc37743a2dafe6910
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Thu May 30 12:11:53 2024 -0700
Fix | Enhance certificate validation (#2487)
commit 808d4c3b5a935e6954c96ce02d99c53b624099dc
Author: Benjamin Russell <russellben@microsoft.com>
Date: Wed May 29 18:45:55 2024 -0500
Change | Separate tests for NetFx and NetCore - NetFx-Only Connection String Properties (#2466)
* Adding TransparentNetworkIpResolution to list of unsupported on platform connection string error messages
Splitting unit test for netfx-only connection string properties such that test does not fail on netcore
* Remove DeprecatedSynonymCount since referencing the unsupported array is not possible
commit 815e5ab19e9e096bc52f13a82170aa1c5e641826
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Tue May 28 09:37:31 2024 -0700
Doc | Fix SNI dependencies of 5.1 and 5.2 release notes (#2537)
commit 4c088eb47c80209ed4506237b201a276f552f5bf
Author: Aris Rellegue <v-arellegue@microsoft.com>
Date: Fri May 24 20:05:54 2024 +0000
Merged PR 4583: eng | Fix policheck errors.
Fix policheck errors.
Sample pipeline run which did not have policheck errors:
https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=88114&view=sariftools.scans.build-tab
Related work items: #30279
commit b7c4007d0deb2c2ffa8281f7f731a59f42a5fce1
Author: David Engel <v-davidengel@microsoft.com>
Date: Fri May 24 10:21:39 2024 -0700
Enhancement | Add trace logs for packet size (#2522)
commit b178ba5d324cfc77a4ff68cf7c250895f766dbeb
Author: David Engel <v-davidengel@microsoft.com>
Date: Thu May 23 12:10:21 2024 -0700
Fix | Clone of SqlConnection should include AccessTokenCallback (#2525)
commit cd7a3d10e88a15e6151afca1d0f2b972d6058fcb
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Thu May 23 09:20:03 2024 -0700
Updating Azure.Identity version to 1.11.3 (#2526)
commit 5cb73fdc9fa408fcd033510b2e2182085c1f14c9
Author: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Date: Tue May 14 19:31:10 2024 +0100
Merged SqlClientFactory between .NET Core and Framework (#2369)
commit cc6ea2181af5473648d5c7f79b71be30132d0ac0
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Tue May 14 20:30:08 2024 +0200
Streamline conditional compilation symbols (#2486)
commit 9a71c94c172fd5b231e9673525e95c7079528fa9
Author: Saurabh Singh <1623701+saurabh500@users.noreply.github.com>
Date: Mon May 13 15:37:01 2024 -0700
Update build guide for Linux (#2499)
Adding the detail about installing powershell on linux to build the driver
commit 4c0f013bac63d8bd928c985440acb1e2bc13d3c6
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Tue May 7 18:02:12 2024 +0200
Remove UWP (uap) references and special cased code (#2483)
commit b4f38f50d4fb03e49956b8007496c50c22fbbea2
Author: Taylor Southwick <tasou@microsoft.com>
Date: Mon May 6 16:27:12 2024 -0700
Use ReadOnlyMemory in (#2447)
commit 55d30c71b9c17b804710b4d7ba83d92f2b2676be
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Mon May 6 10:58:22 2024 -0700
Test | Remove AAS - VBS tests from test pipelines (#2474)
commit 48ab625f82bc2f147276e02862b47b24f06d576c
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Sat May 4 02:08:39 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit 05d51bf26732a1784eb4a0b2d96b50bea6989486
Merge: 7def235d 910bdb47
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Fri May 3 21:58:12 2024 +0000
Merge in 'main' changes
commit 7def235d764c1b1fa12db242afecf146a18a60f6
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Fri May 3 21:51:35 2024 +0000
Merged PR 4490: eng | Remove netstandard from production pipeline
- Complementary code change of PR [#2386](https://github.com/dotnet/SqlClient/pull/2386).
- This should be merged after merging the related PR to remove support of .NET Standard in the production pipeline.
- The first commit has the related PR's changes(review them on GH).
- After having merged the related GH PR and updating the CI pipeline, I'll sync with this PR to unify the changes and get passed the pipeline.
- Only the YAML changes under the `eng` folder should be reviewed (ignore the other changes as they are identical to the GH).
- Introduced `oneBranchType` parameter to switch between **Official** and **NonOfficial** templates
- [new sample run](https://dev.azure.com/SqlClientDrivers/ADO.Net/_build/results?buildId=86908&view=results)
Related work items: #30122
commit 910bdb4754bfd11c2043c8f8b89b91df49e46888
Author: Wraith <wraith2@gmail.com>
Date: Fri May 3 21:10:35 2024 +0100
make EnableOptimizedParameterBinding only apply to text mode commands and update documentation to match. (#2417)
commit ba288ef35c09101e0d3b8e96b4003dffbaae7c98
Merge: f05be20e cd4805b1
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Fri May 3 20:03:36 2024 +0000
Merge in 'main' changes
commit cd4805b144e170c946602d5c54d65ef649bce9a5
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Fri May 3 21:42:21 2024 +0200
Remove support for .NET Standard 2.0 and 2.1 (#2386)
commit 792479efaa7155143f3276965fac42c84de35e2e
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Fri May 3 09:22:31 2024 -0700
Test | Remove field with ClientSecretCredential (#2479)
commit 226bdb8e4cedd3933ca415a91d69b8c814b5b9df
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Thu May 2 09:50:38 2024 -0700
Fix | Fix DateTimeOffset size in TdsValueSetter.cs class file. (#2453)
commit aefd723026e75e68cea6bc98173404a5c765ab60
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Tue Apr 30 11:00:01 2024 -0700
Test | Updating tests to acquire token from user-assigned managed identity (#2473)
commit f05be20efe40d356f6313f810123a2e5870714dc
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Fri Apr 26 20:34:02 2024 +0000
Merged PR 4529: eng | fix a few issues and improvements
- Fixed a typo, publish symbols, and commit number
- Updated the cron for daily run in case of any code changes, besides the weekly run
- Added parameters instead of pipeline's variables
- TSA, SBOM, and CodeQL tools moved out of the `syncSdl` for compatibility with OneBranch's NonOfficial template
Related work items: #29920
commit c33bde24d4b68116938423c728903ebb3fa74b34
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Fri Apr 26 11:12:08 2024 -0700
Change | Updating Azure.Identity version to 1.11.2 (#2462)
commit 3f3380ccde46102987e527be18b26aee3e9b2026
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Thu Apr 25 12:25:42 2024 -0700
Test | Address XUnit failure on Windows Principal functionality is not supported on this platform (#2469)
commit 4bce7de7bef52823e7733e553c3fd29c3ac6f4ae
Merge: abff6630 68d35bb5
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Tue Apr 23 17:21:01 2024 +0000
Merge in 'main' changes
commit 68d35bb5f116feb2fd10f6b0b2d09a4a835562d5
Author: Benjamin Russell <russellben@microsoft.com>
Date: Thu Apr 18 15:35:25 2024 -0500
Change | Simplify Conditional File Inclusion (#2425)
* Wrap files in appropriate `#if` and simplify project file
* Sorting file includes
* Pulling over changes from a different branch from before rebase
* Merge changes that should've come in during merge ...
* Add <IsTestProject>true</IsTestProject>
* Change that should've been brought in on merge :thinking:
commit abff6630e79ed9fa15c63355a88a5f90819ba199
Author: MerlinBot <MerlinBot>
Date: Wed Apr 17 15:42:10 2024 +0000
Merge pull request 4357 from dependabot/docker/dotnet_docker_images/1708216907 into internal/main
commit ea7ad53b26ce24fcb22e643691f50eb6627f35a4
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Mon Apr 15 19:57:54 2024 +0000
Merged PR 4474: eng | Add AKV provider signed package
commit ae988c3e6c09725f1190cfb399c6d51835357aa7
Merge: 0c46cd7e 61e89f95
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Fri Apr 12 19:49:16 2024 +0000
Merge in 'main' changes
commit 61e89f9570bbe53dff0e4c750ccbdb7a46b274b0
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Tue Apr 9 21:27:44 2024 +0200
Fix | ArgumentNullException on SqlDataRecord.GetValue when using Udt data type (#2448)
commit f5df519f5e9783d6a726fb370678e05a04a3084b
Author: Evgeny Akhtimirov <evgeny@devduty.com>
Date: Tue Apr 9 15:04:53 2024 -0400
Fix | SqlBuffer.SqlGuid (#2310)
commit 8c9b6992aa812cad39d21460314cd68f5a989b45
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Tue Apr 9 20:33:07 2024 +0200
Extend DateOnly/TimeOnly support to include DataTable as structured parameter (#2258)
commit 4e6853e2dd61be2d0cde181c4c85e61dd7a2d2b5
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Tue Apr 9 20:32:27 2024 +0200
Update Microsoft.Identity dependencies (#2429)
commit 1bf025afeb76eef9eddfdddd306241730d1d61af
Author: Trayan Zapryanov <lrt80@abv.bg>
Date: Mon Apr 8 22:19:37 2024 +0300
Rent byte buffers in SqlSequentialTextReader (#2356)
commit 0c46cd7e019fa67465cf9ca6ba63254f3e7ac206
Merge: 294f8666 9811c657
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Fri Apr 5 22:04:44 2024 +0000
Merge in 'main' changes
commit 9811c657db1cd1ddc270addc9221579df32af6ba
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Fri Apr 5 22:03:34 2024 +0000
eng | Fix production pipeline (#2450)
commit 294f8666aebbe713b9d634dbc8b17c2f5617d02d
Merge: af118d72 9645c01a
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Fri Apr 5 22:02:38 2024 +0000
Merge in 'main' changes
commit 9645c01a1ef235cb2342a3847f508f5887dc76b7
Author: Benjamin Russell <russellben@microsoft.com>
Date: Fri Apr 5 13:37:36 2024 -0500
Add <IsTestProject>true</IsTestProject> (#2446)
commit bc2a83414804ffe6f21f6778df73cfc6367cd95e
Author: Taylor Southwick <tasou@microsoft.com>
Date: Thu Apr 4 16:32:45 2024 -0700
Consolidate SSPI context generation to single abstraction (#2255)
* Abstract the SSPI context generation
This change introduces SSPIContextProvider that can generate payloads for SSPI. Specifically, this change plumbs the current SSPI context generation into this object, while later changes will continue to update the shape to be a more general purpose, public API.
commit af118d72e4d60bbe26a824c0dd9de6400d2753f7
Merge: 226b83ec 4778b876
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Thu Apr 4 18:48:59 2024 +0000
Merge in 'main' changes
commit 226b83ec0f94e2ea00834c0127886ca97a517d2d
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Thu Apr 4 16:19:50 2024 +0000
Merged PR 4462: eng | Fix pipeline netfx build change
Addressing the failure on [dotnet-sqlclient-Official](https://dev.azure.com/SqlClientDrivers/ADO.Net/_build/results?buildId=84259&view=logs&j=a59e3b7b-7df8-53a3-7568-e4c5ffd2c23d&t=fa94fa55-e846-59ba-ffea-8e9b3df3ad3a)
commit 4778b8760dfc83037e259e5f79845b21ac844c7d
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Thu Apr 4 01:02:40 2024 +0000
Moved NuGet.config to the root (#2443)
commit 537eba862d6c2a6e8793cbf874515424df2e8bab
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Tue Apr 2 21:06:05 2024 +0000
Doc | update a sample description in SqlConnection (#2440)
commit 908f563699989d8d118c5cc3d330e59a45e9428d
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Mon Apr 1 07:47:03 2024 -0700
Fix | Suppress CodeQL warning for usage of deprecated Ssl2. (#2428)
commit 740069d657d8e201973fc7b650965a830280abc1
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Mon Apr 1 07:42:04 2024 -0700
Fix | Suppress CodeQL X509RevocationMode warning. (#2432)
commit 74084b010eb0c4834476eade199f6e5e0307286b
Author: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Date: Sat Mar 30 03:24:58 2024 +0530
Fixes UdtTestDb creating script (#2421)
commit 1594cc5fa02a942346deffb0064313b130758f6a
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Fri Mar 29 14:23:43 2024 -0700
Merge common code base for DBReferenceCollection (#2403)
commit 0d455647cdad87d32beea3173eef421bd1a88264
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Thu Mar 28 16:49:55 2024 +0000
Merged PR 4422: Pipeline | Initiate YAML pipelines
- A successful sample run can be found with the non-official template [here](https://dev.azure.com/SqlClientDrivers/ADO.Net/_build/results?buildId=82875&view=results) without SDL tools.
- There are a few errors reported by code analyzer that need to be addressed as well.
- Due to the known issue with APIScan and Onebranch, it's temporarily deactivated.
Related work items: #28134
commit 30cd171e0129ccf80bd95add6191687e987bbd4d
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Mon Mar 25 11:57:36 2024 -0700
Change | Convert Netfx to SDK style (#2413)
commit bdfa5d8dbe9acfc01d034bc1fe8b73ce8fe28109
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Mon Mar 25 11:56:49 2024 -0700
Regression | Revert PR #2281 SNIProxy code change (#2395)
commit 4e23bf94c566e04a2fa7fb930af05f3d76fb30c8
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Thu Mar 21 10:44:40 2024 -0700
Fix | The SqlConnection.FireInfoMessageEventOnUserErrors when set to true throws an exception (#2399)
commit 9056f13a18b82dc2698ad04da905c16ed5d4ed3f
Author: Benjamin Russell <russellben@microsoft.com>
Date: Tue Mar 12 13:31:06 2024 -0500
Downgrade Xunit, Improve exception handling for Diagnonstic Tests (#2379)
**Description**: While doing some investigation into improving the diagnostic tracing tests, I noticed that test failures are logged very non-descriptly by remote executor. To resolve this issue, we have to downgrade xunit to v2.4.2. Here's the rationale for this change:
* RemoteExecutor throws `XunitException`s from xunit.assert nuget and uses the `(string, string)` constructor
* The `(string, string)` constructor was removed in >=2.5 of xunit.assert
* RemoteExecutor was fixed to inherit from Exception in newer versions, but for us to take this requires upgrading to .net 7 or 8 (which I imagine is a much larger lift)
* In order to downgrade xunit.assert, we need to downgrade xunit
* In order to downgrade xunit, we also need to downgrade Microsoft.DotNet.XunitExtensions
* Without this change, exceptions from RemoteExecutor will fail to construct, masking all errors with "MethodNotFound"
Although normally downgrading is bad for security reasons, I believe this to be a safe change since it only affects tests.
This PR also makes a bunch of improvements to the `DiagnosticTest`s:
* Remove conditional facts when test TDS server is used
* Remove try/catch with empty catch block, replace with assert.throws
* Ensure that connections are opened before trying test conditions
* Document scenarios where test TDS server doesn't obey actual behavior, or where test TDS server cannot be used
* Formatting improvements
**Testing**:
* All tests (that are expected to pass) continue to pass
* In a synthetic failure of diagnostic tests, here's the before and after of the error messages:
* Before:
```
System.MissingMethodException: Method not found: 'Void Xunit.Sdk.XunitException..ctor(System.String, System.String)'.
System.MissingMethodException
Method not found: 'Void Xunit.Sdk.XunitException..ctor(System.String, System.String)'.
```
* After:
```
Microsoft.DotNet.RemoteExecutor.RemoteExecutionException: Remote process failed with an unhandled exception.
Microsoft.DotNet.RemoteExecutor.RemoteExecutionException
Remote process failed with an unhandled exception.
Child exception:
Xunit.Sdk.FailException: Assert.Fail(): Foo
at Microsoft.Data.SqlClient.ManualTesting.Tests.DiagnosticTest.<>c.<SyntheticFailure>b__1_0() in
C:\Projects\benrr101\sqlclient\src\Microsoft.Data.SqlClient\tests\ManualTests\TracingTests\DiagnosticTest.cs:line 34
```
* Downgrade xunit for better error logging from remote executor
* All but one test improved ... ?
* Understanding why test was failing
* Add arcade and xunit nugets to .net8+ special versions
* Remove xunitextensions version boost (which I spelled wrong anyhow)
commit 769b982606bc97fee797d6c061973c28400aa362
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Mar 6 19:24:54 2024 -0800
Adding CommonSourceRoot variable to Directory.Build.Props (#2392)
commit 4e341dcba8e5fe7248f2e3870e355aa78af46a3f
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Mar 6 14:20:33 2024 -0800
Update | updating version props for MDS v6.0.0 (#2382)
commit 5376a04adf786735422029e808333d2a3c6d1fef
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Tue Mar 5 09:12:26 2024 -0800
Fix | Fixed SqlBulkCopy.WriteToServer to ensure successful completion of consecutive calls to it. (#2375)
commit 2ddf7237328b45a4a5a9d41dc7d7edf4f566ae9b
Author: Jihoon Park <bartleby2718@gmail.com>
Date: Mon Mar 4 13:44:09 2024 -0500
Doc | Fix typo in SqlConnectionEncryptOption.xml (#2381)
commit ced726a3ee7b955be238267cc6dd7d61971731b4
Author: David Engel <v-davidengel@microsoft.com>
Date: Fri Mar 1 13:04:36 2024 -0800
Remove test reference to deprecated ADAL library (#2360)
commit 1a009b46c9729080c477882b3ce4c26285964de5
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Fri Mar 1 18:49:25 2024 +0100
Test | Improve test quality of life (#2331)
commit 8ef005a2ee67c55b2900bcbe32a931e3de64c556
Author: Benjamin Russell <benrr101@outlook.com>
Date: Wed Feb 28 17:38:28 2024 -0600
Build Tweaks for Onboarding (#2366)
commit 64bfe506d77e39ab31db5999b64253210907a59b
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Wed Feb 28 10:39:12 2024 -0800
Release Notes 5.2.0 (#2370)
commit faf9b95995e6200a980bb6b1980f1d7af9f46cef
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Wed Feb 28 03:17:52 2024 +0000
Fix | ExecuteReaderAsync API xml and ref files (#2373)
commit 51ef22cd50eaa26432e6ec589bf70f7b72f5b60a
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Tue Feb 27 22:41:32 2024 +0000
Fix | ExecuteReaderAsync API return type in ref file (#2372)
commit e9cab013454b257ef70a004791f28682ac1f8019
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Tue Feb 27 20:30:02 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit 10c9e17283f7a4f1cfefcb080f9499461cc31d21
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Tue Feb 27 19:41:38 2024 +0000
Fix | Refine documents for GA v5.2 (#2371)
commit 94c089e75842909efb2226edc248f41c3776a037
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Mon Feb 26 14:00:09 2024 -0800
Fix | Fix unit test for SPN to include port number with Managed SNI (#2281)
commit 5cd9514cf27b78cf74f4d784b63246c5477552f2
Author: Javad Rahnama <v-jarahn@microsoft.com>
Date: Mon Feb 26 12:46:16 2024 -0800
Test | Adjust tests to read IsAzureSynapse value from database (#2367)
commit 5a98166c6668b2d12e841d1dc9f69d9d2c0cbde2
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Thu Feb 22 03:11:15 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit 8b1b7a94ab3560c6b78377d85239af71f80b904b
Author: Javad <v-jarahn@microsoft.com>
Date: Wed Feb 21 13:06:55 2024 -0800
Fix | Removing non-breaking space from links inside some of exception messages. (#2364)
commit ed949d5b3dc504e1dc822c07c2c8f14332305b29
Author: Javad <v-jarahn@microsoft.com>
Date: Wed Feb 21 10:13:47 2024 -0800
Change | Updating SNI version to 5.2.0 (#2363)
commit e3cf59d226675acf7ae9169989ac692aea04f3da
Author: SqlClient DevOps <sqlclient@microsoft.com>
Date: Wed Feb 14 03:08:15 2024 +0000
[Scheduled Run] Localized resource files from OneLocBuild
commit af7d39d4496c23fa1660c828a84f31680c0079fc
Author: Javad <v-jarahn@microsoft.com>
Date: Tue Feb 13 13:52:23 2024 -0800
Fix | Addressing typo in exception message (#2357)
commit 237f260f600752b69eba05a65582d19f7f02e88d
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Tue Feb 13 17:24:35 2024 +0000
Test | Docker test enhancement (#2345)
commit ca5e3e835feff5836a06aff511acf7080ce76f49
Author: Javad <v-jarahn@microsoft.com>
Date: Fri Feb 9 20:17:21 2024 -0800
Removing DSA public key from SqlColumnEncryptionProvider to address CodeQL flags. (#2347)
commit 91df016175f2b24fd210b641d3e35eb2a708ad27
Author: H. Yeo <138053434+H-Yeo@users.noreply.github.com>
Date: Fri Feb 9 15:39:19 2024 -0800
Docs | Update Release Documentation for Contributors (#2351)
commit 06632465470be52ab472d4eee9b6028c5cef5422
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Fri Feb 9 10:34:19 2024 -0800
Fix | Mismatch System.Diagnostics.DiagnosticSource between versions.props and nuspec (#2349)
commit 507e8dd64d8c6235f81c9c1864013e7ee3f3f100
Author: Javad <v-jarahn@microsoft.com>
Date: Fri Feb 2 09:51:59 2024 -0800
AKV Release notes (#2335)
commit 4a2522df26abd6b8818b3f765c3745211272b07d
Author: Javad <v-jarahn@microsoft.com>
Date: Thu Feb 1 14:44:44 2024 -0800
Fix | Adding missing commitID to AKV nuspec (#2334)
commit 5e07b2959a5cd07d0f920e0484ad5c549ea29ec9
Author: Javad <v-jarahn@microsoft.com>
Date: Wed Jan 31 00:09:16 2024 -0800
Change | Updating AKV dependencies (#2330)
* Updating AKV dependencies
commit 5d106fe8c543230df8fa2f8dd9db341c89bd196b
Author: Javad <v-jarahn@microsoft.com>
Date: Mon Jan 29 16:20:53 2024 -0800
Release notes 5.1.5 (#2326)
commit 644cabaeab2e78bfa4d33effcc8ecd278cff7722
Author: Javad <v-jarahn@microsoft.com>
Date: Mon Jan 29 13:55:53 2024 -0800
removing pdb from nuget's ref folder (#2329)
commit 14d7292d9c22040be45a3d9e1f2c135ad013fc60
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Fri Jan 26 01:10:59 2024 +0000
Test | Fix test projects package dependencies (#2319)
commit 586cf04cf5ee9deaa5c5263ba8e15810840a5587
Author: H. Yeo <138053434+H-Yeo@users.noreply.github.com>
Date: Thu Jan 25 11:53:07 2024 -0800
Preview Release Notes 5.2.0-Preview5 (#2316)
commit 348738961a88421629308a012fe7c2c3216d9108
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Wed Jan 24 13:02:59 2024 -0800
Fix | Fix driver to not send expired token and refresh token first before sending it. (#2273)
commit 9347412583cbf7e25f84fcc9ab5995308224893f
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Wed Jan 24 18:56:24 2024 +0100
Update nuspec on .net 6.0 (#2317)
commit 7fd34dfeba9c864182d8e9d39830c4d1e1f1607c
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Wed Jan 24 08:47:53 2024 -0800
Enhance project and target files to generate debugging symbol package files (#2137)
commit c8b70f1aa0870d0a927a0142735405077ebb11ec
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Wed Jan 24 00:57:28 2024 +0100
Enhancement | Add explicit version for major .NET version dependencies (#2303)
commit 4ca71d901a0f5d21b47195e0044279c2ac71878c
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Tue Jan 23 17:44:57 2024 +0100
Revert "Perf | avoid boxing of SqlGuid in SqlBuffer (#2306)" (#2311)
This reverts commit 9602271e20a1983cf4f0edf3fb8e18d8538e112c.
commit 838b931809af6c6236a600d559a086cfe1e77593
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Fri Jan 19 23:44:26 2024 +0000
Fix | Invalid transaction exception against the connections and distributed transactions (#2301)
commit 9602271e20a1983cf4f0edf3fb8e18d8538e112c
Author: Evgeny Akhtimirov <evgeny@devduty.com>
Date: Fri Jan 19 18:43:41 2024 -0500
Perf | avoid boxing of SqlGuid in SqlBuffer (#2306)
commit b460fd098e94af6c12f3b3fdc9bb9dbe67fc2f10
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Fri Jan 19 03:01:28 2024 +0100
Fix | Add missing dependency update for netstandard2.0 (#2305)
fixes #2304
commit 900d051965a630aba0c42e61fe9b843a67570d3e
Author: panoskj <37297673+panoskj@users.noreply.github.com>
Date: Wed Jan 17 21:57:31 2024 +0200
Merge common code bases for TdsParserStateObject.cs (4) (#2254)
commit b12b15d6f61d99870e420c169e4a58711ebf9e0c
Author: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Date: Sat Jan 13 00:56:22 2024 +0100
Fix | Enable reading AE date as DateOnly (#2275)
commit 55aa1eeb620bcbd5f9c10f5305249af74ae3fac1
Author: H. Yeo <138053434+H-Yeo@users.noreply.github.com>
Date: Fri Jan 12 13:31:01 2024 -0800
Tests | Fix Tests regarding Concurrency both Sync and Async versions. (#2279)
commit eb68e1b52ac6acbce00d29b262ebd4d3140dd1e4
Author: Javad <v-jarahn@microsoft.com>
Date: Fri Jan 12 10:00:09 2024 -0800
Add | Adding net8 support (#2230)
commit 8663853b4df831f3b52cd14b9ba3f94c2b9cd260
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Fri Jan 12 17:28:04 2024 +0000
CVE | Version bump Microsoft.IdentityModel.JsonWebTokens to 6.35.0 (#2290)
commit 2e4d1b69793e7ca3d7d9f2bc85206b933808ef3c
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Tue Jan 9 21:58:25 2024 +0000
Fix | SQL auth method validation on debug (#2288)
commit 84720a74fa640cf9cea7967a3b74d0220d00961b
Merge: ee638d4f 5f00e1ce
Author: SqlClient Azure DevOps <sqlclient@microsoft.com>
Date: Tue Jan 9 19:30:41 2024 +0000
Merge in 'main' changes
commit ee638d4ffd5bcb542998b706c7ba183853a0077e
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Mon Jan 8 17:05:13 2024 +0000
Merged PR 4233: Release notes 3.1.5
Add note
commit 7cb40938b85cb3901f2c0e30c63da63ee531de1f
Author: Davoud <v-deshtehari@microsoft.com>
Date: Tue Jan 9 10:13:49 2024 -0800
Merged PR 4228: Address encryption downgrade issue
commit 5ed0717b46e5901194504a03025ca06cea75eb88
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Tue Jan 9 05:58:04 2024 +0000
Merged PR 4229: Certificate chain validation logic fix
Ports PR [#4047](https://dev.azure.com/SqlClientDrivers/ADO.Net/_git/dotnet-sqlclient/pullrequest/4047)
commit a1769cda2eac047f6a3a0042d754e6e14e9f8817
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Mon Jan 8 23:02:22 2024 +0000
Merged PR 4236: Release notes 5.1.4
commit ce6526ac9db7c8b14421b0ad1f56752f75df1d8d
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Mon Jan 8 18:55:13 2024 +0000
Merged PR 4230: Release notes 5.1.3
commit 665af6cabe6e3bf6be0db7973377a3bd201202a1
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Mon Jan 8 18:49:16 2024 +0000
Merged PR 4234: Release notes 2.1.7
add note
commit 81a54d8233f7edf6c060218e162335963bd94faa
Author: Davoud Eshtehari <v-deshtehari@microsoft.com>
Date: Mon Jan 8 18:48:59 2024 +0000
Merged PR 4232: Release notes 4.0.5
Add notes
commit 5f00e1ce77b17f548c658b19b31d60f5968f50d2
Author: Sanjam Panda <36253777+saitama951@users.noreply.github.com>
Date: Fri Jan 5 02:22:43 2024 +0530
gc collect fix for mono (#2277)
commit 5794ab3af5b58e66b2829a1355b692a73210ee9c
Author: Javad <v-jarahn@microsoft.com>
Date: Fri Dec 15 15:37:03 2023 -0800
Test | Updating xunit version (#2271)
commit 04b531bab5ad5c0bdf204d443b6f3da88c2429b9
Author: Javad <v-jarahn@microsoft.com>
Date: Tue Dec 12 09:02:50 2023 -0800
Release notes v5.2.0-preview4 (#2263)
commit 923cad7d303de222ba0aa3630fbedfac96a71e82
Author: Javad <v-jarahn@microsoft.com>
Date: Fri Dec 8 09:56:23 2023 -0800
Update | Adding ActiveDirectoryWorkloadIdentity to ref folder and soring the n… (#2264)
commit d18e5c1557c8bbe08b1a876cc137a6c207de5751
Author: Sanjam Panda <36253777+saitama951@users.noreply.github.com>
Date: Fri Dec 8 05:46:56 2023 +0530
Support For Big Endian Systems (#2170)
commit 59080c8e5eca0b3455aed362ec9ba913b59ef788
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Thu Dec 7 23:38:26 2023 +0000
Fix | Linux SPN port number using named instance and Kerberos authentication does not return port# (#2240)
commit 09c9588c760317a3115489c0c9875b951f02610e
Author: Javad <v-jarahn@microsoft.com>
Date: Thu Dec 7 14:10:04 2023 -0800
Change | Change Azure.Core in M.D.S.AE.AKV (#2261)
commit 17590d3c3f393d66717e0680fdb03fb09b0df409
Author: Will Sugarman <will.sugarman@gmail.com>
Date: Thu Dec 7 12:01:19 2023 -0800
Add | Add Workload Identity Support (#2159)
commit 4319661269be1fa15d7d2f819079b6840bfe11d3
Author: Javad <v-jarahn@microsoft.com>
Date: Wed Dec 6 14:08:32 2023 -0800
Change | Change SNI Version to v5.2.0-preview1 (#2257)
commit 420323799b60c3d7b058fcf944eb46d06fcf9a43
Author: David Engel <v-davidengel@microsoft.com>
Date: Wed Nov 29 17:44:48 2023 -0800
Fix | Don't validate server certificate when using Authentication option but not encrypting (#2224)
commit 1543998220fe81e372b484d48925c648c6a9b3c8
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Wed Nov 29 18:15:09 2023 +0000
Doc | Improve connect retry count for high demand endpoints on Azure (#2233)
commit 416afcdf5141d19716b9b94e8f3146998c29b538
Author: panoskj <37297673+panoskj@users.noreply.github.com>
Date: Tue Nov 28 22:13:37 2023 +0200
Merge common code bases for TdsParserStateObject.cs (3) (#2168)
commit e6109f8d60766bf9b9ed5e323f5bd50e221cb527
Author: Wraith <wraith2@gmail.com>
Date: Wed Nov 22 16:57:10 2023 +0000
SqlBatch: Add missing overrides and tests (#2223)
commit b02cf417a5e8a35bee3903d8b8229a25c61fb864
Author: Wraith <wraith2@gmail.com>
Date: Tue Nov 21 21:13:30 2023 +0000
cache all appcontext switches (#2227)
commit 4f7335550ef1c54910575855d199373ce2ee0a44
Author: David Engel <v-davidengel@microsoft.com>
Date: Thu Nov 16 15:33:05 2023 -0800
Test Fix | CertificateTests are only designed to run against localhost SQL installs (#2219)
commit d30d9d107eca0f11b735a550aa187e57167858c9
Author: Wraith <wraith2@gmail.com>
Date: Thu Nov 9 18:47:44 2023 +0000
Add | Feature: SqlBatch api (#1825)
commit 7f203dd03875d1167425dcc92619c143e41f9e59
Author: Wraith <wraith2@gmail.com>
Date: Tue Nov 7 20:01:46 2023 +0000
Remove duplicated ForceColumnEncryption property check (#2166)
commit b3110be60d18e358ad23fa40e9ba9f952aadbca0
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Mon Nov 6 12:39:55 2023 -0800
Test | Fix HNIC tests to support named instance sql servers (#2205)
commit 6456d71414347238d4bd519dbfdf1d936ca4cea6
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Tue Oct 31 22:40:24 2023 +0000
[3.1.4] Release notes (#2200)
commit d5df671376b3114e8f7adc570b95073b796b6e16
Author: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Date: Tue Oct 31 11:20:17 2023 -0700
Fix | Fixing issue for SQL named Instances in Managed SNI using named pipes. (#2142)
commit 5a4feed431149802c8497c2a720b1b721adbfba6
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Mon Oct 30 20:02:40 2023 +0000
[4.0.4] Release notes (#2199)
commit e719601a69070ca0f94f44b3345936603380826f
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Thu Oct 26 17:50:21 2023 +0000
[5.1.2] Release notes (#2197)
commit 6beab6a69477959429f3f5905ca17c286b777113
Author: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Date: Wed Oct 25 01:09:32 2023 +0000
Fix | Support Georgian collation (#2194)
commit b86ddf19f992b8c5e6a0ff1b4b43ed37d31b19bf
Author: Wraith <wraith2@gmail.com>
Date: Wed Oct 25 02:07:19 2023 +0100
move PacketData and list management to shared and reimplement as doubly linked list. (#2164)
commit 57d287c1ca0a4750b7421bc7a2a70b09ac71ca05
Author: Javad <v-jarahn@microsoft.com>
Date: Mon Oct 23 14:39:55 2023 -0700
Test | Removing internal build of XunitExtensions and using the nuget (#2033)
commit 97863e59ad613ba275912bc93f1aef34f0ee0014
Author: Javad <v-jarahn@microsoft.com>
Date: Mon Oct 23 10:46:15 2023 -0700
Fix | Upgrade dependencies versions (#2189)
commit b7167c02255a4785a400037f89060b3d275c53d3
Author: Daniel Marbach <daniel.marbach@openplace.net>
Date: Fri Oct 20 19:59:52 2023 +0000
Ports Fix deadlock in transaction (#1242) to .NET (#2161)
commit 85ba241aaa0750089c1409a98220d88ef3e14146
Author: Viktor Hofer <viktor.hofer@microsoft.com>
Date: Fri Oct 20 19:43:30 2023 +0200
Remove stale dependencies from SqlClient (#2186)
commit 55eb1305bdf958767611b9a506d4ac4b94b8bb63
Author: JJ <103335846+computerscienceiscool@users.noreply.github.com>
Date: Thu Oct 19 14:56:28 2023 -0700
Update README.md (#2185)
Removed a double word
commit 9e0d8b7095e051a6146904ed34738fb3497ceb62
Author: Wraith <wraith2@gmail.com>
Date: Wed Sep 27 05:10:00 2023 +0100
deprioritize altmetadata and altrow tokens and annotate them as deprecated (#2165)
commit 111033e65625c435295cea500508a13e00a3d764
Author: Wraith <wraith2@gmail.com>
Date: Wed Sep 20 19:18:19 2023 +0100
move stateObj snapshot to a new class in shared (#2157)
commit c1984b822f8d31794cd8c85245cc6d7bd1059526
Author: David Engel <v-davidengel@microsoft.com>
Date: Fri Sep 15 14:14:15 2023 -0700
Doc | Move attestation protocol remark to the correct place (#2153)
commit cc5f05a8e18d188bfa49adb51f6df2e4f5533e48
Author: Wraith <wraith2@gmail.com>
Date: Fri Sep 15 17:31:18 2023 +0100
Merge TDSParserStateObject.StateSnapshot state flags (#2132)
commit 816a7d3dc8ae2f9c6a691d133723a73b54e5e628
Author: Javad <v-jarahn@microsoft.com>
Date: Thu Sep 14 12:36:32 2023 -0700
SDL | Changing ReadXml to a more secure overload. (#2147)
commit 7b2e2fc9f002e8b270894595f5f92670670053d7
Author: Javad <v-jarahn@microsoft.com>
Date: Wed Sep 13 11:24:06 2023 -0700
Test | Fixing MARS manual tests on some debug field's names and some minor changes (#…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the authentication option (Authentication=SqlPassword or other value), the netfx code would try to validate the server certificate regardless of whether or not encryption was negotiated. This resulted in the requirement to set TrustServerCertificate=true, even if client and server encryption was off, in order for connections to succeed when the server doesn't have a public certificate provisioned. This also manifests in the same manner when using Authentication=ActiveDirectoryIntegrated. In a Kerberos flow, that option behaves like IntegratedSecurty=true.