Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0.2] Fix | Adding disposable stack temp ref struct and use #1980

Conversation

lcheunglci
Copy link
Contributor

Backporting fix to 5.0-servicing branch. This fixes the memory leak in the CancellationToken introduced from #1785 to address #1810. These changes are based on #1818.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: +0.02 🎉

Comparison is base (9bd90e6) 71.41% compared to head (781325c) 71.44%.

Additional details and impacted files
@@                Coverage Diff                @@
##           5.0-servicing    #1980      +/-   ##
=================================================
+ Coverage          71.41%   71.44%   +0.02%     
=================================================
  Files                293      294       +1     
  Lines              61381    61393      +12     
=================================================
+ Hits               43835    43861      +26     
+ Misses             17546    17532      -14     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 75.11% <76.36%> (+0.05%) ⬆️
netfx 69.26% <72.91%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...etfx/src/Microsoft/Data/SqlClient/SqlDataReader.cs 68.48% <63.88%> (ø)
...core/src/Microsoft/Data/SqlClient/SqlDataReader.cs 72.84% <69.76%> (ø)
...osoft/Data/SqlClient/DisposableTemporaryOnStack.cs 100.00% <100.00%> (ø)

... and 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lcheunglci lcheunglci added this to the 5.0.2 milestone Mar 31, 2023
@lcheunglci lcheunglci merged commit 5001097 into dotnet:5.0-servicing Mar 31, 2023
@ErikEJ
Copy link
Contributor

ErikEJ commented Apr 1, 2023

@David-Engel @lcheunglci Really appreciate your response to community feedback.

@lcheunglci lcheunglci deleted the 5.0-Backport-1818-CancellationToken-Memory-Leak-Fix branch April 1, 2023 17:19
@lcheunglci
Copy link
Contributor Author

Thanks @ErikEJ for reminding us. We're glad that you were able to spot it since 5.0 will reach EOS in July, and it's uncertain if there'll be a 5.0.3 in time.

@ErikEJ
Copy link
Contributor

ErikEJ commented Apr 1, 2023

@roji Interesting. So EF Core 7 will depend on an unsupported SqlClient version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants