-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0.1] Hang on infinite timeout and managed SNI #1798
Conversation
Can you link or describe the issue with a repro? |
The regression introduced in #1578. The issue was first reported at #1733 Basically, when you set the time out to 0 it hangs forever. AppContext.SetSwitch("Switch.Microsoft.Data.SqlClient.UseManagedNetworkingOnWindows", true);
var sw = Stopwatch.StartNew();
using var connection = new SqlConnection("Server=.;Database=master;Integrated Security=false;User ID=sa;Password=SomePassword;Pooling=true;Max Pool Size=1024;TrustServerCertificate=true;Timeout=0");
await connection.OpenAsync();
using var cmd = connection.CreateCommand();
cmd.CommandText = "SELECT 1";
await cmd.ExecuteNonQueryAsync();
Console.WriteLine($"Connection established successfully in {sw.ElapsedMilliseconds}ms. Press any key to continue...");
Console.ReadKey(); |
Codecov ReportBase: 65.47% // Head: 71.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 5.0-servicing #1798 +/- ##
=================================================
+ Coverage 65.47% 71.43% +5.96%
=================================================
Files 293 293
Lines 61385 61379 -6
=================================================
+ Hits 40189 43848 +3659
+ Misses 21196 17531 -3665
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks for bringing this in ❤️ |
Backporting #1742, which fixes #1733.