Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small inconsistency between netcore and netfx #1672

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

David-Engel
Copy link
Contributor

@David-Engel David-Engel commented Jul 18, 2022

One-line change. Netcore implementation is already correct.

@David-Engel David-Engel added this to the 5.0.0 milestone Jul 18, 2022
@David-Engel David-Engel changed the title Fix inconsistency between netcore and netfx Fix small inconsistency between netcore and netfx Jul 18, 2022
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #1672 (0a30f56) into main (8682741) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1672      +/-   ##
==========================================
- Coverage   71.44%   71.32%   -0.13%     
==========================================
  Files         291      291              
  Lines       61241    61241              
==========================================
- Hits        43756    43680      -76     
- Misses      17485    17561      +76     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.91% <ø> (-0.11%) ⬇️
netfx 69.14% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 70.91% <0.00%> (-0.08%) ⬇️
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs 30.35% <0.00%> (-11.61%) ⬇️
...src/Microsoft/Data/SqlClient/SqlMetadataFactory.cs 81.66% <0.00%> (-10.84%) ⬇️
...ActiveDirectoryAuthenticationTimeoutRetryHelper.cs 56.81% <0.00%> (-6.82%) ⬇️
.../src/Microsoft/Data/SqlClient/SNI/SNIMarsHandle.cs 87.89% <0.00%> (-4.49%) ⬇️
...crosoft/Data/ProviderBase/DbReferenceCollection.cs 92.63% <0.00%> (-3.16%) ⬇️
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs 60.62% <0.00%> (-2.34%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.48% <0.00%> (-0.59%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.36% <0.00%> (-0.51%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 72.88% <0.00%> (-0.40%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8682741...0a30f56. Read the comment docs.

@DavoudEshtehari DavoudEshtehari merged commit 98acbf1 into dotnet:main Jul 20, 2022
@DavoudEshtehari DavoudEshtehari added the Area\Netfx Issues that are apply only to .NET Framework or the 'netfx' project folder. label Jul 20, 2022
@David-Engel David-Engel deleted the fix branch July 21, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Netfx Issues that are apply only to .NET Framework or the 'netfx' project folder.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants